From nobody Mon Sep 8 20:03:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1740478238948695.7916847972782; Tue, 25 Feb 2025 02:10:38 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 8C9361940; Tue, 25 Feb 2025 05:10:37 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 1DFA21798; Tue, 25 Feb 2025 05:10:20 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id CE41D1715; Tue, 25 Feb 2025 05:10:17 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 53DB91656 for ; Tue, 25 Feb 2025 05:10:17 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-389-hNnYL8UpMZ-pet-ENlY9SA-1; Tue, 25 Feb 2025 05:10:15 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CA78419783B3 for ; Tue, 25 Feb 2025 10:10:14 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 246C21800946 for ; Tue, 25 Feb 2025 10:10:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740478217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Gn3u1W/dEbPaqfsfJ9ArpdQBTFM94B2o9a5GBrIfbZo=; b=VPZgrBPfgjf3RmVmQt8n4naOmY8kYkI2WUr3Hl3X3wKPvaTaEamC/DFOIoHEJf+H+GpT42 n6tVIenIXZNsutIQLEvM+pBEDfAkx6jnccowVUelMwly0WFn8R9gEXak62C8DmqDihKFkD 2xPrd6GJeGMZFhSUOVdHijwXEo2zdes= X-MC-Unique: hNnYL8UpMZ-pet-ENlY9SA-1 X-Mimecast-MFC-AGG-ID: hNnYL8UpMZ-pet-ENlY9SA_1740478214 From: Michal Privoznik To: devel@lists.libvirt.org Subject: [PATCH] apparmor: Allow SGX if configured Date: Tue, 25 Feb 2025 11:10:12 +0100 Message-ID: <5d7a0cd2f96734297df55a78d7f7eea5a3710fda.1740478192.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 895-59qSejYYkhbDar9pyzU-bYYNn57OglCSCOuKdb8_1740478214 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: SACLNAI6US7SX64UFEEWE343CKXCCJYX X-Message-ID-Hash: SACLNAI6US7SX64UFEEWE343CKXCCJYX X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1740478240743019100 Content-Type: text/plain; charset="utf-8"; x-default="true" If SGX memory model is configured for domain then we need to allow QEMU access some additional files: 1) /dev/sgx_vepc needs to be RW 2) /dev/sgx_provision needs to be RO We already do this in SELinux driver but not in AppArmor. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/751 Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- I've tested this successfully on my ubuntu machine. src/security/virt-aa-helper.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 1626d5a89c..c255b64f35 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1152,9 +1152,15 @@ get_files(vahControl * ctl) if (vah_add_file(&buf, mem->source.virtio_pmem.path, "rw") != =3D 0) goto cleanup; break; + case VIR_DOMAIN_MEMORY_MODEL_SGX_EPC: + if (vah_add_file(&buf, DEV_SGX_VEPC, "rw") !=3D 0 || + vah_add_file(&buf, DEV_SGX_PROVISION, "r") !=3D 0) { + goto cleanup; + } + break; + case VIR_DOMAIN_MEMORY_MODEL_DIMM: case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_MEM: - case VIR_DOMAIN_MEMORY_MODEL_SGX_EPC: case VIR_DOMAIN_MEMORY_MODEL_NONE: case VIR_DOMAIN_MEMORY_MODEL_LAST: break; --=20 2.45.3