From nobody Sun Feb 8 23:19:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) client-ip=216.205.24.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585324338; cv=none; d=zohomail.com; s=zohoarc; b=bQRG5jMnJL49G7hQJbZwPYJVVZWN4zuZQdWRzuEWvVk7/O1izIDUl/ocbpDCa86lmohYaZzZLXcbY16FOMLo7tg2fH4J2FRS/DFrQfnO8TOmFM56E7j/D7rDeBb3NgWtKlQ1hgo5H5nGXSi8Q/0c0rJzlt8+eXsskS6TCInGe0g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585324338; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h51NnGsIQocg3Fm6qVIA0zsUIvON/zgZVvvndCZvnJk=; b=mabKqybk0S/+x45XsPc0I9hQ4JvjR6Rngbf9AwM8VgdzBXYL2S2VH7+pJi01+0gxCG6RBWZbjhodYF7ECeOjGFPbxjDJDWEo1P9PRWsFz4wTp4QMPZXDcOdrqiq3aIE5ODRVxHns5CshTKZsx8GHF130HZ79hm71f9j7Yschins= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mx.zohomail.com with SMTPS id 1585324338755943.1475502051388; Fri, 27 Mar 2020 08:52:18 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-251-UxOL06deO6GgOwtXNmOXTA-1; Fri, 27 Mar 2020 11:52:13 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F178D86A067; Fri, 27 Mar 2020 15:52:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 41C4210027A4; Fri, 27 Mar 2020 15:52:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B10528A059; Fri, 27 Mar 2020 15:52:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02RFppDA011156 for ; Fri, 27 Mar 2020 11:51:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id 582E163148; Fri, 27 Mar 2020 15:51:50 +0000 (UTC) Received: from angien.redhat.com (unknown [10.43.2.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 47163177F7 for ; Fri, 27 Mar 2020 15:51:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585324337; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=h51NnGsIQocg3Fm6qVIA0zsUIvON/zgZVvvndCZvnJk=; b=Z16ZOCPJtGicM8mKCgmCp+wq/AhQFg3TPairZLLITqzabHwTfDBE+ywHbZz5qzV58IF6X2 81/rOL3CC6iiNszmQw0OQDL+ev6GwBeTZtunfog+QHmSzAe+f3PndoWz2BkUsje5ITuXNq cXgqP+18ZzrsiieRtRhUf0ofDcLxxNw= X-MC-Unique: UxOL06deO6GgOwtXNmOXTA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 3/3] qemuxml2argv: Test the query portion for HTTP disks Date: Fri, 27 Mar 2020 16:51:21 +0100 Message-Id: <5c7b3bbf001b9b9f249fc009a4f6c3e3c2853109.1585324237.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Add a simple test case for preserving the query portion of http disk's path. Signed-off-by: Peter Krempa --- tests/qemuxml2argvdata/disk-network-http.x86_64-latest.args | 5 +++-- tests/qemuxml2argvdata/disk-network-http.xml | 2 +- tests/qemuxml2xmloutdata/disk-network-http.x86_64-latest.xml | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/qemuxml2argvdata/disk-network-http.x86_64-latest.args b/= tests/qemuxml2argvdata/disk-network-http.x86_64-latest.args index ed44424dc3..7b4674a588 100644 --- a/tests/qemuxml2argvdata/disk-network-http.x86_64-latest.args +++ b/tests/qemuxml2argvdata/disk-network-http.x86_64-latest.args @@ -55,8 +55,9 @@ id=3Dvirtio-disk2 \ -object secret,id=3Dlibvirt-1-storage-httpcookie-secret0,\ data=3DDrPR9NA6GKJb7qi1KbjHaealKEMVtOWUl2h3yvO5lgIh6cyLHemmlg+h9fcgwREA,\ keyid=3DmasterKey0,iv=3DAAECAwQFBgcICQoLDA0ODw=3D=3D,format=3Dbase64 \ --blockdev '{"driver":"https","url":"https://example.org:1234/test4.img",\ -"sslverify":false,"cookie-secret":"libvirt-1-storage-httpcookie-secret0",\ +-blockdev '{"driver":"https",\ +"url":"https://example.org:1234/test4.img?par=3Dval&other=3Dble","sslverif= y":false,\ +"cookie-secret":"libvirt-1-storage-httpcookie-secret0",\ "node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \ -blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"raw= ",\ "file":"libvirt-1-storage"}' \ diff --git a/tests/qemuxml2argvdata/disk-network-http.xml b/tests/qemuxml2a= rgvdata/disk-network-http.xml index 93e6617433..3bcff14b95 100644 --- a/tests/qemuxml2argvdata/disk-network-http.xml +++ b/tests/qemuxml2argvdata/disk-network-http.xml @@ -42,7 +42,7 @@ - + diff --git a/tests/qemuxml2xmloutdata/disk-network-http.x86_64-latest.xml b= /tests/qemuxml2xmloutdata/disk-network-http.x86_64-latest.xml index cf36331286..b925f45e28 100644 --- a/tests/qemuxml2xmloutdata/disk-network-http.x86_64-latest.xml +++ b/tests/qemuxml2xmloutdata/disk-network-http.x86_64-latest.xml @@ -49,7 +49,7 @@ - + --=20 2.24.1