From nobody Tue Mar 24 01:04:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774253199; cv=none; d=zohomail.com; s=zohoarc; b=V+rm0fpDLs7od6xk6KpXCACYwfy0YyRpARvJNNc9U/QSV6efgx++qfn8j/JYUwlB+zA+cHl10kNo7Tbyjn0+SQqZYL7bOPDjsSf8Ik+NLTiSMCIeP7dDs6/zaj3wCR+Gjb0HC/Rt7+XuKL5OvojkLnlxa2fpfauV4POO32Nanek= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774253199; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=Lo//lTKbWqbgq0wnNwzJCOZX8ybdFVlqsDuwqjp1fz0=; b=mMc3MjEdgU8dYl1matI8oG3ZzP+ebKCH7TMiyLitfp9627jxTV9f8Ci3QpyEEqcKq5jTVkdN2Og70WvOjR7mX8MqfHANusH6GoGJjuv0cp/FYiK2NiRry0zMF5+ZR2Vz9+cYFxDl5R2b7Zgd6N3YdGt+0pAQycT3L9EFEU8U56g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774253199928299.93684891868395; Mon, 23 Mar 2026 01:06:39 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 20D643F319; Mon, 23 Mar 2026 04:06:39 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 8586C4192F; Mon, 23 Mar 2026 04:01:36 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 9F50D3F84F; Mon, 23 Mar 2026 04:01:30 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 1AA7A3F36A for ; Mon, 23 Mar 2026 04:00:58 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-534-3OjNBLSJPyqkYwPGte1dEQ-1; Mon, 23 Mar 2026 04:00:56 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6B6541944F01 for ; Mon, 23 Mar 2026 08:00:55 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B15AE1955D71 for ; Mon, 23 Mar 2026 08:00:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774252857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lo//lTKbWqbgq0wnNwzJCOZX8ybdFVlqsDuwqjp1fz0=; b=glQ1KkDF9NGSudauGcY1qpueHNPwGFeqYfpoIeMFDWzfQrO6wdiFOPRWq3IoiD/7H2MCKf KcU5QDx7+0lqZ6ObbEmBVSBVa6mekQv2PAQgvqbcuIKYg0UHQvUaHwSvS8bp/vujifHDrv VZ40MT59M+hIsCfwJkAZiY7n2G3JRsQ= X-MC-Unique: 3OjNBLSJPyqkYwPGte1dEQ-1 X-Mimecast-MFC-AGG-ID: 3OjNBLSJPyqkYwPGte1dEQ_1774252855 To: devel@lists.libvirt.org Subject: [PATCH 4/5] qemuBuildFSStr: Properly format 'readonly' attribute Date: Mon, 23 Mar 2026 09:00:41 +0100 Message-ID: <5c5a2d7f05825b2025c6907c36f0f8a9cb456a3b.1774252743.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QZwopqMOzynOG9tgf0MwQUMKgBE_vCM8boywzCvt6qM_1774252855 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: YOCMZB37RYGXOW5FUR4NJZ2AMXKBDX7W X-Message-ID-Hash: YOCMZB37RYGXOW5FUR4NJZ2AMXKBDX7W X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774253201997158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Short-form booleans are deprecated in qemu since qemu 6.0. Switch to the proper 'readonly=3Don' format. Closes: https://gitlab.com/libvirt/libvirt/-/work_items/864 Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 18f33a9d14..5b7423e354 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2478,7 +2478,7 @@ qemuBuildFSStr(virDomainFSDef *fs) virQEMUBuildBufferEscapeComma(&opt, fs->src->path); if (fs->readonly) - virBufferAddLit(&opt, ",readonly"); + virBufferAddLit(&opt, ",readonly=3Don"); return virBufferContentAndReset(&opt); } --=20 2.53.0