From nobody Mon Feb 9 07:56:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623926757; cv=none; d=zohomail.com; s=zohoarc; b=GOFXnwsqCnW/UW0i1ceA63GRH7TIB/pW72BWkjhjiyiP/JUyP5Q5TpQjit3bx5bDfHZMNKsHuEIAS2gM7xrXBfb/uzLWQHHaa7uixm0jslnGLlXP9xGt+gEQQzwoYLJkJZmO1WOFuJCN7YaCwlKOjiQxSDQlHs4usW5vfT3OfkQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623926757; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lvAE9CkNnF/DEhNtHOXAoSzvLdRw1dnNlPspAYsu1sM=; b=S2DZ4w7dMs1if34FNl1Xp2h23JCMNivEnFADaHPPjFjvt+JtA4HsV85F+H/UobltDq6fZzZLcGq//u650qJ9LwBU0GaJD4Jjajl9wx01ndMy++JkFZ+uIAR6BJ0iwQMfTtC2F09jOCxfrJ6R3kEH+5k4EMN5e8olfaxRYHA/JE0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1623926757765919.6159340995437; Thu, 17 Jun 2021 03:45:57 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-573-bnSZuqF2OtyS764lYlVS-g-1; Thu, 17 Jun 2021 06:45:55 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1F215100C611; Thu, 17 Jun 2021 10:45:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F069660FC2; Thu, 17 Jun 2021 10:45:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BBB8B46F59; Thu, 17 Jun 2021 10:45:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 15HAgHHD018881 for ; Thu, 17 Jun 2021 06:42:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2C56619D61; Thu, 17 Jun 2021 10:42:17 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id A428B19D7D for ; Thu, 17 Jun 2021 10:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623926756; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lvAE9CkNnF/DEhNtHOXAoSzvLdRw1dnNlPspAYsu1sM=; b=FOQrc+NXizTduJkc5E1dYTKFTajFXimuK7fVWxlmUX3q1yoJjJB2MdZPyv8bFJwt7+FqcY qUbx2IsQNCnq0I9JuzVtoXvPsdu6iTDXrL5UcwhRiQW5mbr5HsE6S4rnbUuCfG7xqpGHRO KzbqGpwfwhr+Lpm9XYGTyqihBkn2tCM= X-MC-Unique: bnSZuqF2OtyS764lYlVS-g-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 4/8] security_dac: Don't check for !priv in virSecurityDACSetOwnershipInternal() Date: Thu, 17 Jun 2021 12:42:04 +0200 Message-Id: <5a6d8e8067d289475072f5269be26a0f6a297316.1623926317.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The virSecurityDACSetOwnershipInternal() has two callers and in both the private data (@priv) is obtained via virSecurityManagerGetPrivateData(). But in case of DAC driver the private data can never be NULL. This is because the private data is allocated in virSecurityManagerNewDriver() according to .privateDataLen attribute of secdriver. In case of DAC driver the attribute is set to sizeof(virSecurityDACData). NB, no other function within DAC driver checks for !priv. Signed-off-by: Michal Privoznik --- src/security/security_dac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 6b8ff5cdef..b6323a7df1 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -677,7 +677,7 @@ virSecurityDACSetOwnershipInternal(const virSecurityDAC= Data *priv, /* Be aware that this function might run in a separate process. * Therefore, any driver state changes would be thrown away. */ =20 - if (priv && src && priv->chownCallback) { + if (src && priv->chownCallback) { rc =3D priv->chownCallback(src, uid, gid); /* here path is used only for error messages */ path =3D NULLSTR(src->path); --=20 2.31.1