From nobody Tue Oct 28 17:30:16 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1759757183; cv=none; d=zohomail.com; s=zohoarc; b=nX0dmTLR1BdImUaiH5jdfHCrZ2MGSgszQ9SoW86pqrOOepIxsbChWaNQ+gi6PB8lfoHkHNEmDDJPFGdQRBBf6qbitlX5pjJRq063oh5n+xuxzbVRll7MT0Lou+/4260/8xtGkV3I0uFgrjAvOttNdfW6M5Q2GoffvtrtM7IZ+YQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759757183; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=f1t+tynwKljtAylLeXLTvfWKJ7NcSVF+lcYWOT2TTGo=; b=BIFMrwh1j1Xx9tYLany6nwZOP5yMcROJpj8hmrnOC2mK2rWBK7ueNLp2n+0YLNUbmt8yAVvim49yjLlVFdoFsKQYsI5EhEa2OprZLR5Ii3tajsU7Eoh3nmO+ZgWPA1QiihnCJzDEq4u+sD40KMDjSgwYD+b/gIKTkK5MHvA/LzM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1759757183379476.5555511234618; Mon, 6 Oct 2025 06:26:23 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id E84E444358; Mon, 6 Oct 2025 09:24:23 -0400 (EDT) Received: from [172.19.199.17] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 8146944268; Mon, 6 Oct 2025 09:18:23 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 93C6841C8A; Mon, 6 Oct 2025 09:15:08 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E1A0141C82 for ; Mon, 6 Oct 2025 09:15:05 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-k1HFkT39OaWdbxWZcVnyLA-1; Mon, 06 Oct 2025 09:15:04 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 94C381956089 for ; Mon, 6 Oct 2025 13:15:03 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D4D8830002CC for ; Mon, 6 Oct 2025 13:15:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759756505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f1t+tynwKljtAylLeXLTvfWKJ7NcSVF+lcYWOT2TTGo=; b=VpVq9zYb8rao1ptZCJt8rGYSHSCZmFY8tKUMstKENkH5SrsM6ra9O2bGrJjM/30E5L/hw9 03nAdMdvvSAiqifGQFDiPodRhc3AS01l8qVVxP+WWO1FiCiJpR9EeUEVDVKIWfz853p0cB 0o3r74heY6/adJR48SCIOjcvkB5EkUM= X-MC-Unique: k1HFkT39OaWdbxWZcVnyLA-1 X-Mimecast-MFC-AGG-ID: k1HFkT39OaWdbxWZcVnyLA_1759756503 To: devel@lists.libvirt.org Subject: [PATCH 06/20] qemu_caps: Prefer VIR_DOMAIN_CAPS_ENUM_IS_SET() Date: Mon, 6 Oct 2025 15:14:37 +0200 Message-ID: <5a56d124d556f299fcc0669a11096e467e8c86b4.1759756003.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: C82CSbsbpL1un26vFG26Ob2TOfsD54XGBqehbUCWoqY_1759756503 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7EEUBVH7UGVJMUPQN6Q6NTRFQ4ANDJIM X-Message-ID-Hash: 7EEUBVH7UGVJMUPQN6Q6NTRFQ4ANDJIM X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1759757186523116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik While virDomainCapsEnum is in fact a bitmap, we also have a macro to manipulate/query individual bits. Prefer it to make the code more readable. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 618291e5b6..5b485d7bfb 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -5065,7 +5065,7 @@ virQEMUCapsFormatHypervCapabilities(virQEMUCaps *qemu= Caps, size_t i; =20 for (i =3D 0; i < sizeof(hvcaps->features.values) * CHAR_BIT; i++)= { - if (!(hvcaps->features.values & (1U << i))) + if (!VIR_DOMAIN_CAPS_ENUM_IS_SET(hvcaps->features, i)) continue; =20 virBufferAsprintf(&childBuf, "\n", --=20 2.49.1