From nobody Wed Apr 24 01:32:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683626089; cv=none; d=zohomail.com; s=zohoarc; b=N6EeW3uKYWK6r2obRDngIi/JzTO5Em98dkRGKv477LIL1IBt+IKJ4zpRDAQkkHhKxA36Cmi6o4IlI0KXmbuMCAijRpIt1RBPf0W2LJJMacTSJ0h2b6Yrs+P4zF5wdTObcwWUJDREqQuUqiNDiYU6zMbnUPQWWn13EF0MwxtG0yI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683626089; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=IIiGr0tksNJ8qbvk+lsfjxMFoYjcCwnFAwXLCv67Xks=; b=IPDTOBbW4W99avaQ/0sEfd/F35LIelCN58q2wyMbMjujHIFN8IbUmNrPcZODO1ORu6Su/XxVvRk5xVqZ6XUPMLGd6YIm47b3MU+VyOQgKa2/SKr6kq7s6MJZjckI9njgs+ZfhTuhhhClt7tpeM/ook+akjBzNkazCg1DxOGVzBQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1683626089456174.61002101476845; Tue, 9 May 2023 02:54:49 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-66-wKdNM_ozNwmIZ5WLFzEGbQ-1; Tue, 09 May 2023 05:54:46 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 50C92885622; Tue, 9 May 2023 09:54:44 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 742401402657; Tue, 9 May 2023 09:54:39 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 53D451946A41; Tue, 9 May 2023 09:54:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1018219466DF for ; Tue, 9 May 2023 09:54:39 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E59952166B2A; Tue, 9 May 2023 09:54:38 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8BFDD2166B26 for ; Tue, 9 May 2023 09:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683626088; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=IIiGr0tksNJ8qbvk+lsfjxMFoYjcCwnFAwXLCv67Xks=; b=ZbM7rLNTIO9O3LR8Aa3gTZ3AlDRjpcz+qItXleQF68i4Lu6FOK+0pActuTlAs1q+wATVNo Henzqu9NPnK6qocTQmGLytkZi1P6vKbO0wwPlrliUbIH7vmWSHYzyd9rzhVWF7M9hvvfkr 6kuCAt6jO0BR9xsflhCSqwXEGvHqXYM= X-MC-Unique: wKdNM_ozNwmIZ5WLFzEGbQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] logging: Provide empty VIRTLOGD_ARGS in the unit file Date: Tue, 9 May 2023 12:54:35 +0300 Message-Id: <5a50553c3790d31a47c4fe99134dedff015502f8.1683626075.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683626090954100001 Content-Type: text/plain; charset="utf-8"; x-default="true" For all our daemons, we provide VIRXXXD_ARGS env var in the unit file. The variable can then be overridden in corresponding file: EnvironmentFile=3D-@initconfdir@/virtxxxd The daemon is then executed as: ExecStart=3D@sbindir@/virtxxxd $VIRTXXXD_ARGS But virlogd is exception, for no good reason. And while there are probably no arguments we want to pass to virtlogd by default, just mimic what we do for say virtlockd, where we also don't pass any default argument. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/logging/virtlogd.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service= .in index 158124e4d3..e4aecd46a7 100644 --- a/src/logging/virtlogd.service.in +++ b/src/logging/virtlogd.service.in @@ -7,6 +7,7 @@ Documentation=3Dman:virtlogd(8) Documentation=3Dhttps://libvirt.org =20 [Service] +Environment=3DVIRTLOGD_ARGS=3D EnvironmentFile=3D-@initconfdir@/virtlogd ExecStart=3D@sbindir@/virtlogd $VIRTLOGD_ARGS ExecReload=3D/bin/kill -USR1 $MAINPID --=20 2.39.3