[PATCH] logging: Provide empty VIRTLOGD_ARGS in the unit file

Michal Privoznik posted 1 patch 10 months, 3 weeks ago
Failed in applying to current master (apply log)
src/logging/virtlogd.service.in | 1 +
1 file changed, 1 insertion(+)
[PATCH] logging: Provide empty VIRTLOGD_ARGS in the unit file
Posted by Michal Privoznik 10 months, 3 weeks ago
For all our daemons, we provide VIRXXXD_ARGS env var in the unit
file. The variable can then be overridden in corresponding file:

  EnvironmentFile=-@initconfdir@/virtxxxd

The daemon is then executed as:

  ExecStart=@sbindir@/virtxxxd $VIRTXXXD_ARGS

But virlogd is exception, for no good reason. And while there are
probably no arguments we want to pass to virtlogd by default,
just mimic what we do for say virtlockd, where we also don't pass
any default argument.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/logging/virtlogd.service.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service.in
index 158124e4d3..e4aecd46a7 100644
--- a/src/logging/virtlogd.service.in
+++ b/src/logging/virtlogd.service.in
@@ -7,6 +7,7 @@ Documentation=man:virtlogd(8)
 Documentation=https://libvirt.org
 
 [Service]
+Environment=VIRTLOGD_ARGS=
 EnvironmentFile=-@initconfdir@/virtlogd
 ExecStart=@sbindir@/virtlogd $VIRTLOGD_ARGS
 ExecReload=/bin/kill -USR1 $MAINPID
-- 
2.39.3
Re: [PATCH] logging: Provide empty VIRTLOGD_ARGS in the unit file
Posted by Ján Tomko 10 months, 3 weeks ago
On a Tuesday in 2023, Michal Privoznik wrote:
>For all our daemons, we provide VIRXXXD_ARGS env var in the unit
>file. The variable can then be overridden in corresponding file:
>
>  EnvironmentFile=-@initconfdir@/virtxxxd
>
>The daemon is then executed as:
>
>  ExecStart=@sbindir@/virtxxxd $VIRTXXXD_ARGS
>
>But virlogd is exception, for no good reason. And while there are

s/virlogd/virtlogd/

>probably no arguments we want to pass to virtlogd by default,
>just mimic what we do for say virtlockd, where we also don't pass
>any default argument.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
> src/logging/virtlogd.service.in | 1 +
> 1 file changed, 1 insertion(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano