From nobody Sun Feb 8 22:14:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1741873629802827.144132687618; Thu, 13 Mar 2025 06:47:09 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C953FBA3; Thu, 13 Mar 2025 09:47:08 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 40464215E; Thu, 13 Mar 2025 09:45:03 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 22BF12102; Thu, 13 Mar 2025 09:44:59 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 61C0B1F8E for ; Thu, 13 Mar 2025 09:44:50 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-TfImLzX4PPudnBG2YBnmvQ-1; Thu, 13 Mar 2025 09:44:48 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CC82C1956087 for ; Thu, 13 Mar 2025 13:44:47 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1C76B1955BCB for ; Thu, 13 Mar 2025 13:44:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741873490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OrFd+HOxxVPGKRFUDS7QmPnyCc5MNQ4Ywoq5itICn+E=; b=F5/Zo5CFhIT7F0bKtWslhoT2GiZLQBj490r/SfzipZi8cbUVpxM0+jDWn/BMfc+SbsYsRh 0CbpXdtgXWbPT5M/ia98nNVoURkq2nJUfYasBVT6NapMtvnJOCtaRVuE9g8NHp43eCKugM FnZA0xixM1XfbiFpiahuI9gHsyFPPsA= X-MC-Unique: TfImLzX4PPudnBG2YBnmvQ-1 X-Mimecast-MFC-AGG-ID: TfImLzX4PPudnBG2YBnmvQ_1741873487 From: Michal Privoznik To: devel@lists.libvirt.org Subject: [PATCH 6/6] ch: Rework virCHProcessConnectMonitor() Date: Thu, 13 Mar 2025 14:44:38 +0100 Message-ID: <59e87ecddc0ed75759cd35e70b5dcb493d9b800b.1741873456.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yj_atdTepLdotFuS6KeKOarMZQZS4ze33ce9OyoM1xU_1741873487 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: SKGW7BDISDFQS67XOVLXM47P7QIIPPA7 X-Message-ID-Hash: SKGW7BDISDFQS67XOVLXM47P7QIIPPA7 X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741873631440019100 Content-Type: text/plain; charset="utf-8"; x-default="true" Firstly, let's switch from explicit virCHDriverGetConfig() + virObjectUnref() combo to g_autoptr(virCHDriverConfig). This leaves us with the @monitor variable which is initialized to NULL only to be then set to the retval of virCHMonitorNew() and returned instantly. Well, the variable is now useless and can be dropped. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/ch/ch_process.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c index 79f5990cc1..ee86430e08 100644 --- a/src/ch/ch_process.c +++ b/src/ch/ch_process.c @@ -53,13 +53,9 @@ virCHProcessConnectMonitor(virCHDriver *driver, virDomainObj *vm, int logfile) { - virCHMonitor *monitor =3D NULL; - virCHDriverConfig *cfg =3D virCHDriverGetConfig(driver); + g_autoptr(virCHDriverConfig) cfg =3D virCHDriverGetConfig(driver); =20 - monitor =3D virCHMonitorNew(vm, cfg, logfile); - - virObjectUnref(cfg); - return monitor; + return virCHMonitorNew(vm, cfg, logfile); } =20 static void --=20 2.48.1