From nobody Sun Feb 8 18:44:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1667896207; cv=none; d=zohomail.com; s=zohoarc; b=Tm/Msx/9KxVZvsZLuZk2ntKi4Uhr+VdZkUdCe+L0OP81ZRJB9sx+CHhWpNFK1tv/d5UjKz4MPSVeSxJA42ic/OJoFoccXb+62mQhEfdbplWVyMmSiU5a5OFEevzhVecCF8w/0vLOPnYKYtekQVKJd0eZJwqFlUwwf2A8KpnCqXc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1667896207; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9bvxGgZQZOg+LPaREJD3OBslylDyfBa6jW22AeFKPxw=; b=J34Liu5ivauY2ReZFwb9fMcOnvLfXp5bP5BJ5+n6E/TVlaBTrrJ6XXAj3lw4/Z1l8s5MLqGtJTZx3d934w9whXkx+e8veEO+sZneqJOtm8kzTe8Gi35yCzkoOaEinJcBKb8gD3pf67JfALTAbNjI4X91DdeAmIo3txYmkq/AQy0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 16678962074884.467080607470848; Tue, 8 Nov 2022 00:30:07 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-270-IPTbWZ6TN3W9ynt-v8htQg-1; Tue, 08 Nov 2022 03:29:59 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0B7271C07832; Tue, 8 Nov 2022 08:29:57 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA58140C94CF; Tue, 8 Nov 2022 08:29:56 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7968E1946588; Tue, 8 Nov 2022 08:29:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 603C01946587 for ; Tue, 8 Nov 2022 08:29:53 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 52EA210197; Tue, 8 Nov 2022 08:29:53 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id EBD5A4EA48 for ; Tue, 8 Nov 2022 08:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667896206; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9bvxGgZQZOg+LPaREJD3OBslylDyfBa6jW22AeFKPxw=; b=dHT39OngfqTMe1kJJf6njMqHYAoTWEOvZfSdTALGD9k4SBo5pz/tUPiUwcxOoDRb0XIaHo xb8ZB2vwfqxqyiPxrEEIVJNFoZhCYqgGwfhlRwv/WgRGtsFR06MK71X88bdhtVM6DsQLC/ HdyvXXI4ERig0UHNZX7Z3YZhLZZ8tYA= X-MC-Unique: IPTbWZ6TN3W9ynt-v8htQg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 01/48] qemu: Drop misleading comment for qemuDomainQueryWakeupSuspendSupport() Date: Tue, 8 Nov 2022 09:29:03 +0100 Message-Id: <59d1d147492ea6f6cc8e9c2dd11baa50cd8328f7.1667896101.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1667896208917100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The was an attempt to document the retvals for qemuDomainQueryWakeupSuspendSupport(). However, it's misleading because in reality, the function can return nothing but 0 or -1, but the comment implies retval of 1 too. Since the set of possible return values complies with our unwritten rule (0 for success, -1 for error), there's no real value in having the comment and as such can be dropped. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 59a3b37b98..7c8fc8949c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16313,7 +16313,6 @@ qemuDomainProbeQMPCurrentMachine(virDomainObj *vm, } =20 =20 -/* returns -1 on error, or if query is not supported, 0 if query was succe= ssful */ static int qemuDomainQueryWakeupSuspendSupport(virDomainObj *vm, bool *wakeupSupported) --=20 2.37.4