From nobody Mon Feb 9 11:07:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614698505; cv=none; d=zohomail.com; s=zohoarc; b=MlvDSqsYRqMKlooWcBBtlfD2acxibMvH6O+yv9hkpH+9JMfURiY+dxVvd/pYmhPgIiBPfBTXXS3UQ9os0yERYFoeqjK/Lqo9m0xcSDgpwWFcyUxbdgl81zHG1jKGoCJVDmjwje+2ZVNIAHr0TO3wpwlWai5KsQ5eo4pF/WLXcXw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614698505; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/bSVJjmzymGkBusiOo6odIYwEiSU/c6k7l6tUM0ZCf0=; b=ecGPD5fmG6zQi8Zq+R+Y0+ntVHpOScExpDiF5QCtEBHOCRc1HGKX7rvbWbRSq5mL/HD1+RyrCr3NeSFSW5e2wm8IOMer5tAnUIXnt6xOPvufJmwHWNhL/HabxUaSMLnKSjmu7YfKaE+erP/Hs9gSH13wSmhpb8kVr6tElG5SLJw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1614698505716991.6305607302428; Tue, 2 Mar 2021 07:21:45 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-WK2ocjxHNDq5xjKn6L_Wag-1; Tue, 02 Mar 2021 10:21:40 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7BDC9100A61D; Tue, 2 Mar 2021 15:21:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5199B177D7; Tue, 2 Mar 2021 15:21:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1F23457DFD; Tue, 2 Mar 2021 15:21:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 122FLJWF017567 for ; Tue, 2 Mar 2021 10:21:19 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7EE40E144; Tue, 2 Mar 2021 15:21:19 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id CE05819C46 for ; Tue, 2 Mar 2021 15:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614698504; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/bSVJjmzymGkBusiOo6odIYwEiSU/c6k7l6tUM0ZCf0=; b=F+pnOMyy7+rl62K6bp3t5BGap2ZxNuDLijPxwbXENrLgzeRrw3StpNzraakRVRS6TiGuSn NqKHh8hKi2vaZZFiytH09gDM9c5C2iZ77j3RSFuyGBa4MhPuTVro46cRxhs60ZMqM8Xh+W h+MQF7gszoQmtrovcsD3xmMrdqqsZGI= X-MC-Unique: WK2ocjxHNDq5xjKn6L_Wag-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 5/6] qemuProcessReportLogError: Don't mark "%s: %s" as translatable Date: Tue, 2 Mar 2021 16:21:07 +0100 Message-Id: <59c7fcb698bc3cc57172510966bca122933513b6.1614698410.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The function is constructing an error message from a prefix and the contents of the qemu log file. Marking just two string modifiers as translatable is pointless and will certainly confuse translators. Remove the marking and add a comment which bypasses the sc_libvirt_unmarked_diagnostics check. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 55649286ae..aa547686c1 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2149,7 +2149,8 @@ qemuProcessReportLogError(qemuDomainLogContextPtr log= Ctxt, if (virStringIsEmpty(logmsg)) virReportError(VIR_ERR_INTERNAL_ERROR, "%s", msgprefix); else - virReportError(VIR_ERR_INTERNAL_ERROR, _("%s: %s"), msgprefix, log= msg); + virReportError(VIR_ERR_INTERNAL_ERROR, "%s: %s", /* _( silence sc_= libvirt_unmarked_diagnostics */ + msgprefix, logmsg); return 0; } --=20 2.29.2