From nobody Mon Feb 9 00:30:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618308148; cv=none; d=zohomail.com; s=zohoarc; b=W0K4M5C9dtrcpfzbktwTSUZ2r3rPhPwnDa6GNL5bZSLHCezbJLlXGi2yMUCq5Xl0gmon73R8kA4LbrnFqzbJCEr0Aa+cezr/6k6/VSU6+qZ71hc3W8PMd5X99NpgP4+4KWIpiD2LCnyXat2Qz2VPkQOkqrWaHKEFTcMy9jsC8Eo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618308148; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VpI9U0txO+Vn3oDljz2e6PcWmSwu0QQUV1860ATOZ3Y=; b=Gnc3ZWxU/eJuLKv0zg8ojXcjmS4JYd25INsOO2zqp+kQcrYkr54Pea0BbIdNp/xcrQPFNTnojkvIgXuN7Ju7DQPBn3QpygYycb/e8K+WWV92BJGM9aiLmZkGJimiQw2NGG8m6FcpHL1IcfrBOrqhFuMiy/hNG1E4x813uDkMZ3o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1618308148897201.15131370474398; Tue, 13 Apr 2021 03:02:28 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-392-JHRBrP25N6GwV5_wld7HKA-1; Tue, 13 Apr 2021 06:02:22 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 188C681746C; Tue, 13 Apr 2021 10:02:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D726319C46; Tue, 13 Apr 2021 10:02:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 96BB244A5F; Tue, 13 Apr 2021 10:02:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13DA2518011353 for ; Tue, 13 Apr 2021 06:02:05 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5F5DD10023B0; Tue, 13 Apr 2021 10:02:05 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id D60B41045D23 for ; Tue, 13 Apr 2021 10:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618308145; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=VpI9U0txO+Vn3oDljz2e6PcWmSwu0QQUV1860ATOZ3Y=; b=iL4Hj/0OEDURZwxbTP5D59g6qb1DGMZSn5SaRAdih7x+gUQf4L3C0WoTdfeMXYHPiaxjJh nR6/LNnFCLTF8LJee6SIzlFBsDm09CALqpToproil2viCHItYMAyHBa/n7GxPTDNYok3ma WdNBsvH31rU0f35KLWsPMVwvBysjHMU= X-MC-Unique: JHRBrP25N6GwV5_wld7HKA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/6] nodedev: Rename nodeDeviceWaitInit() Date: Tue, 13 Apr 2021 12:01:52 +0200 Message-Id: <59a7b65b7f037ddfafd545d70727280f9292d133.1618307981.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The consensus is to put the verb last. Therefore, the new name is nodeDeviceInitWait(). This allows us to introduce new function (done later in a separate commit) that will "complete" the device initialization. Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety --- src/node_device/node_device_driver.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_de= vice_driver.c index c11b8d89ab..4678a0fc01 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -158,7 +158,7 @@ nodeDeviceUnlock(void) =20 =20 static int -nodeDeviceWaitInit(void) +nodeDeviceInitWait(void) { nodeDeviceLock(); while (!driver->initialized) { @@ -183,7 +183,7 @@ nodeNumOfDevices(virConnectPtr conn, =20 virCheckFlags(0, -1); =20 - if (nodeDeviceWaitInit() < 0) + if (nodeDeviceInitWait() < 0) return -1; =20 return virNodeDeviceObjListNumOfDevices(driver->devs, conn, cap, @@ -203,7 +203,7 @@ nodeListDevices(virConnectPtr conn, =20 virCheckFlags(0, -1); =20 - if (nodeDeviceWaitInit() < 0) + if (nodeDeviceInitWait() < 0) return -1; =20 return virNodeDeviceObjListGetNames(driver->devs, conn, @@ -222,7 +222,7 @@ nodeConnectListAllNodeDevices(virConnectPtr conn, if (virConnectListAllNodeDevicesEnsureACL(conn) < 0) return -1; =20 - if (nodeDeviceWaitInit() < 0) + if (nodeDeviceInitWait() < 0) return -1; =20 return virNodeDeviceObjListExport(conn, driver->devs, devices, @@ -254,7 +254,7 @@ nodeDeviceLookupByName(virConnectPtr conn, virNodeDeviceDefPtr def; virNodeDevicePtr device =3D NULL; =20 - if (nodeDeviceWaitInit() < 0) + if (nodeDeviceInitWait() < 0) return NULL; =20 if (!(obj =3D nodeDeviceObjFindByName(name))) @@ -285,7 +285,7 @@ nodeDeviceLookupSCSIHostByWWN(virConnectPtr conn, =20 virCheckFlags(0, NULL); =20 - if (nodeDeviceWaitInit() < 0) + if (nodeDeviceInitWait() < 0) return NULL; =20 if (!(obj =3D virNodeDeviceObjListFindSCSIHostByWWNs(driver->devs, @@ -844,7 +844,7 @@ nodeDeviceCreateXML(virConnectPtr conn, =20 virCheckFlags(0, NULL); =20 - if (nodeDeviceWaitInit() < 0) + if (nodeDeviceInitWait() < 0) return NULL; =20 virt_type =3D virConnectGetType(conn); @@ -1144,7 +1144,7 @@ nodeDeviceDestroy(virNodeDevicePtr device) g_autofree char *wwpn =3D NULL; unsigned int parent_host; =20 - if (nodeDeviceWaitInit() < 0) + if (nodeDeviceInitWait() < 0) return -1; =20 if (!(obj =3D nodeDeviceObjFindByName(device->name))) @@ -1288,7 +1288,7 @@ nodeDeviceDefineXML(virConnect *conn, =20 virCheckFlags(0, NULL); =20 - if (nodeDeviceWaitInit() < 0) + if (nodeDeviceInitWait() < 0) return NULL; =20 virt_type =3D virConnectGetType(conn); @@ -1350,7 +1350,7 @@ nodeDeviceUndefine(virNodeDevice *device, =20 virCheckFlags(0, -1); =20 - if (nodeDeviceWaitInit() < 0) + if (nodeDeviceInitWait() < 0) return -1; =20 if (!(obj =3D nodeDeviceObjFindByName(device->name))) @@ -1446,7 +1446,7 @@ nodeConnectNodeDeviceEventRegisterAny(virConnectPtr c= onn, if (virConnectNodeDeviceEventRegisterAnyEnsureACL(conn) < 0) return -1; =20 - if (nodeDeviceWaitInit() < 0) + if (nodeDeviceInitWait() < 0) return -1; =20 if (virNodeDeviceEventStateRegisterID(conn, driver->nodeDeviceEventSta= te, @@ -1465,7 +1465,7 @@ nodeConnectNodeDeviceEventDeregisterAny(virConnectPtr= conn, if (virConnectNodeDeviceEventDeregisterAnyEnsureACL(conn) < 0) return -1; =20 - if (nodeDeviceWaitInit() < 0) + if (nodeDeviceInitWait() < 0) return -1; =20 if (virObjectEventStateDeregisterID(conn, --=20 2.26.3