From nobody Mon Feb 9 17:25:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612600443; cv=none; d=zohomail.com; s=zohoarc; b=b8s0sC9SU3xF/yOj0dQaLaIvzl/UTCu3A+o+CX4Aw9ZWC0sk8oiYEm9XPbqfueF5gxoKohTCw6WXoNHdYbI1v5R3hoChQj7kGRXazJtuq2ElJyC1JAy4N9DW40MNYvj7+JbhMrJBHC6cqlEf2s2a/5e8bMq0IMLJTp9eLqXxkCo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612600443; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=L1D1FpU94e732u15nIjKiq/liOTNiFqnwEP+kfxrDgc=; b=QO9j29Rkm6NtD+toLf7l0Vgn7sUEOaKHEmWgzuAKcj/mtnm22zwaDqeYHlFSIHk4KnrqtBGucGfgUokvwvOFKdC2oYGLhzMhZiN7lRpQbw7KR8y9xO8uJvxB8xLmZZ99sMPbjYdq+GqAzViC+KiTQLQD0xZP0FWyg9pA2+552pU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1612600443550918.3690862417294; Sat, 6 Feb 2021 00:34:03 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-319-5dcd2_dKOdiZehikSa8PYg-1; Sat, 06 Feb 2021 03:33:48 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5A104192AB87; Sat, 6 Feb 2021 08:33:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 369045D9CC; Sat, 6 Feb 2021 08:33:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F14E55807E; Sat, 6 Feb 2021 08:33:41 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1168XUds004793 for ; Sat, 6 Feb 2021 03:33:30 -0500 Received: by smtp.corp.redhat.com (Postfix) id 10DBD60C79; Sat, 6 Feb 2021 08:33:30 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59F8960C77 for ; Sat, 6 Feb 2021 08:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612600442; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=L1D1FpU94e732u15nIjKiq/liOTNiFqnwEP+kfxrDgc=; b=V6qHYOD7wVgC6CoAzixKL1qMOy4EqBarGKHnXAkcGMsuoG+eSKynCCcXUJEbBUbCAK3EoB AGsvfiFtIUpOE6a0Y4kXhKNjvCnXOSSB76UoEomkP4yTLGx3YMfCxwbyvBz8Yp3705nm4R 6w++5cb8vGgN4AE6KY7gP9EXdmUTbwM= X-MC-Unique: 5dcd2_dKOdiZehikSa8PYg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 13/40] virResctrlInfoGetMonitorPrefix: Don't use 'virStringListAdd' to construct list Date: Sat, 6 Feb 2021 09:32:35 +0100 Message-Id: <58b9318c75427c1aa9cf3d663d91404b5901bd60.1612599659.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Pre-allocate a buffer for the upper limit and shrink it afterwards to avoid use of 'virStringListAdd' in a loop. Signed-off-by: Peter Krempa --- src/util/virresctrl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index 29df51c652..86b4b9d73b 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -1009,15 +1009,15 @@ virResctrlInfoGetMonitorPrefix(virResctrlInfoPtr re= sctrl, mon->cache_level =3D mongrp_info->cache_level; } + mon->features =3D g_new0(char *, mongrp_info->nfeatures + 1); + for (i =3D 0; i < mongrp_info->nfeatures; i++) { - if (STRPREFIX(mongrp_info->features[i], prefix)) { - if (virStringListAdd(&mon->features, - mongrp_info->features[i]) < 0) - goto cleanup; - mon->nfeatures++; - } + if (STRPREFIX(mongrp_info->features[i], prefix)) + mon->features[mon->nfeatures++] =3D g_strdup(mongrp_info->feat= ures[i]); } + mon->features =3D g_renew(char *, mon->features, mon->nfeatures + 1); + ret =3D 0; /* In case *monitor is pointed to some monitor, clean it. */ --=20 2.29.2