From nobody Mon Feb 9 00:30:42 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710158504211856.7257316368872; Mon, 11 Mar 2024 05:01:44 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2A6971F57; Mon, 11 Mar 2024 08:01:43 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 1EC8F1F05; Mon, 11 Mar 2024 07:34:46 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2F18F1D01; Mon, 11 Mar 2024 07:31:20 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id DE6441C16 for ; Mon, 11 Mar 2024 07:31:17 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-iLMfuILoMPq1NWBw0CD7aQ-1; Mon, 11 Mar 2024 07:31:16 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2B9B68007A6 for ; Mon, 11 Mar 2024 11:31:16 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 985671121337 for ; Mon, 11 Mar 2024 11:31:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: iLMfuILoMPq1NWBw0CD7aQ-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 14/23] virsh: Inline only use of VIRSH_COMMON_OPT_DOMAIN_OT_ARGV macro Date: Mon, 11 Mar 2024 12:30:51 +0100 Message-ID: <58932001c46d4cd4d7c83febe002a7311901e6b5.1710156504.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: OIC6B4QBFANCOLWPX3QWJPYA6W7DVDAS X-Message-ID-Hash: OIC6B4QBFANCOLWPX3QWJPYA6W7DVDAS X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710158504498100001 There's just one command taking a list of domains as argument, thus declare it inline. Signed-off-by: Peter Krempa --- tools/virsh-domain-monitor.c | 6 +++++- tools/virsh.h | 12 ------------ 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 277eb71342..7a25318bbd 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -2048,7 +2048,11 @@ static const vshCmdOptDef opts_domstats[] =3D { .type =3D VSH_OT_BOOL, .help =3D N_("report only stats that are accessible instantly"), }, - VIRSH_COMMON_OPT_DOMAIN_OT_ARGV(N_("list of domains to get stats for")= , 0), + {.name =3D "domain", + .type =3D VSH_OT_ARGV, + .help =3D N_("list of domains to get stats for"), + .completer =3D virshDomainNameCompleter, + }, {.name =3D NULL} }; diff --git a/tools/virsh.h b/tools/virsh.h index 6acefa7f9d..877b290e3a 100644 --- a/tools/virsh.h +++ b/tools/virsh.h @@ -119,18 +119,6 @@ VIRSH_COMMON_OPT_DOMAIN_OT_STRING(N_("domain name, id or uuid"), \ oflags, cflags) -#define VIRSH_COMMON_OPT_DOMAIN_OT_ARGV(_helpstr, cflags) \ - {.name =3D "domain", \ - .type =3D VSH_OT_ARGV, \ - .flags =3D VSH_OFLAG_NONE, \ - .help =3D _helpstr, \ - .completer =3D virshDomainNameCompleter, \ - .completer_flags =3D cflags, \ - } - -#define VIRSH_COMMON_OPT_DOMAIN_OT_ARGV_FULL(cflags) \ - VIRSH_COMMON_OPT_DOMAIN_OT_ARGV(N_("domain name, id or uuid"), cflags) - typedef struct _virshControl virshControl; typedef struct _virshCtrlData virshCtrlData; --=20 2.44.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org