From nobody Fri Mar 14 06:43:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1678722199; cv=none; d=zohomail.com; s=zohoarc; b=nnJv6G6CmudYMggN3eDWw5lY3KO8lrXCOkhVUVi6u4xV0JV/wuYPTWY+HyKNVIvIF7TRuNBF4lQWqt+A/QLXuBYKOF6WgUJQyJ3JPmdhOLMYH8rKY5Zb5l1ZobAuA4HL/E9lfxiyuAZbl5xtuR0VENjlWJxA5S+pMs0tMDXxwRM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678722199; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=23O3p8Y28wdlFKqlTK9WdVpJ9WVtc96sidAHuDt/yfM=; b=AijKeEaO25BgdTt267QysY4J4Vf0dOwtVjCY+/gtB4EQTNx8DceB2eVzYEJe+cy6735PhJNbO2JNBZsbEJJr52xgeWYQrbNFTsl/QYlTH7CnTezKCzMJ5XLJzk+e6Hbt8jOCmQOS02Gqjq0M8d8U+Ya2LweTJTZCJl2r9f3jcSU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1678722199652343.5238112769489; Mon, 13 Mar 2023 08:43:19 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-6-hjoiz8qpMAaLiSsJ2en4lA-1; Mon, 13 Mar 2023 11:43:02 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 962C7803503; Mon, 13 Mar 2023 15:42:42 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 837D740C6E67; Mon, 13 Mar 2023 15:42:42 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 668271946594; Mon, 13 Mar 2023 15:42:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 90C5519465A2 for ; Mon, 13 Mar 2023 15:42:40 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6E73C2166B31; Mon, 13 Mar 2023 15:42:40 +0000 (UTC) Received: from localhost.localdomain (unknown [10.45.226.242]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF7CE2166B26 for ; Mon, 13 Mar 2023 15:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678722198; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=23O3p8Y28wdlFKqlTK9WdVpJ9WVtc96sidAHuDt/yfM=; b=EggbVNZn9Wz+v6Xpl+ec32Fsw4uleSXwurwXGgXBn7kyiveLLKiV5W8+wYz6Q2HmC0PiRd hoUeN8cCOEl6EUiimXedcHmsPAFt6cOSk65SsrQTnvd7nziqTfAIS5O4R1RvPIJtsc4QMh fn+IRGZrTsGHy1UgzdURhD7kme8iWoM= X-MC-Unique: hjoiz8qpMAaLiSsJ2en4lA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 20/20] qemu_snapshot: allow snapshot revert for external snapshots Date: Mon, 13 Mar 2023 16:42:21 +0100 Message-Id: <5812dad2df46a85a7712bfa1b43e861f0d6493f9.1678718987.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1678722201065100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Now that the support to revert external snapshots is implemented we can drop this check. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_snapshot.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index c6c7b077dd..ec5b2e68d6 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -1864,12 +1864,6 @@ qemuSnapshotRevertValidate(virDomainObj *vm, return -1; } =20 - if (virDomainSnapshotIsExternal(snap)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("revert to external snapshot not supported yet")); - return -1; - } - if (!snap->def->dom) { virReportError(VIR_ERR_SNAPSHOT_REVERT_RISKY, _("snapshot '%s' lacks domain '%s' rollback info"), --=20 2.39.2