From nobody Tue Nov 26 19:55:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565173079; cv=none; d=zoho.com; s=zohoarc; b=QC5zdn7AlEbwoJvWfyobI+FMeJhuWxl5WE1kiB57EVJ70shnvfmHukDYgnixmKrl53nPeXeqouFXFY1DpNlmIyOR4kGIgqOGWm3kg/xhtlQKvtqEactqLZQb+XNo2HL0JQuDoG8OwKTrPPus6LaAl4KWcnBZsOa/FwjTelv5fl8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565173079; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=CcWHZrFuQbGvYryJns3ANsW0cF63a3LuWQO/RdkxZuA=; b=ZBGJtNlUXKiGHLnrmPp6FkVfX8VtWnn0nfAcpRjv1GcGbNs6Xxqd/IcBPpZHZXCCVbNlL1lY7fK+jfqWIu8E+dStRDhEMHMcVH8E2PXUfrQ8JrgucRfZyHh92Hwg8k2EW/Rrg0Gc4voEUj8P1CMVozOTKKjzKcj4dvtgdAPNHJw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1565173079877394.8562132064369; Wed, 7 Aug 2019 03:17:59 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E72164F1BC; Wed, 7 Aug 2019 10:17:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0779460C44; Wed, 7 Aug 2019 10:17:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 631CC180B536; Wed, 7 Aug 2019 10:17:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x77ACLLS009007 for ; Wed, 7 Aug 2019 06:12:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0BA731FD3A; Wed, 7 Aug 2019 10:12:21 +0000 (UTC) Received: from ridgehead.redhat.com (ovpn-200-27.brq.redhat.com [10.40.200.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 41D7926181; Wed, 7 Aug 2019 10:12:17 +0000 (UTC) From: Erik Skultety To: libvir-list@redhat.com Date: Wed, 7 Aug 2019 12:12:15 +0200 Message-Id: <5801ef06ec29fdbac6718e455015450f7c243c1b.1565172657.git.eskultet@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Erik Skultety Subject: [libvirt] [PATCH] src: security: Replace bitwise OR with logical OR X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 07 Aug 2019 10:17:59 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Typo introduced by commit d73f3f58360. https://bugzilla.redhat.com/show_bug.cgi?id=3D1738483 Signed-off-by: Erik Skultety --- Pushed as trivial. src/security/security_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/security_util.c b/src/security/security_util.c index ad265b0bc5..9d3f483f6b 100644 --- a/src/security/security_util.c +++ b/src/security/security_util.c @@ -268,7 +268,7 @@ virSecurityMoveRememberedLabel(const char *name, VIR_AUTOFREE(char *) attr_name =3D NULL; VIR_AUTOFREE(char *) attr_value =3D NULL; - if (!(ref_name =3D virSecurityGetRefCountAttrName(name)) | + if (!(ref_name =3D virSecurityGetRefCountAttrName(name)) || !(attr_name =3D virSecurityGetAttrName(name))) return -1; -- 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list