From nobody Tue Nov 26 12:28:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=hygon.cn ARC-Seal: i=1; a=rsa-sha256; t=1576119563; cv=none; d=zohomail.com; s=zohoarc; b=L+gAxDJqRCW74crLM+IReFpYgEwQfWZcTtY/K+tNpqbtsXQLETTxq1AGfrvUEQERcDVc2kiQlZKpR/1F8OwVa6ISkirDpau/ZnoQ3U5yCtHFh3AmkQqmqEkSJW/q404yfeuSmTNykHUPGR6biwwBeEX6Zr4FfULSBgPYy1DZESM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576119563; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QNmfFLgCLxh5pdqu/ujhVKUvjNVQXYulddnleBKPS/Q=; b=LTwcvrs+hguFxYG/jPs5GjxQZYQkbzzbkF8GWXhfx5dx1jG8xe5ftKMImh7aDLDc1oqX+7ACgQdDk4QWfCoHoxaYGM1sJQH3xTAyaL5rQJdF6v0ySGkRoCx8DhButg6BayN9YxQVjB4+qKKgZNA2h8UEz0vgwSnRbGFIQ4v/cdo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1576119563227406.4930672793464; Wed, 11 Dec 2019 18:59:23 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-j8_4QFcMMXORBY4TFgoZwg-1; Wed, 11 Dec 2019 21:59:19 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EE7B0DB2A; Thu, 12 Dec 2019 02:59:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B9CA5C1C3; Thu, 12 Dec 2019 02:59:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C056B5B41F; Thu, 12 Dec 2019 02:59:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBC2x7AD018853 for ; Wed, 11 Dec 2019 21:59:08 -0500 Received: by smtp.corp.redhat.com (Postfix) id 17727108DD23; Thu, 12 Dec 2019 02:59:07 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12907108DD22 for ; Thu, 12 Dec 2019 02:59:04 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 99FA21017A10 for ; Thu, 12 Dec 2019 02:59:04 +0000 (UTC) Received: from zrleap.intel-email.com (cdnsh.intel-mail.com [222.73.227.186]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-356-CQcTaDjVOw-64kG2K1lCqg-1; Wed, 11 Dec 2019 21:59:02 -0500 Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 82F09A32E191 for ; Thu, 12 Dec 2019 10:58:50 +0800 (CST) Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 3AA63A32E0A0 for ; Thu, 12 Dec 2019 10:58:49 +0800 (CST) Received: from spam2.hygon.cn (unknown [110.188.70.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by zrleap.intel-email.com (Postfix) with ESMTPS id 1463CA32E16D for ; Thu, 12 Dec 2019 10:58:45 +0800 (CST) Received: from MK-FE.hygon.cn ([172.23.18.61]) by spam2.hygon.cn with ESMTP id xBC2wfcX012297 for ; Thu, 12 Dec 2019 10:58:41 +0800 (GMT-8) (envelope-from houyingle@hygon.cn) Received: from cncheex01.Hygon.cn ([172.23.18.10]) by MK-FE.hygon.cn with ESMTP id xBC2waSD090883 for ; Thu, 12 Dec 2019 10:58:37 +0800 (GMT-8) (envelope-from houyingle@hygon.cn) Received: from leo-virtual-machine.localdomain (172.23.18.44) by cncheex01.Hygon.cn (172.23.18.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1466.3; Thu, 12 Dec 2019 10:58:40 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576119562; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=QNmfFLgCLxh5pdqu/ujhVKUvjNVQXYulddnleBKPS/Q=; b=QS9HamGGgLInrb4irIJM/wHpEyx60tlL2AlBdRN1VNkYk7dVi3yHImIEMjGGzXtOYwW3kS P5L/zvnt0zJmFKTZ6nbhb8khV76F/OuQgQ1h7y/Pq0OKBudQ98UCrOY/O+qKTd6Sh/fGEf LGAWGvGtK8wM3RM1xswnQ+l2PO2r1mE= X-Virus-Scanned: by SpamTitan at intel-email.com From: Yingle Hou To: Date: Thu, 12 Dec 2019 10:58:18 +0800 Message-ID: <57f9d290e383eb048d311821e0e3db0c8ba215e2.1576075683.git.houyingle@hygon.cn> In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [172.23.18.44] X-ClientProxiedBy: cncheex01.Hygon.cn (172.23.18.10) To cncheex01.Hygon.cn (172.23.18.10) X-MAIL: spam2.hygon.cn xBC2wfcX012297 X-DNSRBL: X-MC-Unique: CQcTaDjVOw-64kG2K1lCqg-1 X-MC-Unique: j8_4QFcMMXORBY4TFgoZwg-1 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id xBC2x7AD018853 X-loop: libvir-list@redhat.com Cc: Yingle Hou Subject: [libvirt] [PATCH RESEND 1/4] cpu: Remove the verification conditions of the model in the x86 signatures X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The x86ModelParseSignatures function makes an assumption that CPU signature model equals 0 as an invalid case. While in Hygon processor definition, A1 version (model 0, stepping 1) is mass production version, to support Hygon Dhyana A1 version, we have removed CPU signature model zero checking condit= ion. Signed-off-by: Yingle Hou Reviewed-by: Daniel P. Berrang=C3=A9 --- src/cpu/cpu_x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 1e913cc..9b7981d 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -1418,7 +1418,7 @@ x86ModelParseSignatures(virCPUx86ModelPtr model, } =20 rc =3D virXPathUInt("string(@model)", ctxt, &sigModel); - if (rc < 0 || sigModel =3D=3D 0) { + if (rc < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Invalid CPU signature model in model %s"), model->name); --=20 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list