From nobody Mon Feb 9 00:30:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1628075030; cv=none; d=zohomail.com; s=zohoarc; b=j0cWRcTAAERFF1jmyOtYMypiFGomX7VbcjTDyjViK0Il9stgZV+GrVIWpF1Z9fUDRR+WMJ0Gt3UI6s9txeJUAVmZmAOJpe84EL1YM+ngLrLoyyXF8DALnnfOQb/wopElZ53KcKKzFfaIzAP9XzNBtOCU7mTW8Km+6TpW+vvgX74= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628075030; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sIeHgVYq6skcL5oQIamAieFkfYw3v5p1jP0YITsLAvc=; b=fQgC8NVPIDk/GVXvfiQA3F3Fa6x4+BP2NafUJ/QyPnT6Dai99Y9xf2h4Z40XtMlI+7zuJ5g5Ap4fimrQFraDn1T58rna/sGWuVDSajXy+tEbxFEIHcS2CrSq+nLMIT559yKaQGIgcBGzTysEZKbCKB99b2ZtueDuPe8ST51WM/I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1628075030078906.1052489722; Wed, 4 Aug 2021 04:03:50 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-508-33v8tHoUMMOq04cb9kfPHg-1; Wed, 04 Aug 2021 07:03:47 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2B95D801AC0; Wed, 4 Aug 2021 11:03:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 045741036D33; Wed, 4 Aug 2021 11:03:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C29B04A70F; Wed, 4 Aug 2021 11:03:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 174B30q4014264 for ; Wed, 4 Aug 2021 07:03:00 -0400 Received: by smtp.corp.redhat.com (Postfix) id 621861383C; Wed, 4 Aug 2021 11:03:00 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id C14595D9DC for ; Wed, 4 Aug 2021 11:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628075029; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=sIeHgVYq6skcL5oQIamAieFkfYw3v5p1jP0YITsLAvc=; b=bltYg7KtUZe73MN61mVUOsJO+KS1yX0HqNG3Z8WZR8tCc+lPJldhJddO00i74+CJ3ei+Kg neDs/zex5mHFd9NxbAX3p2kIgJRcbBBrPHFXe7Bl1ekzbFDp2THRgeQSDb4GbhbEl7ekah yRuD/moHW2XKDuuKubo1idlL+L5y6wM= X-MC-Unique: 33v8tHoUMMOq04cb9kfPHg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 10/23] xenParseXMDisk: Use automatic memory clearing and remove 'ret' variable Date: Wed, 4 Aug 2021 13:02:30 +0200 Message-Id: <57d07baa1d50c233c2b22e1a1f90b0c538190cd8.1628074874.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1628075031155100002 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa --- src/libxl/xen_xm.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/libxl/xen_xm.c b/src/libxl/xen_xm.c index ac86ddf9b7..f978b94f93 100644 --- a/src/libxl/xen_xm.c +++ b/src/libxl/xen_xm.c @@ -238,9 +238,9 @@ xenParseXMDisk(char *entry, int hvm) static int xenParseXMDiskList(virConf *conf, virDomainDef *def) { - char **disks =3D NULL, **entries; + g_auto(GStrv) disks =3D NULL; + GStrv entries; int hvm =3D def->os.type =3D=3D VIR_DOMAIN_OSTYPE_HVM; - int ret =3D -1; int rc; rc =3D virConfGetValueStringList(conf, "disk", false, &disks); @@ -258,10 +258,7 @@ xenParseXMDiskList(virConf *conf, virDomainDef *def) VIR_APPEND_ELEMENT(def->disks, def->ndisks, disk); } - ret =3D 0; - - g_strfreev(disks); - return ret; + return 0; } --=20 2.31.1