From nobody Fri Dec 19 04:01:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1741880166358590.3306189553296; Thu, 13 Mar 2025 08:36:06 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9BAC4212F; Thu, 13 Mar 2025 11:36:05 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 8479E21D9; Thu, 13 Mar 2025 11:32:55 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 454D22139; Thu, 13 Mar 2025 11:32:46 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C3A052139 for ; Thu, 13 Mar 2025 11:32:27 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10-8xSgyTRtNgS82h3-d-IAYA-1; Thu, 13 Mar 2025 11:32:26 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8B0161828B64 for ; Thu, 13 Mar 2025 15:32:21 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EDE791800945 for ; Thu, 13 Mar 2025 15:32:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741879947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5lb70TpBNIvwhtdnZjb9Rb2RdOnb8hH2S0Vu+3wVY4o=; b=So0g/9uzcTEJgZFvRzsLSffy89GhGkqPKsPZqmEyd41cJPwYgBoGWHygGohOIkI91a8kUG CWUUbb5p+Iy+icGWvpge9gxU42iRKOxpU1/P6mxtFlRFm7efRLinu2FL8DsQRsSlphBC20 KdwDKqn8LdQY6CakpTZaVsw1Vsy/atQ= X-MC-Unique: 8xSgyTRtNgS82h3-d-IAYA-1 X-Mimecast-MFC-AGG-ID: 8xSgyTRtNgS82h3-d-IAYA_1741879945 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 10/10] Remove unreachable breaks right after return Date: Thu, 13 Mar 2025 16:30:24 +0100 Message-ID: <57c32b37a629ca11018b4eaceb97bb3d352f1398.1741879824.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LLn7_lDsObH16f8v5Qo8HMfhHypDBVWBqHMcxmm7N6o_1741879945 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VCKXQMOVSTUDR76F23LAVSE3MTEL4NSX X-Message-ID-Hash: VCKXQMOVSTUDR76F23LAVSE3MTEL4NSX X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741880168623019000 Content-Type: text/plain; charset="utf-8" Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_cgroup.c | 2 -- src/qemu/qemu_command.c | 6 +++--- src/qemu/qemu_driver.c | 1 - src/qemu/qemu_hotplug.c | 1 - src/qemu/qemu_monitor_json.c | 1 - src/security/security_apparmor.c | 1 - src/vmx/vmx.c | 2 -- tools/virsh-domain.c | 1 - tools/virsh-host.c | 2 -- tools/vsh.c | 7 ------- 10 files changed, 3 insertions(+), 21 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index f3c85d65e8..48af467bf9 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -436,7 +436,6 @@ qemuSetupInputCgroup(virDomainObj *vm, case VIR_DOMAIN_INPUT_TYPE_EVDEV: return qemuCgroupAllowDevicePath(vm, dev->source.evdev, VIR_CGROUP_DEVICE_RW, false); - break; } =20 return ret; @@ -457,7 +456,6 @@ qemuTeardownInputCgroup(virDomainObj *vm, case VIR_DOMAIN_INPUT_TYPE_EVDEV: return qemuCgroupDenyDevicePath(vm, dev->source.evdev, VIR_CGROUP_DEVICE_RWM, false); - break; } =20 return 0; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 92560d381f..ca5a228572 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -9706,13 +9706,13 @@ qemuBuildSecCommandLine(virDomainObj *vm, virComman= d *cmd, switch (sec->sectype) { case VIR_DOMAIN_LAUNCH_SECURITY_SEV: return qemuBuildSEVCommandLine(vm, cmd, &sec->data.sev); - break; + case VIR_DOMAIN_LAUNCH_SECURITY_SEV_SNP: return qemuBuildSEVSNPCommandLine(cmd, &sec->data.sev_snp); - break; + case VIR_DOMAIN_LAUNCH_SECURITY_PV: return qemuBuildPVCommandLine(cmd); - break; + case VIR_DOMAIN_LAUNCH_SECURITY_NONE: case VIR_DOMAIN_LAUNCH_SECURITY_LAST: virReportEnumRangeError(virDomainLaunchSecurity, sec->sectype); diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index af5445f78d..f0e9681161 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -11990,7 +11990,6 @@ qemuDomainGetJobInfoDumpStats(virDomainObj *vm, _("dump query failed, status=3D%1$d"), privJob->stats.dump.status); return -1; - break; =20 case QEMU_MONITOR_DUMP_STATUS_ACTIVE: jobData->status =3D VIR_DOMAIN_JOB_STATUS_ACTIVE; diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 28ca321c5c..b6ef10edf9 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -7268,7 +7268,6 @@ qemuDomainChangeMemoryLiveValidateChange(const virDom= ainMemoryDef *oldDef, _("cannot modify memory of model '%1$s'"), virDomainMemoryModelTypeToString(oldDef->model)); return false; - break; } =20 if (oldDef->model !=3D newDef->model) { diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 3caeb39a1b..9c60807926 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -5601,7 +5601,6 @@ int qemuMonitorJSONGetObjectProperty(qemuMonitor *mon, _("qom-get invalid object property type %1$d"), prop->type); return -1; - break; } =20 if (ret =3D=3D -1) { diff --git a/src/security/security_apparmor.c b/src/security/security_appar= mor.c index 91c51f6395..68ac39611f 100644 --- a/src/security/security_apparmor.c +++ b/src/security/security_apparmor.c @@ -681,7 +681,6 @@ AppArmorSetInputLabel(virSecurityManager *mgr, return -1; } return reload_profile(mgr, def, input->source.evdev, true); - break; =20 case VIR_DOMAIN_INPUT_TYPE_MOUSE: case VIR_DOMAIN_INPUT_TYPE_TABLET: diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 8d10b6e9e8..0dd03c1a88 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -2250,13 +2250,11 @@ virVMXGenerateDiskTarget(virDomainDiskDef *def, virDomainDiskBusTypeToString(def->bus), virDomainDiskDeviceTypeToString(def->device)); return -1; - break; =20 case VIR_DOMAIN_DISK_BUS_NONE: case VIR_DOMAIN_DISK_BUS_LAST: virReportEnumRangeError(virDomainDiskBus, def->bus); return -1; - break; } =20 def->dst =3D virIndexToDiskName(idx, prefix); diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 93c34c4971..7624cb90fe 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -1070,7 +1070,6 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) vshError(ctl, _("No support for %1$s in command 'attach-interface'= "), type); return false; - break; } =20 if (target !=3D NULL) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 9e8f542c96..8a92e15b21 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -1217,7 +1217,6 @@ cmdCPUCompare(vshControl *ctl, const vshCmd *cmd) vshPrint(ctl, _("CPU described in %1$s is incompatible with host C= PU\n"), from); return false; - break; =20 case VIR_CPU_COMPARE_IDENTICAL: vshPrint(ctl, _("CPU described in %1$s is identical to host CPU\n"= ), @@ -1632,7 +1631,6 @@ cmdHypervisorCPUCompare(vshControl *ctl, _("CPU described in %1$s is incompatible with the CPU pro= vided by hypervisor on the host\n"), from); return false; - break; =20 case VIR_CPU_COMPARE_IDENTICAL: vshPrint(ctl, diff --git a/tools/vsh.c b/tools/vsh.c index fd6156ea76..b42e2f0c50 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -1922,31 +1922,24 @@ vshGetTypedParamValue(vshControl *ctl, virTypedPara= meterPtr item) switch (item->type) { case VIR_TYPED_PARAM_INT: return g_strdup_printf("%d", item->value.i); - break; =20 case VIR_TYPED_PARAM_UINT: return g_strdup_printf("%u", item->value.ui); - break; =20 case VIR_TYPED_PARAM_LLONG: return g_strdup_printf("%lld", item->value.l); - break; =20 case VIR_TYPED_PARAM_ULLONG: return g_strdup_printf("%llu", item->value.ul); - break; =20 case VIR_TYPED_PARAM_DOUBLE: return g_strdup_printf("%f", item->value.d); - break; =20 case VIR_TYPED_PARAM_BOOLEAN: return g_strdup(item->value.b ? _("yes") : _("no")); - break; =20 case VIR_TYPED_PARAM_STRING: return g_strdup(item->value.s); - break; =20 default: vshError(ctl, _("unimplemented parameter type %1$d"), item->type); --=20 2.48.1