From nobody Sun Feb 8 23:58:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620315095; cv=none; d=zohomail.com; s=zohoarc; b=YxzrcrvVlP+eW9IY+FNV8UZx0TjidzHL7v8MP+P3u+iOUrQwrq2+3IqJXppu7ZJfA+REtPtdNkJrFUGv3vzKLeYLWR6sZrFpn2iFM4on5bj0+zHD2FTMt/lBkYnCs9byBJpyyBoGxO1OdK2wpopTz0gxtBDyl2pT96uKZ/GfM7A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620315095; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XUoiWPK8K50XkpaZdLh+T1YeE9n8E8+xsjkR/7U2WRQ=; b=eEZKJbeM6qFc8T0GNZ/O9p44Mh1XRGYhdDf6hluS11eHPxTh2HwnK8p08sm7MqgBxZjcRp+7yp7QnnRTWVnnEG3DqzlEeoWLZXsH+EBY4/g4PvuS/cBQLHpNQYBsMtMb0WVPEh9HZak4YkzGVBWFJD4+YDRrcipPvK/fH6ad9P8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620315095589376.11960817460044; Thu, 6 May 2021 08:31:35 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-462-FFEYtTuSOzuBdsGrKNAZXA-1; Thu, 06 May 2021 11:31:31 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7BDDC18397BD; Thu, 6 May 2021 15:31:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A9DC5D6AC; Thu, 6 May 2021 15:31:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 178D255357; Thu, 6 May 2021 15:31:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 146FVIkM011388 for ; Thu, 6 May 2021 11:31:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id 71A291045E8C; Thu, 6 May 2021 15:31:18 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id C5ECA1045E87 for ; Thu, 6 May 2021 15:31:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620315093; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=XUoiWPK8K50XkpaZdLh+T1YeE9n8E8+xsjkR/7U2WRQ=; b=S/4Yza3znC00E5pKDxnuaPu5K/q487YGTtyrwQZC0r1QwxIx3ob9cWiE8SZqybR4RRaE4z kPvbEuRzafIanragKcxOUv8oIIRygB7tWn1KXeBSyiWliD1u/8NuWbPQT9pWReUeLx+DGe 311MMFrBn/U1gHGygt+kx8UedVEUKr8= X-MC-Unique: FFEYtTuSOzuBdsGrKNAZXA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 07/17] virDomainIOThreadIDDefParseXML: Refactor cleanup Date: Thu, 6 May 2021 17:30:59 +0200 Message-Id: <579d93aa2a6f4482883e15eb00e86c1c2d7e9410.1620314826.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Automatically free 'iothrid' and remove all the cleanup cruft. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index baf5d31606..78775bb2b3 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17010,21 +17010,14 @@ virDomainIdmapDefParseXML(xmlXPathContextPtr ctxt, static virDomainIOThreadIDDef * virDomainIOThreadIDDefParseXML(xmlNodePtr node) { - virDomainIOThreadIDDef *iothrid; - - iothrid =3D g_new0(virDomainIOThreadIDDef, 1); + g_autoptr(virDomainIOThreadIDDef) iothrid =3D g_new0(virDomainIOThread= IDDef, 1); if (virXMLPropUInt(node, "id", 10, VIR_XML_PROP_REQUIRED | VIR_XML_PROP_NONZERO, &iothrid->iothread_id) < 0) - goto error; - - return iothrid; + return NULL; - error: - virDomainIOThreadIDDefFree(iothrid); - iothrid =3D NULL; - return iothrid; + return g_steal_pointer(&iothrid); } --=20 2.30.2