From nobody Mon Feb 9 06:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1669801705; cv=none; d=zohomail.com; s=zohoarc; b=dFJcjmmV26sm5o4kIVjAPytjhGeyWS7Gw+yJisaNQSRrrSFFe54T+jhZOp3dd4Vk2trq+N+WaUihFBzUz7ISXIuGrS8H2dCfO5lXTF574Wdl/vyFPpuYGpUiaFlc+sU7atx//dczY5h7+pUH49t5qmq7pz4R+c989kSF5FxWyAw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669801705; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tSB9Tw74tV4TZ9kuztq5SDUalPaYXQb3Tk9csnJedu4=; b=nc83yUTHyahGPp3cgqo1eeNbTtJQm7Gcxw/sr6Y8U8MNLqLx0514dWtUPQtFHcnK7be3FjwpRfdb0PFHpyokDlvXnrXZztcl2navmlJFJudlDsUDpXAOR8CHRKf60tQ+czpM8JMYsVFKAooSAER0F8racDARSuR2TbR0oq8QAvE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1669801705587844.4975939480919; Wed, 30 Nov 2022 01:48:25 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-604-hGzPRJf5MJSrcehXPksYWg-1; Wed, 30 Nov 2022 04:48:22 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1C7F31C08980; Wed, 30 Nov 2022 09:48:19 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 07662492B15; Wed, 30 Nov 2022 09:48:19 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id F088319465A8; Wed, 30 Nov 2022 09:48:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7445519465A0 for ; Wed, 30 Nov 2022 09:48:14 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 588EA4B3FCE; Wed, 30 Nov 2022 09:48:14 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id F1ACA4B3FC8 for ; Wed, 30 Nov 2022 09:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669801704; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=tSB9Tw74tV4TZ9kuztq5SDUalPaYXQb3Tk9csnJedu4=; b=feMEDYZArXGMv75ewb/1cU19bDM/2C0ELq4jO9rDbJCTI8UIfgC+IoBbKsYVHjK7sfV0Dc v4E0j8Z6gr9Tnsl5Jt2vgZu0zxYGXwoGIvlb8uHfjX62bgFQLu2z5L1/0ugLTkr9LURZ3Z Y9sHzs0R0mVBHRDBgrOnjH822KdcmkE= X-MC-Unique: hGzPRJf5MJSrcehXPksYWg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/9] virCommandDoAsyncIO: Drop misleading statement about main event loop Date: Wed, 30 Nov 2022 10:48:04 +0100 Message-Id: <5764adf6a751f8c1fad8c9b2a9592a53e2039939.1669801586.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1669801706757100003 Content-Type: text/plain; charset="utf-8"; x-default="true" Back in v1.0.3-rc1~235 when I was adding virCommandDoAsyncIO(), the main event loop was used to poll() on the pipe to the child process. But this was promptly changed to a separate thread handling I/O in v1.0.3-rc1~127. However, the corresponding comment to virCommandDoAsyncIO() still documents the original state. Signed-off-by: Michal Privoznik --- src/util/vircommand.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index cdc74bc2fd..4f60432c0a 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -3078,8 +3078,6 @@ virCommandFree(virCommand *cmd) * * ... * - * - * The libvirt's event loop is used for handling stdios of @cmd. * Since current implementation uses strlen to determine length * of data to be written to @cmd's stdin, don't pass any binary * data. If you want to re-run command, you need to call this and --=20 2.37.4