From nobody Mon Feb 9 06:02:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559748665; cv=none; d=zoho.com; s=zohoarc; b=G7LxUkfAy9lLBCaXSz+08Kcxj+hrnMC3Kx9bwdXkSJh3SnuVWO5+mf4wDfWVURmMTHMwgQGhYH3dgXDVuLL+m2m5NZEzAUb8g998p0UVKSR+/w6JCBVlofKXE8QgV8QiRnfuA+MSgh3AE0n+X9BYe/Inf8Gpwz4F8JIAp/sk5ro= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559748665; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=fxWkFOb0eQnaWD9dm/Y1sWJ9jkMpn/Gf1wAswBRfCsI=; b=nM4zZwi+lsQpz/abB+fGk7NAIHiLEg/Jf2WHOP+TMACpRT1OehiR/NEBeLDXEZlyBYphn0CqcD+y8jdJVkNv9fjvz9zcJ/Ogd28xNHDjTv7CRIZrQgIqPOPNz7tTzsTik+5zfBYfiK37xcu2mtye/4vbI7kIO5vycGbjPmaZGls= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1559748665177538.1899370440484; Wed, 5 Jun 2019 08:31:05 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3C20BC18B2F5; Wed, 5 Jun 2019 15:30:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 18EAA18344; Wed, 5 Jun 2019 15:30:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D45491806B1A; Wed, 5 Jun 2019 15:30:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x55FShgh012901 for ; Wed, 5 Jun 2019 11:28:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2A91817F22; Wed, 5 Jun 2019 15:28:43 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id A849160920 for ; Wed, 5 Jun 2019 15:28:42 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Wed, 5 Jun 2019 17:28:26 +0200 Message-Id: <57623006a09cc72da42776dfc511ed92a151fc23.1559748399.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 04/13] qemu: Use VIR_AUTO* in qemuDomainSnapshotCreateActiveExternal X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 05 Jun 2019 15:31:03 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_driver.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 65b54b7511..fad96053db 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15358,14 +15358,14 @@ qemuDomainSnapshotCreateActiveExternal(virQEMUDri= verPtr driver, bool resume =3D false; int ret =3D -1; qemuDomainObjPrivatePtr priv =3D vm->privateData; - char *xml =3D NULL; + VIR_AUTOFREE(char *) xml =3D NULL; virDomainSnapshotDefPtr snapdef =3D virDomainSnapshotObjGetDef(snap); bool memory =3D snapdef->memory =3D=3D VIR_DOMAIN_SNAPSHOT_LOCATION_EX= TERNAL; bool memory_unlink =3D false; int thaw =3D 0; /* 1 if freeze succeeded, -1 if freeze failed */ bool pmsuspended =3D false; int compressed; - char *compressedpath =3D NULL; + VIR_AUTOFREE(char *) compressedpath =3D NULL; virQEMUSaveDataPtr data =3D NULL; /* If quiesce was requested, then issue a freeze command, and a @@ -15521,8 +15521,6 @@ qemuDomainSnapshotCreateActiveExternal(virQEMUDrive= rPtr driver, } virQEMUSaveDataFree(data); - VIR_FREE(xml); - VIR_FREE(compressedpath); if (memory_unlink && ret < 0) unlink(snapdef->file); --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list