From nobody Tue May 7 16:27:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1493897615355353.9618070873713; Thu, 4 May 2017 04:33:35 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4462861BA9; Thu, 4 May 2017 11:33:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (unknown [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B1CFF17DD6; Thu, 4 May 2017 11:33:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7351C41284; Thu, 4 May 2017 11:33:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v44BWkxs011203 for ; Thu, 4 May 2017 07:32:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 22F4C17D9D; Thu, 4 May 2017 11:32:46 +0000 (UTC) Received: from narwhale.usersys.redhat.com (unknown [10.40.31.171]) by smtp.corp.redhat.com (Postfix) with ESMTP id 39F0A5DD67; Thu, 4 May 2017 11:32:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4462861BA9 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 4462861BA9 From: Erik Skultety To: libvir-list@redhat.com Date: Thu, 4 May 2017 13:32:35 +0200 Message-Id: <574718d366170b22227eda640ad94f414e9c7e2f.1493897486.git.eskultet@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Erik Skultety Subject: [libvirt] [PATCH] mdev: Fix mingw build by adding a check for non-NULL pointer X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 04 May 2017 11:33:32 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This patch fixes the following MinGW error (although actually being a false positive): ../../src/util/virmdev.c: In function 'virMediatedDeviceListMarkDevices': ../../src/util/virmdev.c:453:21: error: potential null pointer dereference [-Werror=3Dnull-dereference] const char *mdev_path =3D mdev->path; ^~~~~~~~~ Signed-off-by: Erik Skultety --- Pushed under the build breaker rule. Erik src/util/virmdev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/util/virmdev.c b/src/util/virmdev.c index c861d21..174f48c 100644 --- a/src/util/virmdev.c +++ b/src/util/virmdev.c @@ -449,9 +449,13 @@ virMediatedDeviceListMarkDevices(virMediatedDeviceList= Ptr dst, =20 virObjectLock(dst); for (i =3D 0; i < count; i++) { + const char *mdev_path =3D NULL; virMediatedDevicePtr mdev =3D virMediatedDeviceListGet(src, i); - const char *mdev_path =3D mdev->path; =20 + if (!mdev) + goto cleanup; + + mdev_path =3D mdev->path; if (virMediatedDeviceIsUsed(mdev, dst) || virMediatedDeviceSetUsedBy(mdev, drvname, domname) < 0) goto cleanup; --=20 2.9.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list