From nobody Sun Feb 8 13:13:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1553003388415937.8476322226144; Tue, 19 Mar 2019 06:49:48 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 907DB66979; Tue, 19 Mar 2019 13:49:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 55B2F611C2; Tue, 19 Mar 2019 13:49:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8D6DD181A13B; Tue, 19 Mar 2019 13:49:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x2JDnhSv012114 for ; Tue, 19 Mar 2019 09:49:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1A39819C71; Tue, 19 Mar 2019 13:49:43 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9715B2854C for ; Tue, 19 Mar 2019 13:49:42 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Tue, 19 Mar 2019 14:49:34 +0100 Message-Id: <56439c2c0fbb69e9ba58fffbf34f1df92fdd7a5b.1553003328.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/3] DO NOT APPLY: Simple reproducer for virDomainObjListRemove X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 19 Mar 2019 13:49:47 +0000 (UTC) Content-Type: text/plain; charset="utf-8" This bug demonstrates itself for other objects too, but let's show it for domains. Assume that dummy.xml contains a valid domain definition. Then 1) virsh create dummy.xml && sleep 1 2) virsh destroy dummy & 3) virsh create ../dummy.xml Observe error: error: Failed to create domain from dummy.xml error: internal error: Duplicate key Signed-off-by: Michal Privoznik --- src/conf/virdomainobjlist.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/virdomainobjlist.c b/src/conf/virdomainobjlist.c index a814fc10a3..3631cf16d0 100644 --- a/src/conf/virdomainobjlist.c +++ b/src/conf/virdomainobjlist.c @@ -396,6 +396,7 @@ virDomainObjListRemove(virDomainObjListPtr doms, dom->removing =3D true; virObjectRef(dom); virObjectUnlock(dom); + sleep(60); virObjectRWLockWrite(doms); virObjectLock(dom); virDomainObjListRemoveLocked(doms, dom); --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list