From nobody Fri May 15 10:52:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1778767090; cv=none; d=zohomail.com; s=zohoarc; b=BhCR8yxVs45qpxZAJ4uP/vBj7KLC2wdorbzcDoAONQlUUKnlRVo98xP5/djTjVxRI3Egrcm8TNSvL8WuhhFSrRlHBGrVMdzviOwgOOf6pn+1Hz/w1jduuW00SNNxH02+MYCvQxN7tDON0t9p+etszyizVqNCJduZgUOP7HqrJJ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1778767090; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=8Ps0MoUrGUu6bvqTfq525VWGJAEViFgj/lDKyyWT0Kk=; b=A1yKrdPyI1gJfTzf0A23dgu7hcuUJXhnIYhR73yAfvBXCDN5qCxUT8D3q7wfzVFvRpmr/K2ghBPq904ZCZ9Bm2WtV3iarWbHiOtaMYAvhQ7JNwbOpZXoKhJa7R69FI2LeWpBO0Z4LaJlSN0youDYvVkrchOHq6h7FVgpT0MyOuo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1778767090783952.2083631002412; Thu, 14 May 2026 06:58:10 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5292741902; Thu, 14 May 2026 09:58:09 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 362C841A32; Thu, 14 May 2026 09:57:14 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DD65B3F280; Thu, 14 May 2026 09:57:05 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id F0A7C417E7 for ; Thu, 14 May 2026 09:57:03 -0400 (EDT) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-212-1AOZaRqFOh6uPJ9DwrEyiA-1; Thu, 14 May 2026 09:57:01 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-488d3eec9bcso56761255e9.3 for ; Thu, 14 May 2026 06:57:01 -0700 (PDT) Received: from wheatley.localdomain ([213.175.37.14]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fd6276741sm34164965e9.0.2026.05.14.06.56.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 06:56:59 -0700 (PDT) Received: from wheatley.pinto-pinecone.ts.net (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id 1131B1A83BC45 for ; Thu, 14 May 2026 15:56:59 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778767023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8Ps0MoUrGUu6bvqTfq525VWGJAEViFgj/lDKyyWT0Kk=; b=iZ1QZiH/V/F1Ycnj/StjdIHvmfew5LFkuNVgwMbaX62N/xzIFEY/NepoaBL1pVMGPI0Usd iye0vE0qVb+QLjloRsDfdrYbdDnx8AAsenpFbM26wXqzVs1MGQrndNgnce+Hhy5CRag8Im jd2tlKbuBqJeMQV8mSS4xXxJEYk1IYs= X-MC-Unique: 1AOZaRqFOh6uPJ9DwrEyiA-1 X-Mimecast-MFC-AGG-ID: 1AOZaRqFOh6uPJ9DwrEyiA_1778767020 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778767020; x=1779371820; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8Ps0MoUrGUu6bvqTfq525VWGJAEViFgj/lDKyyWT0Kk=; b=sOzRAkGsK3260EV0tSlb70vPieltQSaaQWEx4bBdjNqJC2BHJ37W7CfMtmYj9/mXhe jhgJ+xRFhwnxWKV0HoNIOtL5TPNGv0/AZP67mPAzhjCTBDNQPwyswr6qwovplPiD3qt0 QWAuvkwE+krQv322PjB7NkSz7uZSRVZEDtTkyfHNoLs7aUI59RfEL4d74dWuWBsJN2KP LRPPuFHHaDMq6RtZxlCdbbo5qxSC2T4+fduoT/w9nS0DEfF/1Zi6GCO/kz/YbdxeKgYD 7jXdyw27Dwm+AcloX8PZvamKeKR2twT1pu2SeTLZaPk944uVZOyZDHP6IytwDW0eIRAD 83Yg== X-Gm-Message-State: AOJu0YxrjpDn+aWeSjb7PNVbJN73staZZpqzHqTDb6Y1ivplIGLkhwgR JVKWJp0pSiOvudl1kAEtjTwwn1GRmbHOEursoGtIpvbJ8xBJunANWIrkX8cHTseMlHpXM1r2FCe RhQhUoK5mYpfx8r/V3HkK3sPx2MtO0Y65+lK6t7w4rhI0fVnQjaw4eD19HGUVBVUnuvsoHPdBUU DVHEiVXv/b9+sVfrJ062vv+QcbyDVsT93z1ctDuzEE4dE= X-Gm-Gg: Acq92OGbdmx5F/JeJP5Nw2yBW+jRrQ08di6452UNRfsCojVytp8kxjwPJA0Suhkdnpj OW/4mpR3YBbtLxJIPu95CQLmPBSQGW8euAe3wXHle+2u8qRQDPougMaDGJ4v5R+QnQ1SHBq4Lnx LAYNUxaqRQk5YnvxLbvVff9DhimSAb/AslDNhNxTCFAC5yT7wSyx0BmxGLLETGuGKcbXvUW60dm my9EP7YM4RX+KqsXlpnSlS+vNRS2VPG7/L7aTy+XZTyONRoQ5nFVAVLW1A2h4/urzBi2iN3eSnA opO2sjg32oMtH8MBA+RMgrNDyVKI5mCP1Aq44tr+5xo1e2YLwSXVFLOdQV+HlQMoZcV7NOfQYoj n5LSOc6LrZvHBoG2cioIdRA== X-Received: by 2002:a05:600c:47c5:b0:48f:d1b8:9a9c with SMTP id 5b1f17b1804b1-48fd1b8a099mr57458355e9.7.1778767020392; Thu, 14 May 2026 06:57:00 -0700 (PDT) X-Received: by 2002:a05:600c:47c5:b0:48f:d1b8:9a9c with SMTP id 5b1f17b1804b1-48fd1b8a099mr57458025e9.7.1778767019895; Thu, 14 May 2026 06:56:59 -0700 (PDT) To: devel@lists.libvirt.org Subject: [PATCH] Revert "esx: switch VIR_FREE->g_free in esx*Free*()" Date: Thu, 14 May 2026 15:56:49 +0200 Message-ID: <55a7afabbc2f0e5e8c7b5fc46d3f4bb9db547d3c.1778767009.git.mkletzan@redhat.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SMF1-Hd1gmOSoYkqm7ESdirVb78g6ANDEGFVhU3mT50_1778767020 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WVMUKAYMLMATL6CB72Z4UGR7NL6UK3AE X-Message-ID-Hash: WVMUKAYMLMATL6CB72Z4UGR7NL6UK3AE X-MailFrom: mkletzan@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Martin Kletzander via Devel Reply-To: Martin Kletzander X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1778767131049158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Martin Kletzander This reverts commit 443c79dd7f7d4051fc0084baaa6c56a55d2aace4. Change from VIR_FREE() to g_free meant there is a possible double free when there is an error during parsing because the parsing it done directly into the parsedUri member of the esxPrivate, free'd when it fails and then the caller calls free on it again. Changing back to VIR_FREE() means there is no double free and no crash. Reproducible easily with `virsh -c esx://l?no_verify=3D2`. Signed-off-by: Martin Kletzander Reviewed-by: Pavel Hrdina --- src/esx/esx_driver.c | 2 +- src/esx/esx_stream.c | 4 ++-- src/esx/esx_util.c | 13 +++++++------ 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 010c62b8e880..6ff0db48ac02 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -63,7 +63,7 @@ esxFreePrivate(esxPrivate **priv) esxUtil_FreeParsedUri(&(*priv)->parsedUri); virObjectUnref((*priv)->caps); virObjectUnref((*priv)->xmlopt); - g_free(*priv); + VIR_FREE(*priv); } =20 =20 diff --git a/src/esx/esx_stream.c b/src/esx/esx_stream.c index 143b2405ed49..c1dd80806feb 100644 --- a/src/esx/esx_stream.c +++ b/src/esx/esx_stream.c @@ -321,8 +321,8 @@ esxFreeStreamPrivate(esxStreamPrivate **priv) return; =20 esxVI_CURL_Free(&(*priv)->curl); - g_free((*priv)->backlog); - g_free(*priv); + VIR_FREE((*priv)->backlog); + VIR_FREE(*priv); } =20 static int diff --git a/src/esx/esx_util.c b/src/esx/esx_util.c index a6275babd542..1443ec3b9e46 100644 --- a/src/esx/esx_util.c +++ b/src/esx/esx_util.c @@ -165,13 +165,14 @@ esxUtil_FreeParsedUri(esxUtil_ParsedUri **parsedUri) if (!parsedUri || !(*parsedUri)) return; =20 - g_free((*parsedUri)->transport); - g_free((*parsedUri)->vCenter); - g_free((*parsedUri)->proxy_hostname); - g_free((*parsedUri)->path); - g_free((*parsedUri)->cacert); =20 - g_free(*parsedUri); + VIR_FREE((*parsedUri)->transport); + VIR_FREE((*parsedUri)->vCenter); + VIR_FREE((*parsedUri)->proxy_hostname); + VIR_FREE((*parsedUri)->path); + VIR_FREE((*parsedUri)->cacert); + + VIR_FREE(*parsedUri); } =20 =20 --=20 2.54.0