From nobody Sun May 5 01:37:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573635156; cv=none; d=zoho.com; s=zohoarc; b=LpN4kPPtFgTNenD2eBWXpXeKj5mXWl2HgM4zgLmcFSGlJwZ/qdXe4O0qwX6K1R4u9pNZAqUjHsDbH+FbKae2joEeM4YzOoVVqNNiX/cHKue7DghXp4dLScQxGTzwHzoSvmZh4xOoMW0EamfSuRdoDUunrT2/rIxnuXrek2JHfDY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573635156; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ttnPOPUMGiqdDJSObV6gNUVZWi301E7oBWxMsGDyaGg=; b=FIkZY95TVmRMQEpGsed4b9vZYUjxQBw/rN73sFVjLZBY6PEwHuuq+QHQH0cxZ63dNA8RsMK9LZaBHSeKwiFI08K2dhV4jLMO3IOucGoQc9nwW3l0i2nzss2zYQYt5zJm03OXOGw33ZklzIrHAnPJmdYdJYTWlb3AFemdCci5M3c= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1573635156356541.5262854995989; Wed, 13 Nov 2019 00:52:36 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-5gSVKvSFOVmWLkERjQPZ9A-1; Wed, 13 Nov 2019 03:52:33 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 80BBFA12CA; Wed, 13 Nov 2019 08:52:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B9C718EC1; Wed, 13 Nov 2019 08:52:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 61DB94BB65; Wed, 13 Nov 2019 08:52:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xAD8qPgM024747 for ; Wed, 13 Nov 2019 03:52:25 -0500 Received: by smtp.corp.redhat.com (Postfix) id C62DA4D9E1; Wed, 13 Nov 2019 08:52:25 +0000 (UTC) Received: from lpt.redhat.com (unknown [10.43.2.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 51E2F4D752 for ; Wed, 13 Nov 2019 08:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573635155; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ttnPOPUMGiqdDJSObV6gNUVZWi301E7oBWxMsGDyaGg=; b=M39Kk/2f9L/N8GAlm9gwd52A0mKCBSrbm+/5Yyj2UnN65PMvk5s78cgdNm4iTIPo/tU15c R4TENKJU6nksexEeOdWhDodRBa+/A/fEuINkGkyd53J4hGejSyqGoXb9CcH01W7hEClv0V zUK3ys+VAv3zcJS3XDKlGPp010pobQc= From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Wed, 13 Nov 2019 09:53:19 +0100 Message-Id: <54dd0938375daaa68674b271f444b312d6684b01.1573635188.git.jtomko@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] locking: fix build with older sanlock X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: 5gSVKvSFOVmWLkERjQPZ9A-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" ../../src/locking/lock_driver_sanlock.c:106:17: error: incompatible pointer= types assigning to 'char **' from 'char *' [-Werror,-Wincompatible-pointer-types] message =3D g_strdup_printf(_("sanlock error %d"), err); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: b1d58418aa5051c7aafa4519b332007e7c73c261 Signed-off-by: J=C3=A1n Tomko --- src/locking/lock_driver_sanlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Pushed as a build breaker fix. diff --git a/src/locking/lock_driver_sanlock.c b/src/locking/lock_driver_sa= nlock.c index 87ba0fbfbb..c8936c301c 100644 --- a/src/locking/lock_driver_sanlock.c +++ b/src/locking/lock_driver_sanlock.c @@ -103,7 +103,7 @@ virLockManagerSanlockError(int err, #if HAVE_SANLOCK_STRERROR *message =3D g_strdup(sanlock_strerror(err)); #else - message =3D g_strdup_printf(_("sanlock error %d"), err); + *message =3D g_strdup_printf(_("sanlock error %d"), err); #endif return true; } else { --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list