From nobody Sun Feb 8 14:06:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570485185; cv=none; d=zoho.com; s=zohoarc; b=ewyOkFKNp+sNAHZ7KhA9COLX9v3CMS+LkGYBnxIINLD1UOyW8ESf5w/iwRUOZxRU37sQxtiRA/Y+8mOUfq8edWDbZ/mqGyUvR6sHJyM7CjFW2YVPspxa5crwzUqQNXrLwR822Duz0Nn23JAxR1sD3ku7r92JHUVcVfJrarmcXH8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570485185; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=2gXxKKhlWmJ43MeDExTA1chlDm6hIrwWOeG+FMZHA5o=; b=mb2ahG/UE+6l4fRgf+oyauZLlnCHXhIa1SmS4kgeXuAplCJiB4FQgOKUiLACg4xJJj4iodL3aF6XecOqaDdJnVjFvhoqS8L78suhqWqDNVQFYkUMOi9wyDqDnHqV3zfrubon7LSZBy4nAq//S9euVpRpv9CxzUKG57So6dQfsPo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1570485185503406.08500586248385; Mon, 7 Oct 2019 14:53:05 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E194B308402D; Mon, 7 Oct 2019 21:53:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BA5625DA8C; Mon, 7 Oct 2019 21:53:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7F28C4EEB8; Mon, 7 Oct 2019 21:53:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x97LocIY015094 for ; Mon, 7 Oct 2019 17:50:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id 44B885C231; Mon, 7 Oct 2019 21:50:38 +0000 (UTC) Received: from worklaptop.redhat.com (ovpn-123-156.rdu2.redhat.com [10.10.123.156]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4451C5C224; Mon, 7 Oct 2019 21:50:33 +0000 (UTC) From: Cole Robinson To: libvir-list@redhat.com Date: Mon, 7 Oct 2019 17:49:34 -0400 Message-Id: <54d9c4ea4531ec10f219e92b6de133a496d24f1f.1570482718.git.crobinso@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 20/30] security: dac: Drop !parent handling in SetImageLabelInternal X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 07 Oct 2019 21:53:03 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The only caller always passes in a non-null parent Signed-off-by: Cole Robinson Reviewed-by: Daniel Henrique Barboza --- src/security/security_dac.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 4b4afef18a..bcc781213e 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -893,9 +893,8 @@ virSecurityDACSetImageLabelInternal(virSecurityManagerP= tr mgr, return 0; =20 disk_seclabel =3D virStorageSourceGetSecurityLabelDef(src, SECURITY_DA= C_NAME); - if (parent) - parent_seclabel =3D virStorageSourceGetSecurityLabelDef(parent, - SECURITY_DAC= _NAME); + parent_seclabel =3D virStorageSourceGetSecurityLabelDef(parent, + SECURITY_DAC_NAM= E); =20 if (disk_seclabel && (!disk_seclabel->relabel || disk_seclabel->label)= ) { if (!disk_seclabel->relabel) --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list