From nobody Mon Feb 9 03:14:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626695308; cv=none; d=zohomail.com; s=zohoarc; b=I4B3sx4XMzgsuK0VFaR/WlAcMde2FHynB7VS1jT5uJXMeRt0wyvMiUA2D/o515o7vBMJbuzOYTEVN/jheNEVuRUMjb6YL0MGn7OFpsE/YBbkhHymGlBQd1V37ckvqJ57HeK4hHiza+qTtkUw8tAC3pxkhylMa5toheMceSIdUxA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626695308; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=89jkmPU4Z/szg8heA7Z4Tf7tTtRYLoGbDCnJK+RG/aU=; b=QiGm6U0/ZWWJpcHu/DzT99ZQXrfQKNLWW0Ds92Ls/akhc8w5tHgSQVP1LAoGITXlBWHH2V11yjcV0VAj04NK6BOj1hCdmldd27PkS1AJGyDf7sIljqIJk1AJXWkDLdw4qNmqN/M/c58jFXvkX04iXtTND58Rvjt9OUd3HuvkL3Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1626695308673723.90431385988; Mon, 19 Jul 2021 04:48:28 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-469-InRusx9HO46kILMgJeYxGQ-1; Mon, 19 Jul 2021 07:48:26 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D211D100C61A; Mon, 19 Jul 2021 11:48:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AC65310016F4; Mon, 19 Jul 2021 11:48:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7A0811809CB3; Mon, 19 Jul 2021 11:48:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16JBm5o3012189 for ; Mon, 19 Jul 2021 07:48:05 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9A5E460C9D; Mon, 19 Jul 2021 11:48:05 +0000 (UTC) Received: from andariel.local (unknown [10.40.194.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 09F2E60C82 for ; Mon, 19 Jul 2021 11:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626695307; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=89jkmPU4Z/szg8heA7Z4Tf7tTtRYLoGbDCnJK+RG/aU=; b=YAVpHoSXfCiRqrmksIjWB4PnkkmaAMLvQ6tVrUi5N9vIWZR2MScpLkKL2csv51TOdbNcbh DeGAbWKaaziON723wdE23g29DUkXn7Ogjw4hYrmLIJdRKI5Gf4LHDtc7KOj70HSNzqR2o5 WgyByfqVp9WF9Q88S4YOJeWkmsy6k34= X-MC-Unique: InRusx9HO46kILMgJeYxGQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 5/5] syntax-check: Prohibit 'vir' prefix for enum implementations in virsh Date: Mon, 19 Jul 2021 13:47:55 +0200 Message-Id: <544e07edd78758ee9fbdafe32c945447d703b088.1626695187.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626695311838100001 Content-Type: text/plain; charset="utf-8" Avoid potential conflict of enum helpers declared in virsh. Signed-off-by: Peter Krempa --- build-aux/syntax-check.mk | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 256f9f695a..cedb360bfd 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1717,6 +1717,13 @@ sc_group-qemu-caps: $(AM_V_GEN)$(RUNUTF8) $(PYTHON) $(top_srcdir)/scripts/group-qemu-caps.py \ --check --prefix $(top_srcdir)/ +sc_prohibit_enum_impl_with_vir_prefix_in_virsh: + @prohibit=3D'VIR_ENUM_(IMPL|DECL)\(vir[^s]' \ + in_vc_files=3D'tools/virsh.*\.[ch]$$' \ + halt=3D'avoid "vir" prefix for enums in virsh' \ + $(_sc_search_regexp) + + # List all syntax-check exemptions: exclude_file_name_regexp--sc_avoid_strcase =3D ^tools/vsh\.h$$ --=20 2.31.1