From nobody Mon Feb 9 04:09:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1642679189; cv=none; d=zohomail.com; s=zohoarc; b=n8ufX9DYKDDcVdfR83aK48ayNTY+870DAAPEEwBHc3rKdeLBDCgG18IVI4f3wAMaTxgvz00bITAg6UoJ72g3WJrVM1pkFIeqW9Fu8PR/mIuFdHPGtMiGje1gH6hk+uZHYdeYZUvJTpBPbDZKcDpreiJBkfGDFXB8fkpaiF7OP+8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642679189; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wdSkFWve+hMxQVwRHo1fmqy3m2+AemBBtAtLVJrCTt8=; b=ghE2rv3p2ZgTH1Ew49kxpqUxsG8bT+T88RelP6voIHRs923yDvFpdFLlb0WLsOCNk25Bn4QC3dVzomzX/pQBLw95eR/MD4rD2Sc7yZICnzd1PSm6MfhUvhhirKWFoMta+FKWLl6k9tYwv/6R14VmhMhMAauHR+AeVwf8NQlpghc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1642679189900618.112310451739; Thu, 20 Jan 2022 03:46:29 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-634-4X2ywB4LMOSNhORbzefPWQ-1; Thu, 20 Jan 2022 06:46:25 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 05BDA8519E1; Thu, 20 Jan 2022 11:46:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D3F8D7AB65; Thu, 20 Jan 2022 11:46:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 389524BB7C; Thu, 20 Jan 2022 11:46:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20KBkG1U030352 for ; Thu, 20 Jan 2022 06:46:16 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4D094108F833; Thu, 20 Jan 2022 11:46:16 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9CB65108BEF4 for ; Thu, 20 Jan 2022 11:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642679188; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=wdSkFWve+hMxQVwRHo1fmqy3m2+AemBBtAtLVJrCTt8=; b=UN2o1ovguMxzbuPPLshTgmm+JT/KwH/7ciH/oHizmrDpyJ2Filyxlk8Z+69x7EhOGhxoW0 FjGFutvOfS//8OZzYrO/IMORzEITSTk14tU06xbn0FLwSiKGTuRb/fijXTUaIytPSEtyB4 dSlyovZlOnJzYLXCdc6+mJWJUrjxOxM= X-MC-Unique: 4X2ywB4LMOSNhORbzefPWQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 4/5] virStoragePoolObjSourceFindDuplicateCb: Fix handling of VIR_STORAGE_POOL_ISCSI_DIRECT Date: Thu, 20 Jan 2022 12:45:57 +0100 Message-Id: <5426d1a6e9ad43d94b5b6bf93643411ef184fe59.1642679117.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1642679191509100001 Content-Type: text/plain; charset="utf-8" The direct SCSI pool doesn't expose the volumes in the host attempting to match it using 'virStoragePoolObjSourceMatchTypeDEVICE' which in turn uses 'virStoragePoolSourceFindDuplicateDevices' doesn't make sense. Remove it from the source matching completely as we can open multiple connections to the target. Signed-off-by: Peter Krempa --- src/conf/virstorageobj.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 4081e12823..58c86e8b1b 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -1447,13 +1447,11 @@ virStoragePoolObjSourceFindDuplicateCb(const void *= payload, break; case VIR_STORAGE_POOL_ISCSI: - case VIR_STORAGE_POOL_ISCSI_DIRECT: case VIR_STORAGE_POOL_FS: case VIR_STORAGE_POOL_LOGICAL: case VIR_STORAGE_POOL_DISK: case VIR_STORAGE_POOL_ZFS: if ((data->def->type =3D=3D VIR_STORAGE_POOL_ISCSI || - data->def->type =3D=3D VIR_STORAGE_POOL_ISCSI_DIRECT || data->def->type =3D=3D VIR_STORAGE_POOL_FS || data->def->type =3D=3D VIR_STORAGE_POOL_LOGICAL || data->def->type =3D=3D VIR_STORAGE_POOL_DISK || @@ -1481,6 +1479,7 @@ virStoragePoolObjSourceFindDuplicateCb(const void *pa= yload, return 1; break; + case VIR_STORAGE_POOL_ISCSI_DIRECT: case VIR_STORAGE_POOL_RBD: case VIR_STORAGE_POOL_LAST: break; --=20 2.34.1