[libvirt] [python PATCH] Remove 'Makefile'

Peter Krempa posted 1 patch 4 years, 3 months ago
Failed in applying to current master (apply log)
Makefile | 18 ------------------
1 file changed, 18 deletions(-)
delete mode 100644 Makefile
[libvirt] [python PATCH] Remove 'Makefile'
Posted by Peter Krempa 4 years, 3 months ago
Python world uses setup.py for everything so our Makefile is just a
"convenience" wrapper for people using to type 'make'. Remove it as it
doesn't add that much value and would need to be updated for python 3.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 Makefile | 18 ------------------
 1 file changed, 18 deletions(-)
 delete mode 100644 Makefile

diff --git a/Makefile b/Makefile
deleted file mode 100644
index 6c8da0a..0000000
--- a/Makefile
+++ /dev/null
@@ -1,18 +0,0 @@
-# Shim wrapper around setup.py to allow for familiar build targets
-
-PYTHON ?= python
-
-all:
-	$(PYTHON) setup.py build
-
-install: all
-	$(PYTHON) setup.py install
-
-clean:
-	$(PYTHON) setup.py clean
-
-check: all
-	$(PYTHON) setup.py test
-
-rpm:
-	$(PYTHON) setup.py rpm
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [python PATCH] Remove 'Makefile'
Posted by Pavel Hrdina 4 years, 3 months ago
On Mon, Dec 09, 2019 at 12:23:23PM +0100, Peter Krempa wrote:
> Python world uses setup.py for everything so our Makefile is just a
> "convenience" wrapper for people using to type 'make'. Remove it as it
> doesn't add that much value and would need to be updated for python 3.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  Makefile | 18 ------------------
>  1 file changed, 18 deletions(-)
>  delete mode 100644 Makefile

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list