From nobody Mon Feb 9 00:30:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576607843; cv=none; d=zohomail.com; s=zohoarc; b=gS1zcW5JbYGjmwUTSa9h1lWFGr3dvbVNjhu/8wKSRV+yDhhzH1dfHuKQsj+7mPGmicxZQdOi5+BRA4kuerBwWHRasFZBpMxqptqzAb8lwIT6HCn8vjRgDkXy32pjr7WkQjuJdAza/KhOhhvdhpKUIviqOhIROTZTx5rAquJpubE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576607843; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9JsqLy+eJIz9T97nKOK7SmPHTwS7ryrK8Q6GfLpAeiA=; b=VJwkMuwkSTOwxXlmt6fnlQDgOx0BExHwx4wqytdFbwUN+UXTlYcskDPJyYzQhtZu3Qy1yocuLK8NpUNKYsASEpP0SepTgRWcCx+rtF+QdZgp/OTCuuTwoE/g9KTkzRBcj9e9JlnFVNAi/ht8xOwpiOnV6S6bBppXYwlTNwIorps= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1576607843818198.04496079996193; Tue, 17 Dec 2019 10:37:23 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-3gqwGuuGPpiXdk7g9Lo_cw-1; Tue, 17 Dec 2019 13:37:18 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 78E16106F71D; Tue, 17 Dec 2019 18:37:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 507695C1C3; Tue, 17 Dec 2019 18:37:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F2D8318089CD; Tue, 17 Dec 2019 18:37:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBHIZnw0001018 for ; Tue, 17 Dec 2019 13:35:49 -0500 Received: by smtp.corp.redhat.com (Postfix) id 3B8087C839; Tue, 17 Dec 2019 18:35:49 +0000 (UTC) Received: from angien.redhat.com (unknown [10.43.2.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id B83067C81A for ; Tue, 17 Dec 2019 18:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576607842; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9JsqLy+eJIz9T97nKOK7SmPHTwS7ryrK8Q6GfLpAeiA=; b=S4tkxnTXiJLbZKN206L9rVtVApdl3a16KadJ89Y8uXZRIquM8En1lpYYRNUBA8ERFz92UR OcyZ8shzFymVXB7XZm4COn808zb2Nzvp5Oefgvg3PTCWzavs4CHkLrHrpJop9ZBkCEj8yE v6G4snlxzg0pKRnidRHfGk1+NPAYmho= From: Peter Krempa To: libvir-list@redhat.com Date: Tue, 17 Dec 2019 19:35:41 +0100 Message-Id: <53a7d2c5e2404cd675fea65318c195072d84d893.1576607634.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/4] tests: storage: Remove unused test modes X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: 3gqwGuuGPpiXdk7g9Lo_cw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" EXP_WARN and ALLOW_PROBE flags for the testStorageChain cases are no longer used so we can remove them. Signed-off-by: Peter Krempa --- tests/virstoragetest.c | 30 +++++++++--------------------- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index 73717b0460..93f3d1604a 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -242,8 +242,6 @@ struct _testFileData enum { EXP_PASS =3D 0, EXP_FAIL =3D 1, - EXP_WARN =3D 2, - ALLOW_PROBE =3D 4, }; struct testChainData @@ -288,25 +286,15 @@ testStorageChain(const void *args) fprintf(stderr, "call should have failed\n"); return -1; } - if (data->flags & EXP_WARN) { - if (virGetLastErrorCode() =3D=3D VIR_ERR_OK) { - fprintf(stderr, "call should have warned\n"); - return -1; - } - virResetLastError(); - if (virStorageFileChainGetBroken(meta, &broken) || !broken) { - fprintf(stderr, "call should identify broken part of chain\n"); - return -1; - } - } else { - if (virGetLastErrorCode()) { - fprintf(stderr, "call should not have warned\n"); - return -1; - } - if (virStorageFileChainGetBroken(meta, &broken) || broken) { - fprintf(stderr, "chain should not be identified as broken\n"); - return -1; - } + + if (virGetLastErrorCode()) { + fprintf(stderr, "call should not have reported error\n"); + return -1; + } + + if (virStorageFileChainGetBroken(meta, &broken) || broken) { + fprintf(stderr, "chain should not be identified as broken\n"); + return -1; } elt =3D meta; --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list