From nobody Tue Apr 16 22:08:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1531151775918715.5210134452276; Mon, 9 Jul 2018 08:56:15 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2BA554E4EE; Mon, 9 Jul 2018 15:56:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D8F5217CE9; Mon, 9 Jul 2018 15:56:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7797E14B08; Mon, 9 Jul 2018 15:56:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w69FuATN014784 for ; Mon, 9 Jul 2018 11:56:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id 436672156892; Mon, 9 Jul 2018 15:56:10 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 045AE2156891 for ; Mon, 9 Jul 2018 15:56:09 +0000 (UTC) Received: by virval.usersys.redhat.com (Postfix, from userid 500) id EFA7B104709; Mon, 9 Jul 2018 17:56:08 +0200 (CEST) From: Jiri Denemark To: libvir-list@redhat.com Date: Mon, 9 Jul 2018 17:55:58 +0200 Message-Id: <534889cae55ea29e107a9440c366d3754f3cb0d6.1531151750.git.jdenemar@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] spec: Explicitly require matching libvirt-libs X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 09 Jul 2018 15:56:15 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" All drivers now link directly to libvirt.so rather than getting the symbols from the daemon. Let's explicitly mention this dependency in the spec file. Theoretically, the automatic libvirt.so.0(LIBVIRT_PRIVATE_4.5.0) dependency should take care of everything, but rpmdiff complains it would like to see an explicit dependency on the exact libvirt-libs version too. Signed-off-by: Jiri Denemark --- Notes: The rpmdiff check may also be wrong, but I figured the explicit requires statement makes some sense and can't harm in any case. libvirt.spec.in | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 720870e2b1..6f0d399064 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -544,6 +544,7 @@ Network filter configuration files for cleaning guest t= raffic %package daemon-driver-network Summary: Network driver plugin for the libvirtd daemon Requires: libvirt-daemon =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} Requires: dnsmasq >=3D 2.41 Requires: radvd Requires: iptables @@ -560,6 +561,7 @@ bridge capabilities. %package daemon-driver-nwfilter Summary: Nwfilter driver plugin for the libvirtd daemon Requires: libvirt-daemon =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} Requires: iptables %if 0%{?rhel} && 0%{?rhel} < 7 Requires: iptables-ipv6 @@ -575,6 +577,7 @@ iptables and ip6tables capabilities %package daemon-driver-nodedev Summary: Nodedev driver plugin for the libvirtd daemon Requires: libvirt-daemon =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} # needed for device enumeration %if 0%{?fedora} || 0%{?rhel} >=3D 7 Requires: systemd >=3D 185 @@ -591,6 +594,7 @@ capabilities. %package daemon-driver-interface Summary: Interface driver plugin for the libvirtd daemon Requires: libvirt-daemon =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} %if (0%{?fedora} || 0%{?rhel} >=3D 7) Requires: netcf-libs >=3D 0.2.2 %endif @@ -604,6 +608,7 @@ netcf library %package daemon-driver-secret Summary: Secret driver plugin for the libvirtd daemon Requires: libvirt-daemon =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} =20 %description daemon-driver-secret The secret driver plugin for the libvirtd daemon, providing @@ -612,6 +617,7 @@ an implementation of the secret key APIs. %package daemon-driver-storage-core Summary: Storage driver plugin including base backends for the libvirtd da= emon Requires: libvirt-daemon =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} Requires: nfs-utils # For mkfs Requires: util-linux @@ -628,6 +634,7 @@ iSCSI, and multipath storage. %package daemon-driver-storage-logical Summary: Storage driver plugin for lvm volumes Requires: libvirt-daemon-driver-storage-core =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} Requires: lvm2 =20 %description daemon-driver-storage-logical @@ -638,6 +645,7 @@ volumes using lvm. %package daemon-driver-storage-disk Summary: Storage driver plugin for disk Requires: libvirt-daemon-driver-storage-core =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} Requires: parted Requires: device-mapper =20 @@ -649,6 +657,7 @@ volumes using the host disks. %package daemon-driver-storage-scsi Summary: Storage driver plugin for local scsi devices Requires: libvirt-daemon-driver-storage-core =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} =20 %description daemon-driver-storage-scsi The storage driver backend adding implementation of the storage APIs for s= csi @@ -658,6 +667,7 @@ host devices. %package daemon-driver-storage-iscsi Summary: Storage driver plugin for iscsi Requires: libvirt-daemon-driver-storage-core =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} Requires: iscsi-initiator-utils =20 %description daemon-driver-storage-iscsi @@ -668,6 +678,7 @@ volumes using the host iscsi stack. %package daemon-driver-storage-mpath Summary: Storage driver plugin for multipath volumes Requires: libvirt-daemon-driver-storage-core =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} Requires: device-mapper =20 %description daemon-driver-storage-mpath @@ -679,6 +690,7 @@ multipath storage using device mapper. %package daemon-driver-storage-gluster Summary: Storage driver plugin for gluster Requires: libvirt-daemon-driver-storage-core =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} %if 0%{?fedora} Requires: glusterfs-client >=3D 2.0.1 %endif @@ -696,6 +708,7 @@ volumes using libgfapi. %package daemon-driver-storage-rbd Summary: Storage driver plugin for rbd Requires: libvirt-daemon-driver-storage-core =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} =20 %description daemon-driver-storage-rbd The storage driver backend adding implementation of the storage APIs for r= bd @@ -707,6 +720,7 @@ volumes using the ceph protocol. %package daemon-driver-storage-sheepdog Summary: Storage driver plugin for sheepdog Requires: libvirt-daemon-driver-storage-core =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} Requires: sheepdog =20 %description daemon-driver-storage-sheepdog @@ -719,6 +733,7 @@ sheepdog volumes using. %package daemon-driver-storage-zfs Summary: Storage driver plugin for ZFS Requires: libvirt-daemon-driver-storage-core =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} # Support any conforming implementation of zfs Requires: /sbin/zfs Requires: /sbin/zpool @@ -760,6 +775,7 @@ parted and more. %package daemon-driver-qemu Summary: QEMU driver plugin for the libvirtd daemon Requires: libvirt-daemon =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} # There really is a hard cross-driver dependency here Requires: libvirt-daemon-driver-network =3D %{version}-%{release} Requires: libvirt-daemon-driver-storage-core =3D %{version}-%{release} @@ -784,6 +800,7 @@ QEMU %package daemon-driver-lxc Summary: LXC driver plugin for the libvirtd daemon Requires: libvirt-daemon =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} # There really is a hard cross-driver dependency here Requires: libvirt-daemon-driver-network =3D %{version}-%{release} %if 0%{?fedora} || 0%{?rhel} > 7 @@ -801,6 +818,7 @@ the Linux kernel %package daemon-driver-uml Summary: Uml driver plugin for the libvirtd daemon Requires: libvirt-daemon =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} =20 %description daemon-driver-uml The UML driver plugin for the libvirtd daemon, providing @@ -813,6 +831,7 @@ User Mode Linux %package daemon-driver-vbox Summary: VirtualBox driver plugin for the libvirtd daemon Requires: libvirt-daemon =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} =20 %description daemon-driver-vbox The vbox driver plugin for the libvirtd daemon, providing @@ -825,6 +844,7 @@ VirtualBox %package daemon-driver-libxl Summary: Libxl driver plugin for the libvirtd daemon Requires: libvirt-daemon =3D %{version}-%{release} +Requires: libvirt-libs =3D %{version}-%{release} Obsoletes: libvirt-daemon-driver-xen < 4.3.0 =20 %description daemon-driver-libxl --=20 2.18.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list