From nobody Sun Feb 8 23:32:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1636623063; cv=none; d=zohomail.com; s=zohoarc; b=jpJNintVl7WNupW1bQGmbpKqHa/JyMioLKTtfk+D5r504X/rABHfyuOuI/vdScRrjq8P85Sq1ieq6HGDTHSJPgTBucF45T1PmGfTl19OfTXFANNeIR4eoghoNK/Ulcbm/jSDUFriwBEcG+U53rst6hN3bCCUQtGgZMsTtqxn77s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636623063; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b3zexXfd0JGrVwZGj23TZV33qvUiiEVAhEMkcYqe5EA=; b=Lh67ELjrgwv4eYa4eVWZW654AJLB+mkdbWeLHrjuImyOEcWT7WeHngTZzdg1tTvsBCX2fBe30D/guJI+4keyEylAfgDXdRWFMNnnS0h7LBT9HdPpLTdvlKdvEHrbbZW8Wh9ZINwR9k0U1w3swg+epBYNGjircLVy8uxbyQ7swao= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1636623063690853.8466093717352; Thu, 11 Nov 2021 01:31:03 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-emhNHRDTPWSxLAYYDAwtXQ-1; Thu, 11 Nov 2021 04:30:07 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 355461023F52; Thu, 11 Nov 2021 09:30:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DED9519C59; Thu, 11 Nov 2021 09:30:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8DFF01800FDD; Thu, 11 Nov 2021 09:30:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AB9SUcK029390 for ; Thu, 11 Nov 2021 04:28:30 -0500 Received: by smtp.corp.redhat.com (Postfix) id AD02667841; Thu, 11 Nov 2021 09:28:30 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2697467842 for ; Thu, 11 Nov 2021 09:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636623062; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=b3zexXfd0JGrVwZGj23TZV33qvUiiEVAhEMkcYqe5EA=; b=IlWF8xMc/BoaqYzuCGRJIFxT2TUykHGejA1/Ox8IqGdXiMXsdwWzuw5qxyKFeLbxss5H6h dyy1ZSMD59O0oNZBvAZ/F9KuYcQSfsrw6E/KfZxA+IfTtB5koAXylObm+6J/GphB3P1Tk8 tSRwo55cZZVM0AXEfEmoj8C2ZQEteks= X-MC-Unique: emhNHRDTPWSxLAYYDAwtXQ-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 4/5] Use virNodeDeviceObjEndAPI() more Date: Thu, 11 Nov 2021 10:28:20 +0100 Message-Id: <52985305b6ccc78f44944cf3e106a4454c99337b.1636622879.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1636623065436100001 Content-Type: text/plain; charset="utf-8" Instead of explicit virObjectUnlock(obj) + virObjectUnref(obj) combo the virNodeDeviceObjEndAPI() can be used. Signed-off-by: Michal Privoznik --- src/conf/virnodedeviceobj.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/conf/virnodedeviceobj.c b/src/conf/virnodedeviceobj.c index 165ec1f1dd..15898a6aa7 100644 --- a/src/conf/virnodedeviceobj.c +++ b/src/conf/virnodedeviceobj.c @@ -524,8 +524,7 @@ virNodeDeviceObjListRemove(virNodeDeviceObjList *devs, virObjectRWLockWrite(devs); virObjectLock(obj); virNodeDeviceObjListRemoveLocked(devs, obj); - virObjectUnlock(obj); - virObjectUnref(obj); + virNodeDeviceObjEndAPI(&obj); virObjectRWUnlock(devs); } =20 --=20 2.32.0