From nobody Fri Apr 19 21:57:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560162781; cv=none; d=zoho.com; s=zohoarc; b=PGMncJehcU+/JxQgFTFOQHx3k1Y0bWIAlHjrI6BdhAacBaSVglEUR1Iw3zBLJu1cr+BMvTO6iEbVz23wemksVWL7QkfKqDjBKQxW58OBPQQqdIC4SkkGk1h09VNMkwe4cBZCYzgwbgxaBcOIGQSw33u8LC92rsNcdOwAX8Yk+5Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560162781; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=3puBRpJ/z8sS75eCBFTiyXScNgrf/fTZw/D38KN6Z68=; b=SNfiRLZ7R9/rb0m38LdiKTIlPBjTSfx4mv2b5koPSVJnophuXKgm+NthLJAOITsBU8fmArV3MyllC6/qVfN9iLAQFFHK8wHYJ9Lc8KuAM45LLJrUnMZde0K/iE1MVK/9MJ03AqKbISzMmM7SqE3vQGj8Y7dXnQxqfLbB8Qkdq3M= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1560162781750109.10387552332759; Mon, 10 Jun 2019 03:33:01 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8800899D2E; Mon, 10 Jun 2019 10:32:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0332F61B66; Mon, 10 Jun 2019 10:32:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B9EA81806B15; Mon, 10 Jun 2019 10:32:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5AAVtTo019310 for ; Mon, 10 Jun 2019 06:31:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id C6EAF1822A; Mon, 10 Jun 2019 10:31:55 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2BDE45C207; Mon, 10 Jun 2019 10:31:52 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Mon, 10 Jun 2019 12:31:52 +0200 Message-Id: <5207b58ac35c3697caf6b47a38397a1905de853a.1560162573.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: =?iso-8859-1?B?SuFu?= Tomko Subject: [libvirt] [PATCH 8.5/13] qemu: Rename qemuDomainSnapshotDiskDataFree to qemuDomainSnapshotDiskDataCleanup X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 10 Jun 2019 10:32:52 +0000 (UTC) Content-Type: text/plain; charset="utf-8" In commit cbb4d229de30b5 I named the function with 'free' suffix, but at that time it already did some non-freeing tasks. Rename it to make it obvious that it's not just memory managemet. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_driver.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9736933143..f1886e37b6 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15035,10 +15035,10 @@ typedef qemuDomainSnapshotDiskData *qemuDomainSna= pshotDiskDataPtr; static void -qemuDomainSnapshotDiskDataFree(qemuDomainSnapshotDiskDataPtr data, - size_t ndata, - virQEMUDriverPtr driver, - virDomainObjPtr vm) +qemuDomainSnapshotDiskDataCleanup(qemuDomainSnapshotDiskDataPtr data, + size_t ndata, + virQEMUDriverPtr driver, + virDomainObjPtr vm) { size_t i; @@ -15145,7 +15145,7 @@ qemuDomainSnapshotDiskDataCollect(virQEMUDriverPtr = driver, ret =3D 0; cleanup: - qemuDomainSnapshotDiskDataFree(data, ndata, driver, vm); + qemuDomainSnapshotDiskDataCleanup(data, ndata, driver, vm); return ret; } @@ -15322,7 +15322,7 @@ qemuDomainSnapshotCreateDiskActive(virQEMUDriverPtr= driver, ret =3D -1; cleanup: - qemuDomainSnapshotDiskDataFree(diskdata, ndiskdata, driver, vm); + qemuDomainSnapshotDiskDataCleanup(diskdata, ndiskdata, driver, vm); virErrorRestore(&orig_err); return ret; --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list