From nobody Fri Nov 21 10:10:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1762515371; cv=none; d=zohomail.com; s=zohoarc; b=DDqKS7fsKPtFkJcceLwU3xqCRJV018aLCkCHRZ22JBBy8YX4eVL5mlEpVgZpbOTPSgq025O8YsGFM3bex9i6xgwUp0OLEYB51Fb7XlWZ800W12nmeMwqVPfaZu2BsygNh1yaKhkHMqUpQsxs6ct67wtiCpgy2+jrrKjQbU1kAFs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762515371; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=XcSOzhuszLHo5zjD4c/ZTtUIyJuTpYMkBl2QYVs27DA=; b=JNFF9Kwt7fjbdK1ZvPR5fzWOR5mzSWqlw5GQwbR+J9fhJVis6V3/r8JzxLvlI0uihRKeBDdD5VN9KZ2U8g+IldPt7RaFLHx4pqAFVLr2y3rfXDp6qSmx1WiEn6kT4Ph+KHCB1eG8eo4ZdepDwDi7pn6n+zVtUxP2XkH3Ogvf5v0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1762515371471191.2523351371707; Fri, 7 Nov 2025 03:36:11 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 8B2313FBC4; Fri, 7 Nov 2025 06:36:10 -0500 (EST) Received: from [172.19.199.29] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 5F15E448FE; Fri, 7 Nov 2025 06:29:49 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 5520243DE7; Fri, 7 Nov 2025 06:29:40 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E038E44654 for ; Fri, 7 Nov 2025 06:26:46 -0500 (EST) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-yIhCuM_lNo2QzqYBOgPXCA-1; Fri, 07 Nov 2025 06:26:44 -0500 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-426ce339084so444837f8f.0 for ; Fri, 07 Nov 2025 03:26:44 -0800 (PST) Received: from wheatley.localdomain ([85.93.96.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42ac67921c3sm4763401f8f.40.2025.11.07.03.26.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Nov 2025 03:26:42 -0800 (PST) Received: from wheatley.pinto-pinecone.ts.net (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id ED7A8E161B56; Fri, 07 Nov 2025 12:26:41 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762514806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XcSOzhuszLHo5zjD4c/ZTtUIyJuTpYMkBl2QYVs27DA=; b=So6j8xUtw+oRC61FShIG8p6vhV8TludqCRHj1GCa1o1lvkx14IV+aJ5plL9cpu+9JyCnNE migB5lq7mVsCgRu2W52S5G/pRlE+SpLu3LIcZkcuFOP3wbAUKDSocaDdnwvhETckytqoCr CW4GLsAaUZ0v+GUQ+z998tt1zODGhHQ= X-MC-Unique: yIhCuM_lNo2QzqYBOgPXCA-1 X-Mimecast-MFC-AGG-ID: yIhCuM_lNo2QzqYBOgPXCA_1762514803 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762514803; x=1763119603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XcSOzhuszLHo5zjD4c/ZTtUIyJuTpYMkBl2QYVs27DA=; b=BWsxzIOLsg7f20uyIUOGhO5bEC1aGh89tAozwpFagZW1IVDKJQNE5F+5ltKObdJRAk 901xH0tzmdbI20fSuXPmMKFI0RzaCoWzaNTvARw8uyrtmKMGS3tns7rpHxI+0YhXJ2dK 46WjHLAkTy8jKRC4nENWd/RxSrjCxAqAXEAzLLECx/bN2e3rrIusgGJnNDyqLM66FNn5 OEumWPSrHHemQCgKMFQUT/65ToR4JyP0or2ZAQcMJ0l4iFXMCOeb5rCmhDWzDljgc0mD OxNcDHEUPf+p9ORGzYCd8+e3x1d2aHEGd4Kkg9zqtzbSS0WzJ7rGtyA3kAXcbVezlgPc wHSg== X-Gm-Message-State: AOJu0YxQ8TXXHDmSdaZoeK/H+YMLq7eijyBMHVSpBUQhjqphQq2FVSsu VWuA4DlJATVoI/OewyKFn/ZEquN5lqxokKqespiBJx/mwfntinmyRe5Yaq+n9vSFAvISE0XFw94 JpKjSY+cQtkDPMbllIJPI2celICAFCX8v2aaq+HVusmvUHN8ZkshrgW7iHko4JmsM6B8= X-Gm-Gg: ASbGncv0cm9lIDXPpa1YOQGqP/n+Cr2bhAom89P9GcHnH2RCqSnJKRXdNz/4zTDe2Qb 5w/gwcl/y00NL8m2kJkzn25nfR9Mll5ma2pmV+LO4/2m6oBVyjNWpcuL1Iftd+Zpn9KGS9ACnkg akrt+0wPkIFc2ej+1msK/JJcb3xbvFJAo/6yfSC1hUtGUV4kQJeWDWXn4wHJwn1cctHVJmjJ2Hp ow/EyM+RdR0qCLrDDYaup46KzLrNjfsUp2DR50A3LyP9GMGHjZfNqPdKs5mbhqwJ0ukjLxL8thY d2SUGFPFR0tqLBPOFQKfdmNRSf7pbKvFusQIeKtEbMpk1lgLfAPrRS1aFf9YkXCCogGfrCF3rf6 pJ5I/1uH7 X-Received: by 2002:a05:6000:40db:b0:429:ce0c:e67e with SMTP id ffacd0b85a97d-42ae588179emr2432295f8f.19.1762514803335; Fri, 07 Nov 2025 03:26:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwsStw/mOJx0o8SAMcAxQEE6UQVonhEhwrhp9Ex5wAl8NrDA+NGeAWC0I8+FLevJ1vyf+W1A== X-Received: by 2002:a05:6000:40db:b0:429:ce0c:e67e with SMTP id ffacd0b85a97d-42ae588179emr2432271f8f.19.1762514802932; Fri, 07 Nov 2025 03:26:42 -0800 (PST) To: devel@lists.libvirt.org Subject: [PATCH 1/7] conf: Add virDomainDefIDsParseString Date: Fri, 7 Nov 2025 12:26:29 +0100 Message-ID: <51e00d1ab20fcfd49d8e8701b218fa0d98360199.1762514681.git.mkletzan@redhat.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rmZdnTDHs2-9tw4dwb5rHQqtt3VT85LPp3AyknqwVB8_1762514803 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KFQQNR7SCDSONVPZVUXTTHMQSQMMLPEL X-Message-ID-Hash: KFQQNR7SCDSONVPZVUXTTHMQSQMMLPEL X-MailFrom: mkletzan@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: =?UTF-8?q?=D0=A1=D0=B2=D1=8F=D1=82=D0=BE=D1=81=D0=BB=D0=B0=D0=B2=20=D0=A2=D0=B5=D1=80=D0=B5=D1=88=D0=B8=D0=BD?= X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Martin Kletzander via Devel Reply-To: Martin Kletzander X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1762515373912158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Martin Kletzander This function performs only parsing with the underlying virDomainDefParseIDs() function to get needed metadata for any ACL checks, but nothing else to avoid extraneous allocations and any parser-induced DoS over ACL-forbidden connections. Signed-off-by: Martin Kletzander --- src/conf/domain_conf.c | 29 +++++++++++++++++++++++++++++ src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + 3 files changed, 33 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 396cd1c0dbc2..d2dea6952efc 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -20446,6 +20446,35 @@ virDomainDefParse(const char *xmlStr, return virDomainDefParseNode(ctxt, xmlopt, parseOpaque, flags); } =20 +virDomainDef * +virDomainDefIDsParseString(const char *xmlStr, + virDomainXMLOption *xmlopt, + unsigned int flags) +{ + g_autoptr(virDomainDef) def =3D NULL; + g_autoptr(xmlDoc) xml =3D NULL; + g_autoptr(xmlXPathContext) ctxt =3D NULL; + bool uuid_generated =3D false; + + xml =3D virXMLParseWithIndent(NULL, xmlStr, _("(domain_definition)"), + "domain", &ctxt, "domain.rng", false); + + if (!xml) + return NULL; + + def =3D virDomainDefNew(xmlopt); + if (!def) + return NULL; + + if (virDomainDefParseIDs(def, ctxt, flags, &uuid_generated) < 0) + return NULL; + + if (uuid_generated) + memset(def->uuid, 0, VIR_UUID_BUFLEN); + + return g_steal_pointer(&def); +} + virDomainDef * virDomainDefParseString(const char *xmlStr, virDomainXMLOption *xmlopt, diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 81e735993d47..11eb46ae5385 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3948,6 +3948,9 @@ virDomainDiskDef *virDomainDiskDefParse(const char *x= mlStr, virStorageSource *virDomainDiskDefParseSource(const char *xmlStr, virDomainXMLOption *xmlopt, unsigned int flags); +virDomainDef * virDomainDefIDsParseString(const char *xmlStr, + virDomainXMLOption *xmlopt, + unsigned int flags); virDomainDef *virDomainDefParseString(const char *xmlStr, virDomainXMLOption *xmlopt, void *parseOpaque, diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7269dd37862d..fb482fff40a5 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -352,6 +352,7 @@ virDomainDefHasTimer; virDomainDefHasUSB; virDomainDefHasVcpusOffline; virDomainDefHasVDPANet; +virDomainDefIDsParseString; virDomainDefLifecycleActionAllowed; virDomainDefMaybeAddController; virDomainDefMaybeAddInput; --=20 2.51.2