From nobody Sun Feb 8 19:25:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1490882645640443.6360861981839; Thu, 30 Mar 2017 07:04:05 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 01CC364DAC; Thu, 30 Mar 2017 14:04:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (unknown [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C278E82287; Thu, 30 Mar 2017 14:04:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6A23D5ED68; Thu, 30 Mar 2017 14:04:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v2UE3xLq027491 for ; Thu, 30 Mar 2017 10:03:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id 529445C547; Thu, 30 Mar 2017 14:03:59 +0000 (UTC) Received: from caroline.brq.redhat.com (dhcp129-198.brq.redhat.com [10.34.129.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF3187DA1F for ; Thu, 30 Mar 2017 14:03:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 01CC364DAC Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 01CC364DAC From: Martin Kletzander To: libvir-list@redhat.com Date: Thu, 30 Mar 2017 16:03:35 +0200 Message-Id: <518af0129750fc8d46d65e5b562ae72da544345c.1490882550.git.mkletzan@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 03/16] virsysfs: Add comments to separate logical blocks of functions X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 30 Mar 2017 14:04:04 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Martin Kletzander --- src/util/virsysfs.c | 15 +++++++++++++-- src/util/virsysfs.h | 11 +++++++++++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/src/util/virsysfs.c b/src/util/virsysfs.c index 7a98b488e0ff..c482e188a301 100644 --- a/src/util/virsysfs.c +++ b/src/util/virsysfs.c @@ -40,6 +40,9 @@ VIR_LOG_INIT("util.sysfs"); static const char *sysfs_system_path =3D SYSFS_SYSTEM_PATH; +/* + * Private function that should only be called from tests + */ void virSysfsSetSystemPath(const char *path) { if (path) @@ -49,6 +52,9 @@ void virSysfsSetSystemPath(const char *path) } +/* + * Generic getters + */ const char * virSysfsGetSystemPath(void) { @@ -110,6 +116,9 @@ virSysfsGetValueBitmap(const char *file, return ret; } +/* + * Per-CPU getters + */ int virSysfsGetCpuValueInt(unsigned int cpu, const char *file, @@ -127,7 +136,6 @@ virSysfsGetCpuValueInt(unsigned int cpu, return ret; } - int virSysfsGetCpuValueUint(unsigned int cpu, const char *file, @@ -145,7 +153,6 @@ virSysfsGetCpuValueUint(unsigned int cpu, return ret; } - int virSysfsGetCpuValueString(unsigned int cpu, const char *file, @@ -187,6 +194,10 @@ virSysfsGetCpuValueBitmap(unsigned int cpu, return ret; } + +/* + * Per-NUMA node getters + */ int virSysfsGetNodeValueString(unsigned int node, const char *file, diff --git a/src/util/virsysfs.h b/src/util/virsysfs.h index cd871ff11dd1..1b24fc193a16 100644 --- a/src/util/virsysfs.h +++ b/src/util/virsysfs.h @@ -24,6 +24,9 @@ # include "internal.h" # include "virbitmap.h" +/* + * Generic getters + */ const char * virSysfsGetSystemPath(void); int @@ -38,6 +41,10 @@ int virSysfsGetValueBitmap(const char *file, virBitmapPtr *value); + +/* + * Per-CPU getters + */ int virSysfsGetCpuValueInt(unsigned int cpu, const char *file, @@ -57,6 +64,10 @@ virSysfsGetCpuValueBitmap(unsigned int cpu, const char *file, virBitmapPtr *value); + +/* + * Per-NUMA node getters + */ int virSysfsGetNodeValueString(unsigned int node, const char *file, --=20 2.12.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list