From nobody Mon Feb 9 07:07:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1646817059; cv=none; d=zohomail.com; s=zohoarc; b=XxbWx8gyF0P9Sr4rbZ1wBnT78fdfrQRbsRs2sYgGpEclAUPW/lnTTo/7VePg1OGSqVYMfVhP221ysy5wygFzOx3tgqo2KFlF51Ia4FHldHYCUuQ2vXLlyHFo07fdA4LaKgEhhtzA9OBljdRIqkK0nVffw1/WJ3Tnwgsxbpy9BhY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646817059; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=y3pAKf9hBJTZip2N6KPYK0utJAmhyZRxb2AAWIlW3jU=; b=N+3GvLeLHsVPEr0Dn3U10llFA97rdC0FI9bKtG+DUxFf+P7bYtMfdyrLpXp8V0fQbagsX3ze/DQqAQIpOO7d2r3pEG7bqMDggGyepSekehKpUIumkPs0cbcvmMlwDeYQz7fjoSd6puQWpXUf+g4e/a5Bm3K7V+Kb/nj4Y0SaG8Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1646817059112644.9424651564766; Wed, 9 Mar 2022 01:10:59 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-249-Tl8ZztTRPQG00AYJoN7aIA-1; Wed, 09 Mar 2022 04:10:57 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 07454899ED6; Wed, 9 Mar 2022 09:10:55 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E8B45141DED4; Wed, 9 Mar 2022 09:10:54 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 71CD6196636B; Wed, 9 Mar 2022 09:10:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 193A9194F4AE for ; Wed, 9 Mar 2022 09:10:53 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id DC1D66AB88; Wed, 9 Mar 2022 09:10:52 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 439217AB47 for ; Wed, 9 Mar 2022 09:10:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646817058; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=y3pAKf9hBJTZip2N6KPYK0utJAmhyZRxb2AAWIlW3jU=; b=gM97XbiOyWNEO9zkOyYywCAjLiYYU30jM2DJwdyGspWsM72GWctyPYzGy9FOodKzD3MWbf lEeQX1r/trm1DQFNfgCh5Zj97kG4dlau7nZ8ELJnwI5zaA85lMhGBBTEjR/aMV6SJWrK7C noV4R1Ttqy1YXiRKUmSTrJlK/nIJLwU= X-MC-Unique: Tl8ZztTRPQG00AYJoN7aIA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/4] docs: formatsnapshot: Move paragraphs describing 'disk' element together Date: Wed, 9 Mar 2022 10:09:46 +0100 Message-Id: <514f00b78634f50a3a7b3b5d5fb3410dab588218.1646816909.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1646817961418100001 Content-Type: text/plain; charset="utf-8" There was another paragraph describing the attribute 'type' of the 'disk' element under the description of the subelements. Move it to the top to get all relevant information in one place. Signed-off-by: Peter Krempa --- docs/formatsnapshot.rst | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/docs/formatsnapshot.rst b/docs/formatsnapshot.rst index 0ad397316c..b0d8d7ea2f 100644 --- a/docs/formatsnapshot.rst +++ b/docs/formatsnapshot.rst @@ -124,6 +124,17 @@ The top-level ``domainsnapshot`` element may contain t= he following elements: corresponding domain disk, while others like qemu allow this field to override the domain default. + :since:`Since 1.2.2` the ``disk`` element supports an optional attri= bute + ``type`` if the ``snapshot`` attribute is set to ``external``. This + attribute specifies the snapshot target storage type and allows to + overwrite the default ``file`` type. The ``type`` attribute along wi= th + the format of the ``source`` sub-element is identical to the ``sourc= e`` + element used in domain disk definitions. See the `disk devices + `__ section documentation for furth= er + information. Libvirt currently supports the ``type`` element in the = qemu + driver and supported values are ``file``, ``block`` and ``network`` = with + a protocol of ``gluster`` :since:`(since 1.2.2)` . + ``source`` If the snapshot mode is external (whether specified or inherited), @@ -151,17 +162,6 @@ The top-level ``domainsnapshot`` element may contain t= he following elements: ``seclabel`` - :since:`Since 1.2.2` the ``disk`` element supports an optional attri= bute - ``type`` if the ``snapshot`` attribute is set to ``external``. This - attribute specifies the snapshot target storage type and allows to - overwrite the default ``file`` type. The ``type`` attribute along wi= th - the format of the ``source`` sub-element is identical to the ``sourc= e`` - element used in domain disk definitions. See the `disk devices - `__ section documentation for furth= er - information. Libvirt currently supports the ``type`` element in the = qemu - driver and supported values are ``file``, ``block`` and ``network`` = with - a protocol of ``gluster`` :since:`(since 1.2.2)` . - ``creationTime`` A readonly representation of the time this snapshot was created. The ti= me is --=20 2.35.1