From nobody Sun Feb 8 20:34:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633504621; cv=none; d=zohomail.com; s=zohoarc; b=kMGasO8wbtozq6PDhbe4Xib5xmEZnSiY4wiQhwq3XPTMrt53lVUY7rPT0H0sXAMqcTT/nlS+Udg+PhIIgKVTXvPE5fjA4SmzNzOdNEx2C5he2zYmK84hHrlqAO1YevJjhp8HFi8CfEmcRJ3D4wTGEviaruAtL0THmzf1DtEHnlM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633504621; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=04ftWJyNMHybQB0OeMDhj+b1NvyIdEqe2N/r0s2Vs6U=; b=BiQWjOvQK8v0ufZIcqR3QmQpPqCiHgr0zjXcRScYtCBiqKllERzu1g18nSPJeBcQ832YPk8PAVUlRFFxJJzlaFVJfmNHblySCuuIxXWWLw8TZa//++QBlNFgluyINJq4yd1i6f/aY47bmbAzi0t49NfiM8ypypMLJo4uB63oHAs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1633504621237850.2489522383923; Wed, 6 Oct 2021 00:17:01 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-ixHD-HZEMWuAZXGLST9TgA-1; Wed, 06 Oct 2021 03:16:58 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0FAD83DBC4; Wed, 6 Oct 2021 07:16:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7BCBB17F72; Wed, 6 Oct 2021 07:16:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 444884EA3C; Wed, 6 Oct 2021 07:16:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1967FiEG007460 for ; Wed, 6 Oct 2021 03:15:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8A2B760936; Wed, 6 Oct 2021 07:15:44 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id 14E1E60C2B for ; Wed, 6 Oct 2021 07:15:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633504620; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=04ftWJyNMHybQB0OeMDhj+b1NvyIdEqe2N/r0s2Vs6U=; b=Vx4H7Tu2MravGgAkGBGDjSaQOZWaVt4Aenk5M5Z/mht15ioJc9FkpOwlBeHoRcHvLMvD0s MZvUSiYBHskkPKiOc0H6gmV2MNN9eYsJsG9QyrqCiHRIziV1WwcET97gTSYpYmdiMF5dA4 st9jHlZtHtMp2U3lKCo0UwflT02Fbdk= X-MC-Unique: ixHD-HZEMWuAZXGLST9TgA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 06/16] qemu: vhost-user-fs: separate building of chardev string Date: Wed, 6 Oct 2021 09:15:12 +0200 Message-Id: <50e5d9473961721e3bc200e95c060ca8bc4658c1.1633504466.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633504622252100001 Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 90c8022b07..7e76e188c1 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2033,6 +2033,20 @@ qemuBuildDisksCommandLine(virCommand *cmd, } =20 =20 +static char * +qemuBuildVHostUserFsChardevStr(const virDomainFSDef *fs, + const char *chardev_alias) +{ + g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; + + virBufferAddLit(&buf, "socket"); + virBufferAsprintf(&buf, ",id=3D%s", chardev_alias); + virBufferAddLit(&buf, ",path=3D"); + virQEMUBuildBufferEscapeComma(&buf, QEMU_DOMAIN_FS_PRIVATE(fs)->vhostu= ser_fs_sock); + return virBufferContentAndReset(&buf); +} + + static int qemuBuildVHostUserFsCommandLine(virCommand *cmd, virDomainFSDef *fs, @@ -2040,16 +2054,14 @@ qemuBuildVHostUserFsCommandLine(virCommand *cmd, qemuDomainObjPrivate *priv) { g_autofree char *chardev_alias =3D NULL; + g_autofree char *chrdevstr =3D NULL; g_auto(virBuffer) opt =3D VIR_BUFFER_INITIALIZER; =20 chardev_alias =3D qemuDomainGetVhostUserChrAlias(fs->info.alias); + chrdevstr =3D qemuBuildVHostUserFsChardevStr(fs, chardev_alias); =20 virCommandAddArg(cmd, "-chardev"); - virBufferAddLit(&opt, "socket"); - virBufferAsprintf(&opt, ",id=3D%s", chardev_alias); - virBufferAddLit(&opt, ",path=3D"); - virQEMUBuildBufferEscapeComma(&opt, QEMU_DOMAIN_FS_PRIVATE(fs)->vhostu= ser_fs_sock); - virCommandAddArgBuffer(cmd, &opt); + virCommandAddArg(cmd, chrdevstr); =20 virCommandAddArg(cmd, "-device"); =20 --=20 2.31.1