From nobody Mon Feb 9 20:36:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1653551464712319.952831553023; Thu, 26 May 2022 00:51:04 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-470-9FHfQZdLNmGgCxXJiagebg-1; Thu, 26 May 2022 03:50:52 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ED40F1875076; Thu, 26 May 2022 07:50:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 407DE492CA3; Thu, 26 May 2022 07:50:48 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BD40D192EFFB; Thu, 26 May 2022 07:50:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8CC3A194EB88 for ; Wed, 25 May 2022 22:20:46 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 4F70C1410DD7; Wed, 25 May 2022 22:20:46 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B8381410DD5 for ; Wed, 25 May 2022 22:20:46 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 34106800B21 for ; Wed, 25 May 2022 22:20:46 +0000 (UTC) Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-631-iJi3VYydOPiQX6gsXIYt-Q-1; Wed, 25 May 2022 18:20:44 -0400 Received: by mail-qk1-f171.google.com with SMTP id p63so347353qkf.0 for ; Wed, 25 May 2022 15:20:44 -0700 (PDT) Received: from lagunitas.localdomain (66-63-33-3.realconnect.com. [66.63.33.3]) by smtp.gmail.com with ESMTPSA id g184-20020a37b6c1000000b006a41373b5a0sm94979qkf.96.2022.05.25.15.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 15:20:42 -0700 (PDT) X-MC-Unique: 9FHfQZdLNmGgCxXJiagebg-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: iJi3VYydOPiQX6gsXIYt-Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D/4RtvI4GhGTX8GMcO2FRveSD1yT3MV/JTMmUdpFc34=; b=Odn1Cgq+rDdYQjn15CSd1V3nEqtLbqu+ydwLZ14Gxn5K1DMTPtINPem/ZcQT627YOs bbMcFHdymVp3cl9e4p9/6f21oSUKw0PfOIQMWKmsV0NLeTlguJwlflgKHItsNA8uLjm0 C2ijY24VC4YJj0fnPejR9i5dvqUVIFe61yIyL9xgAufgu0Nrnd4464qRLRJXPpgOpbQM sQLkeXazgJ4JGLmH2e+MiUsg6ulydoDPeclRdvWSs6ibcXJunYDw+BSx/1e/GRGgofG4 TyKuwun5Y2E/BD09m2RZdKf9TyJLXRjECfEm4NI03yhIYqV0+lRfyXmxJak/BywWuVvZ Ui8w== X-Gm-Message-State: AOAM531VErAH5MqZSDGisBqlLktZA2zRkulxQPxFXQAn1Uj+8NQ7LY4T v73v31GOqcPMsGE//8kDJPz/ghRZd6niiQ== X-Google-Smtp-Source: ABdhPJxFsP9TS+zxB1ELTmIT+Oe87ykQGMpy180luRtpLx58h324cPLGcpQD5TmulXoOsgU2BFqzIA== X-Received: by 2002:a05:620a:2a16:b0:6a5:9017:d781 with SMTP id o22-20020a05620a2a1600b006a59017d781mr3945990qkp.298.1653517243425; Wed, 25 May 2022 15:20:43 -0700 (PDT) From: Scott Davis X-Google-Original-From: Scott Davis To: libvir-list@redhat.com Subject: [libvirt PATCH 1/3] qemu: fix null string specifier argument in qemuDomainBlockJobAbort Date: Wed, 25 May 2022 18:20:38 -0400 Message-Id: <50df1d3bec49e7ee075f365c962981ec7990f137.1653517208.git.scott.davis@starlab.io> In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mailman-Approved-At: Thu, 26 May 2022 07:50:45 +0000 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Davis Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1653551465742100003 Detected by gcc 11 -Wformat-overflow: ../../src/qemu/qemu_driver.c: In function =E2=80=98qemuDomainBlockJobAbort= =E2=80=99: ../../src/util/virerror.h:176:5: warning: =E2=80=98%s=E2=80=99 directive ar= gument is null [-Wformat-overflow=3D] 176 | virReportErrorHelper(VIR_FROM_THIS, code, __FILE__, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 177 | __FUNCTION__, __LINE__, __VA_ARGS__) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../src/qemu/qemu_driver.c:14475:17: note: in expansion of macro =E2=80= =98virReportError=E2=80=99 14475 | virReportError(VIR_ERR_OPERATION_FAILED, | ^~~~~~~~~~~~~~ ../../src/qemu/qemu_driver.c:14476:73: note: format string is defined here 14476 | _("block job '%s' failed while pivot= ing: %s"), | = ^~ Signed-off-by: Scott Davis --- src/qemu/qemu_driver.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6631edb9d6..d3ba74c14a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -14581,13 +14581,13 @@ qemuDomainBlockJobAbort(virDomainPtr dom, if (pivot && job->state =3D=3D QEMU_BLOCKJOB_STATE_FAILED) { if (job->errmsg) { - virReportError(VIR_ERR_OPERATION_FAILED, - _("block job '%s' failed while pivoting"), - job->name); - } else { virReportError(VIR_ERR_OPERATION_FAILED, _("block job '%s' failed while pivoting: %s= "), job->name, job->errmsg); + } else { + virReportError(VIR_ERR_OPERATION_FAILED, + _("block job '%s' failed while pivoting"), + job->name); } =20 ret =3D -1; --=20 2.25.1