From nobody Mon Feb 9 05:20:57 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710510791699301.3472600735495; Fri, 15 Mar 2024 06:53:11 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 84EA11A9F; Fri, 15 Mar 2024 09:53:10 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C0D5D1CB4; Fri, 15 Mar 2024 09:45:18 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 6FA741790; Fri, 15 Mar 2024 09:45:07 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 320D91AB9 for ; Fri, 15 Mar 2024 09:44:36 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-218-Rt5o0Qr3Nuel2RHFQHu3eQ-1; Fri, 15 Mar 2024 09:44:34 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6BD3980026D for ; Fri, 15 Mar 2024 13:44:34 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id DBA3AC15771 for ; Fri, 15 Mar 2024 13:44:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: Rt5o0Qr3Nuel2RHFQHu3eQ-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 10/28] virsh: Annotate rest of _ARGV arguments as positional Date: Fri, 15 Mar 2024 14:44:05 +0100 Message-ID: <501d52753bd7684b65ab9202e97fe386bed25a93.1710510136.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: 7KNDCXPDL2SJMAKQN7DIGGXWBFJKQCKP X-Message-ID-Hash: 7KNDCXPDL2SJMAKQN7DIGGXWBFJKQCKP X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710510792841100001 In most cases it's the usual/recommended way to use those commands: $ virsh qemu-monitor-command VMNAME cmd args args args Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 8 ++++++++ tools/virsh-network.c | 1 + 2 files changed, 9 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 0bf4d524b0..801b01bb42 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -5000,6 +5000,7 @@ static const vshCmdOptDef opts_schedinfo[] =3D { VIRSH_COMMON_OPT_LIVE(N_("get/set value from running domain")), {.name =3D "set", .type =3D VSH_OT_ARGV, + .positional =3D true, .flags =3D VSH_OFLAG_NONE, .help =3D N_("parameter=3Dvalue") }, @@ -8188,6 +8189,7 @@ static const vshCmdOptDef opts_desc[] =3D { }, {.name =3D "new-desc", .type =3D VSH_OT_ARGV, + .positional =3D true, .help =3D N_("message") }, {.name =3D NULL} @@ -8493,6 +8495,7 @@ static const vshCmdOptDef opts_send_key[] =3D { {.name =3D "keycode", .type =3D VSH_OT_ARGV, .required =3D true, + .positional =3D true, .completer =3D virshKeycodeNameCompleter, .help =3D N_("the key code") }, @@ -9600,6 +9603,7 @@ static const vshCmdOptDef opts_qemu_monitor_command[]= =3D { }, {.name =3D "cmd", .type =3D VSH_OT_ARGV, + .positional =3D true, .required =3D true, .help =3D N_("command") }, @@ -9996,6 +10000,7 @@ static const vshCmdOptDef opts_qemu_agent_command[] = =3D { }, {.name =3D "cmd", .type =3D VSH_OT_ARGV, + .positional =3D true, .required =3D true, .help =3D N_("command") }, @@ -10092,6 +10097,7 @@ static const vshCmdOptDef opts_lxc_enter_namespace[= ] =3D { }, {.name =3D "cmd", .type =3D VSH_OT_ARGV, + .positional =3D true, .required =3D true, .help =3D N_("command to run") }, @@ -12795,6 +12801,7 @@ static const vshCmdOptDef opts_domfsfreeze[] =3D { VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE), {.name =3D "mountpoint", .type =3D VSH_OT_ARGV, + .positional =3D true, .completer =3D virshDomainFSMountpointsCompleter, .help =3D N_("mountpoint path to be frozen") }, @@ -12835,6 +12842,7 @@ static const vshCmdOptDef opts_domfsthaw[] =3D { VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE), {.name =3D "mountpoint", .type =3D VSH_OT_ARGV, + .positional =3D true, .completer =3D virshDomainFSMountpointsCompleter, .help =3D N_("mountpoint path to be thawed") }, diff --git a/tools/virsh-network.c b/tools/virsh-network.c index 240d10eea7..59ca842181 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -324,6 +324,7 @@ static const vshCmdOptDef opts_network_desc[] =3D { }, {.name =3D "new-desc", .type =3D VSH_OT_ARGV, + .positional =3D true, .help =3D N_("message") }, {.name =3D NULL} --=20 2.44.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org