From nobody Sat May 4 23:15:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599061690; cv=none; d=zohomail.com; s=zohoarc; b=G3nJvy8txIQyjYXcg0c6JihACUa7Sm3EVJQyJr3/c2+nRFxnLNxqjwuEJSwhTIfijs3/2+h15EJ3bHBvP5cVzw9/Hms/pCQOz0FteEJY2KI1K29+HnZIR6Ay2JLEZczrr/uycsRSPvinzxptDPnJvVt2k+/w9FMOeOnYrJIW19g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599061690; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=yvkEbHyG5bXMtNIJAvfNV7ey/7Py8Ea517u8xDMmpkE=; b=LHv5BIhQm7WUDYpIr8307wq0lE8IAcG4qs0LHL+aVPVSHOn7AsaQpqPjzSUIJzf0bc4lNVt9DzjuShYHwo4mHlLaspZ+6xLAobnjxiK2pCEPBcXs/DE7XXxAfwlmtGHzHcORX/vnfa4RrgwHdnF7tmqAp7YkTuVFXa4AUfKqYtM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 159906169066367.47655466874176; Wed, 2 Sep 2020 08:48:10 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230--W_y3gFKNuiNdruok1SY3A-1; Wed, 02 Sep 2020 11:48:04 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E6EFF81CBE5; Wed, 2 Sep 2020 15:47:57 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B6A0D5D9E4; Wed, 2 Sep 2020 15:47:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CAC9779DA0; Wed, 2 Sep 2020 15:47:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 082Flnq5031686 for ; Wed, 2 Sep 2020 11:47:49 -0400 Received: by smtp.corp.redhat.com (Postfix) id A61EE7AEF7; Wed, 2 Sep 2020 15:47:49 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.193.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 27CA576E01 for ; Wed, 2 Sep 2020 15:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599061690; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=yvkEbHyG5bXMtNIJAvfNV7ey/7Py8Ea517u8xDMmpkE=; b=KxNaJvr0WMiFAI8uEzglrAnSc7ff9EdJTjwDD7pISDgDQFm/i4qoo7azGzNHNbs4rwj7tU /XxL7I1CX5bxLxI34NGIBmJUjJGTcT5eqqBpLt/FsYku5TZ028/KpFfradGiSd0Pu5naCL SObGD8unVYf8kqwHqhOtIdfMe7UpG58= X-MC-Unique: -W_y3gFKNuiNdruok1SY3A-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] vsh: Define HAVE_STDARG_H before including readline Date: Wed, 2 Sep 2020 17:47:43 +0200 Message-Id: <4f8dbd332899483a3a24ea4c793cb1ec759d8a9f.1599061663.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" As it turned out my previous commits which switched from HAVE_ to WITH_ and dropped stdarg.h detection were a bit too aggressive. Because of reasons described in 9ea3424a178 we need to define HAVE_STDARG_H before including readline otherwise macos build fails. Honestly, I still don't fully understand the problem so I am not going to bother you with "explanation". Signed-off-by: Michal Privoznik --- tools/vsh.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/vsh.c b/tools/vsh.c index 11f493f969..d063a7f8cb 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -30,6 +30,10 @@ #include =20 #if WITH_READLINE +/* In order to have proper rl_message declaration with older + * versions of readline, we have to declare this. See 9ea3424a178 + * for more info. */ +# define HAVE_STDARG_H # include # include #endif --=20 2.26.2