From nobody Sat Apr 20 12:03:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570645616; cv=none; d=zoho.com; s=zohoarc; b=mLc/KsrWhr1S4q2enclgjYuBZp7OZQRVIEVz655IfJ8J06kC+5qHdWoUFbAzByCaH9KVwY/Of/UlmgOGTG60l/q+BBaQ3xDBg6ztyx8fqk9TLWGiBlPfvFe0+9V+SMP7213LWrWhAi3p3K5M0aEsJCWuOBCsi3BwTZPtHlDX89w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570645616; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=5/rf0s5vNnWOMqkG/FSOmcVBahInnfXtzm04b8ECwbg=; b=jQupoq8Gasd6NtzF/TJT7ai2iHvCfkLvYhvjOVHMgoRdHxc9VyRPtClz8OU7s6IscuZHgi2TZQh3XdD2drNKaglJlHAgXdah5EOJOGLTxKDH1ieLaTf53LucgI8TpPsmJJ5Uih+QoYgFMonKS8k4D6WAVbu4RWr7kZ1gQxkK5e0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1570645616554563.7810654567619; Wed, 9 Oct 2019 11:26:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DD6DB18C4283; Wed, 9 Oct 2019 18:26:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 69ACC19C69; Wed, 9 Oct 2019 18:26:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9A9EF1803B48; Wed, 9 Oct 2019 18:26:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x99IO79M019907 for ; Wed, 9 Oct 2019 14:24:07 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3A1C56060D; Wed, 9 Oct 2019 18:24:07 +0000 (UTC) Received: from worklaptop.redhat.com (ovpn-121-97.rdu2.redhat.com [10.10.121.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 81EBD6092F; Wed, 9 Oct 2019 18:24:03 +0000 (UTC) From: Cole Robinson To: libvirt-list@redhat.com Date: Wed, 9 Oct 2019 14:24:32 -0400 Message-Id: <4f29d3bf533c9b30482b9a7fe72e454058962434.1570645360.git.crobinso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: christian.ehrhardt@canonical.com Subject: [libvirt] [PATCH] security: apparmor: Allow RO /usr/share/edk2/ X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Wed, 09 Oct 2019 18:26:55 +0000 (UTC) Content-Type: text/plain; charset="utf-8" On Fedora, already whitelisted paths to AAVMF and OVMF binaries are symlinks to binaries under /usr/share/edk2/. Add that directory to the RO whitelist so virt-aa-helper-test passes Signed-off-by: Cole Robinson Reviewed-by: Michal Privoznik --- I don't know if anyone is actually using apparmor on Fedora, but I have the libs installed now for testing. I think the better thing to do would be to adjust virt-aa-helper-test to not touch host state src/security/virt-aa-helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index d9f6b5638b..509187ac36 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -505,6 +505,7 @@ valid_path(const char *path, const bool readonly) "/vmlinuz", "/initrd", "/initrd.img", + "/usr/share/edk2/", "/usr/share/OVMF/", /* for OVMF images */ "/usr/share/ovmf/", /* for OVMF images */ "/usr/share/AAVMF/", /* for AAVMF images */ --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list