[PATCH] XML validate that 'ramfb' has no address

Kristina Hanicova posted 1 patch 3 years ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/4ebe81bd19d9cfdd5343406bce31cb811a378582.1614945619.git.khanicov@redhat.com
src/conf/domain_validate.c | 8 ++++++++
1 file changed, 8 insertions(+)
[PATCH] XML validate that 'ramfb' has no address
Posted by Kristina Hanicova 3 years ago
With this, XML fails if config video type 'ramfb' contains
address, since address is not supported for 'ramfb' video
devices. Previously it didn't raise error.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1891416
Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
---
 src/conf/domain_validate.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c
index b4e09e21fe..c9c677ddf5 100644
--- a/src/conf/domain_validate.c
+++ b/src/conf/domain_validate.c
@@ -151,6 +151,14 @@ virDomainVideoDefValidate(const virDomainVideoDef *video,
         }
     }
 
+    if (video->type == VIR_DOMAIN_VIDEO_TYPE_RAMFB) {
+        if (video->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) {
+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                           _("address not supported for video type ramfb"));
+            return -1;
+        }
+    }
+
     return 0;
 }
 
-- 
2.29.2

Re: [PATCH] XML validate that 'ramfb' has no address
Posted by Ján Tomko 3 years ago
On a Friday in 2021, Kristina Hanicova wrote:
>With this, XML fails if config video type 'ramfb' contains
>address, since address is not supported for 'ramfb' video
>devices. Previously it didn't raise error.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1891416
>Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
>---
> src/conf/domain_validate.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano