From nobody Mon Feb 9 01:22:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) client-ip=216.205.24.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584457537; cv=none; d=zohomail.com; s=zohoarc; b=hv1J5gvwBKvLN053bSNFbxp6+RShPSOeKE1xR+0VgF3hNgkCJX29CUMTR9unD8R5Beo7QOmO+dj9JkKxgXkaoWewS8cM+8tCsPLC/r/B7/YNdGWivWyVmR1EtopRJElM2Y1P5UF2/KsMEG8pQFrt/c9wJJvFu7/3a2KgZIYMBy0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584457537; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dIlLl0wsQRTPWm3zIdAnaLtgznqT3Z/Adfm7EfU9LzI=; b=cRpho/evuHfVqHQJAT7KBw1wToEzq3YTraIJe/ZIVrylWvQnmhJcg0EuSZsY0epC+ZW/tMWbXsUtKGB0xUK8nyhje4/RJ86h8Ckxgiuo3jCtRCZC72flRymFEeg7a1RAOW5gxVuataQDXbtN19nUXdNhlK13aHgzW9D6UXCOTyc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mx.zohomail.com with SMTPS id 1584457537449318.21391428861716; Tue, 17 Mar 2020 08:05:37 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-239-HQWpTmW0PiSwEEGLAObulg-1; Tue, 17 Mar 2020 11:05:30 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CD3948014D2; Tue, 17 Mar 2020 15:05:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3EE5890803; Tue, 17 Mar 2020 15:05:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CFAC218089C8; Tue, 17 Mar 2020 15:05:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02HF5Lje004551 for ; Tue, 17 Mar 2020 11:05:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id E6ECF5C219; Tue, 17 Mar 2020 15:05:21 +0000 (UTC) Received: from angien.redhat.com (unknown [10.43.2.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C12D5C1D8 for ; Tue, 17 Mar 2020 15:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584457536; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=dIlLl0wsQRTPWm3zIdAnaLtgznqT3Z/Adfm7EfU9LzI=; b=WwIX8GwY1e/Si/JFewZi8v8jBjcrf81xLO3eR02iVK02j3z9jRjY3sQpw0Gj1MQ1xrRlQA i2YxV+3VscSwjzcPkvcAL2Z8axsEpRVbitcSIZuN67hDK54TsjPymGoUc4tpuAOQeC+kmu vJ2ntbKvTOC4AHvM2HFcF54qrvb7/Bo= X-MC-Unique: HQWpTmW0PiSwEEGLAObulg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/3] qemuBlockBitmapsHandleCommitStart: Fix allocation of string list Date: Tue, 17 Mar 2020 16:05:13 +0100 Message-Id: <4cf6784be34664c898fb2ee090b17dd1456ffa2c.1584457464.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Allocate space also for the terminating NULL. Reported-by: Daniel P. Berrang=C3=A9 Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index cc2edff5e0..115682c39d 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -3021,7 +3021,7 @@ qemuBlockBitmapsHandleCommitStart(virStorageSourcePtr= topsrc, if (!(entry =3D virHashLookup(blockNamedNodeData, basesrc->nodeformat)= )) return 0; - bitmaplist =3D g_new0(char *, entry->nbitmaps); + bitmaplist =3D g_new0(char *, entry->nbitmaps + 1); for (i =3D 0; i < entry->nbitmaps; i++) { qemuBlockNamedNodeDataBitmapPtr bitmap =3D entry->bitmaps[i]; --=20 2.24.1