From nobody Tue Oct 22 23:20:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695032706; cv=none; d=zohomail.com; s=zohoarc; b=IFhG5207lBPuvggrLY1Prln7OVsPxKP32Xteq8I1W8SejHSurg9cB47oKP/PVyVjulg+mACmK5cIBEgfeZcIVnwXCoeRgOhHr0j17wxgJFXunEWHPk7lCkG1+69d98pqy8qfagrZUyfOP74b1w9Zpn4LMGOeiEpQRaCHqSUAgg0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695032706; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=doh4T2ohvQ1Oc0+uMZ8tNvlD8o67gEBKvG2NoWfUtQQ=; b=byLj3obhZn05arfS7Ulyb0XbkgkfpAjogyhZn6+uNxgjxt3ZC9XscN/21R6+Oxpze3afiGhSZmo8uQoY1901mtWC+b5WmRPl1tWcXr3WGbNiLjR0VRIfD8qcJrQTkZC4qMBsvdrf1N3VfyMSv60kQUHNimfMiBYiz80u0zwAZj8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1695032706442427.7345829184919; Mon, 18 Sep 2023 03:25:06 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-367-Y315YzqNP3aSqZEVH0Q8Og-1; Mon, 18 Sep 2023 06:22:57 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A6986100BAB1; Mon, 18 Sep 2023 10:22:52 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8CF5B40C6EA8; Mon, 18 Sep 2023 10:22:52 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3CB3119465A3; Mon, 18 Sep 2023 10:22:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3EA45194658C for ; Mon, 18 Sep 2023 10:22:50 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2FB0A40C2070; Mon, 18 Sep 2023 10:22:50 +0000 (UTC) Received: from orca.home.lan (unknown [10.45.225.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id A804040C2064; Mon, 18 Sep 2023 10:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695032705; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=doh4T2ohvQ1Oc0+uMZ8tNvlD8o67gEBKvG2NoWfUtQQ=; b=Y7qBs67uW+A7RFX4qXq6F2L1cGvAH8ggVWIJJZga7n6FUxktZ8+dQXRQlR5/xgGuTKEDhW hfamtzhirsKzDFU7bDrEdK3aa80m713JM/hqc5cJGdcjOSf/BWw6xOQzd6asP8v776zrQi 5I+iMOlvTeIZPtaL6TbBaKsRSxUzQVo= X-MC-Unique: Y315YzqNP3aSqZEVH0Q8Og-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH 01/12] syntax-check: Drop the shell's 'check for minus' rule Date: Mon, 18 Sep 2023 12:22:37 +0200 Message-ID: <4c8c90a613cedcb1b94a1abf40e4c5170fe6560a.1695032553.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695032706766100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Apparently we've only had it because the -[ao] options weren't portable at the time, but according to https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html both are defined in POSIX.1-2017 revision which is old enough for all our supported platforms to have adopted it already. Therefore, drop the rule. Signed-off-by: Erik Skultety Reviewed-by: Daniel P. Berrang=C3=A9 --- build-aux/syntax-check.mk | 9 --------- 1 file changed, 9 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index d7cf109fbd..5718768193 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1201,15 +1201,6 @@ sc_prohibit_double_semicolon: halt=3D"Double semicolon detected" \ $(_sc_search_regexp) =20 -_ptm1 =3D use "test C1 && test C2", not "test C1 -''a C2" -_ptm2 =3D use "test C1 || test C2", not "test C1 -''o C2" -# Using test's -a and -o operators is not portable. -# We prefer test over [, since the latter is spelled [[ in configure.ac. -sc_prohibit_test_minus_ao: - @prohibit=3D'(\