From nobody Sun Apr 5 13:07:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774363437; cv=none; d=zohomail.com; s=zohoarc; b=Ymf8bwHGtd/o2PkC7cdzmgPrL3BNAuwXEOAXFvW4LmJrGVq53aERyq2eBnDLQLVZcq+b/ootrOzyd0Hi76GZ2r9FocGzjOg1GHbQJ51i1/OExREkgpHpYaCITzZ9IlEwJjjsNW6+cCRpYhq/8zG/ILgBJEAdnRP36lLYVxgtgCg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774363437; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=hFsj+vkMDFRB7Oo4XAQgor/pSCV7oFUu5pCkTRjpzUs=; b=ezu0DySqlXhPKepRODckInTJvDpxjBESSnfbn+hNzl2rLr05J/ed0bQOfG3thTsPb2byaffbmogDkkQIkby3kLjSbxJc9xWrjMeZC0NfuV1D8I6FqQqk3zcs1hezQfWGQAzCwXtBnhXRaRrpxVAH0S0V02oadgzYlXQNr3avDdA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774363437001271.2908077432837; Tue, 24 Mar 2026 07:43:57 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 177F33F2F8; Tue, 24 Mar 2026 10:43:56 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id B264F3F362; Tue, 24 Mar 2026 10:42:40 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id B68523F280; Tue, 24 Mar 2026 10:42:32 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 38F863F282 for ; Tue, 24 Mar 2026 10:42:32 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-VcAuKZKHOTSIkZ6m_NpRtA-1; Tue, 24 Mar 2026 10:42:30 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D3E70195608C for ; Tue, 24 Mar 2026 14:42:29 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DC5751955D71 for ; Tue, 24 Mar 2026 14:42:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774363351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hFsj+vkMDFRB7Oo4XAQgor/pSCV7oFUu5pCkTRjpzUs=; b=SSGqpIO/lkhlv6BlLduTpkoG25baE7x9pmD1TBKT6SkJyxvtyrDhjgoRD5ID1/m8Ei6vN8 LAw2yOEz2oywb5oaNJfcffc1dpZk7fdWNbOEH36hVmN66BYdigFRlx+xveGBzy83zrkYGQ r0kMYrejevE4QIbedblYOGPvfDXBSQY= X-MC-Unique: VcAuKZKHOTSIkZ6m_NpRtA-1 X-Mimecast-MFC-AGG-ID: VcAuKZKHOTSIkZ6m_NpRtA_1774363350 To: devel@lists.libvirt.org Subject: [PATCH 2/4] qemuDomainGetStatsBlockExportDisk: Export stats also for 'dataStore' Date: Tue, 24 Mar 2026 15:42:22 +0100 Message-ID: <4c3fa111e6aaf8c833db74eae8ecf7d97964f389.1774363234.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MVQZsOV99l9mzFXfkg7VnYcJqIvoxqzaPFad7l-9GNE_1774363350 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KUBWT4PG7MCA6X3IK75NUTBS5DSMBPMF X-Message-ID-Hash: KUBWT4PG7MCA6X3IK75NUTBS5DSMBPMF X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774363442196154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa For qcow2 disk images backed by another storage for storing the actual blocks (the 'data-file' feature) we forgot to export stats in the bulk stats API. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6fa6170b6f..d92269d3b6 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17906,6 +17906,20 @@ qemuDomainGetStatsBlockExportDisk(virDomainDiskDef= *disk, if (!visitBacking) break; + + if (virStorageSourceIsBacking(n->dataFileStore)) { + qemuDomainGetStatsBlockExportHeader(disk, n->dataFileStore, + *recordnr, params); + + qemuDomainGetStatsOneBlock(cfg, dom, params, + qemuBlockStorageSourceGetEffectiveN= odename(n->dataFileStore), + n->dataFileStore, + *recordnr, stats); + + qemuDomainGetStatsBlockExportBackendStorage(qemuBlockStorageSo= urceGetStorageNodename(n->dataFileStore), + stats, *recordnr, = params); + (*recordnr)++; + } } /* in blockdev mode where we can properly and uniquely identify images= we --=20 2.53.0