From nobody Sun Feb 8 07:21:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600884933; cv=none; d=zohomail.com; s=zohoarc; b=h63bWedEULJwjSiFbi+8tbFdovUvI6mxg8ClLiQ8oBpppAQYtKWn58EUBSYA4v24yK5k8oqH6MdavUH8kl9DXq6ZoSHwb273wqhr7wGfioiqY7h82qWKXvbFx7Cn5iMPsBLNmHbG0EP7almB6cATUD4J450VjQP8VdrGXfzSVIw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600884933; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EODSCV6IYf6dnOYDMUxo/6fZra5HMmPv9kUGJyWw9kU=; b=OIqM8g+U8nXOC2U0C8QpNEgXrM/3mv3xTOEtjuJP3HDrD/w/i/CdXAxdFsgafdO/X0XJJO2RTtIo4vS/+ZezCyl2BHdxZK5G911kB8ylmqoFAPAjuSEeMQ5eKPffVNHT+ZtVyLHEgBqsDXqhBUfoHy1mXCPaAb0uIgcxyR7orBU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1600884933753262.64618132036014; Wed, 23 Sep 2020 11:15:33 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-104-3kZ21fC9OceyGZceZeFvuQ-1; Wed, 23 Sep 2020 14:15:29 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F20E010BBED4; Wed, 23 Sep 2020 18:15:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D1DB655784; Wed, 23 Sep 2020 18:15:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9ED8F44A7F; Wed, 23 Sep 2020 18:15:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08NIFB9h018005 for ; Wed, 23 Sep 2020 14:15:11 -0400 Received: by smtp.corp.redhat.com (Postfix) id D495B78816; Wed, 23 Sep 2020 18:15:11 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5CCBA78827 for ; Wed, 23 Sep 2020 18:15:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600884932; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=EODSCV6IYf6dnOYDMUxo/6fZra5HMmPv9kUGJyWw9kU=; b=cAwYoxRcoLROxDtiSWSXdFmS44foJKuAcaOYlg5/QpAcp3reonSEhkpuZARRUQxGA7CsTP LqTO7YmKxQrvdN1UFwmZ3UMi28BPt2PBfOLBn5D7L6jf4mKJpBLuJZhCZhLCCDwwGeeWLh LBzoXvRfwlEc7iqLJvM3gHg+VFGXs78= X-MC-Unique: 3kZ21fC9OceyGZceZeFvuQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 04/14] Remove pointless assignments Date: Wed, 23 Sep 2020 20:14:53 +0200 Message-Id: <4c35db10c1ba0883836ff4e81022a759ddad67fd.1600884543.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) There's no need to initialize every variable, especially not if it's overwritten two lines later. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Martin Kletzander --- examples/c/admin/logging.c | 2 +- src/libxl/libxl_driver.c | 2 +- src/vbox/vbox_common.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/c/admin/logging.c b/examples/c/admin/logging.c index 730ae40d9d..c183c4867d 100644 --- a/examples/c/admin/logging.c +++ b/examples/c/admin/logging.c @@ -29,7 +29,7 @@ int main(int argc, char **argv) const char *set_outputs =3D NULL; const char *set_filters =3D NULL; =20 - ret =3D c =3D -1; + ret =3D -1; opterr =3D 0; =20 while ((c =3D getopt(argc, argv, ":hpo:f:")) > 0) { diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 161a6882f3..ea7d08cd11 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -5423,7 +5423,7 @@ libxlDiskSectorSize(int domid, int devno) return ret; } =20 - path =3D val =3D NULL; + val =3D NULL; path =3D g_strdup_printf("/local/domain/%d/device/vbd/%d/backend", dom= id, devno); =20 if ((val =3D xs_read(handle, XBT_NULL, path, &len)) =3D=3D NULL) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 99c7fbd117..2783827012 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -4618,7 +4618,7 @@ vboxSnapshotRedefine(virDomainPtr dom, if (openSessionForMachine(data, dom->uuid, &domiid, &machine) < 0) goto cleanup; =20 - rc =3D gVBoxAPI.UIMachine.SaveSettings(machine); + gVBoxAPI.UIMachine.SaveSettings(machine); /* It may failed when the machine is not mutable. */ rc =3D gVBoxAPI.UIMachine.GetSettingsFilePath(machine, &settingsFilePa= th); if (NS_FAILED(rc)) { --=20 2.26.2