From nobody Sun Feb 8 19:35:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1660137430; cv=none; d=zohomail.com; s=zohoarc; b=ks14E6cf8zpdMHD5sQED8RFmK5P0ejpOueDt6dgtzlnRBBbJqneA6QiCo1ekKxo7X/dlZXG1zZYTpw5omb1df5B5kYQqWvHtdE1NRBODLret9MU7SCGBMg3Lau2AUGZSQ9NGvtcC/4dwQnT7B0Npo3eMsgMrQxTAXOfhS0egF7A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660137430; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SbzuUGLJdwYj0IwgBvJDYrjo+KrVMdIO5lis/vra9DU=; b=kjBUyVHCETfO13dWxQkWTj497Vw335eIjvAzBBhXXAnTa/C+1EGQJN7RIFlhgRJr474nFvk2gEDlj1sY76ueaCY8f9TiaXh2M+gVOnFYeKMQn9jOTougBPVGyBkOYpeiUvP3VJnoUF9mTcJfnUSTe48Zu6ApThsrhopiKOGPAg0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1660137430062982.8602429183318; Wed, 10 Aug 2022 06:17:10 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-513-bV6GSJydNX21J6LJewWMqQ-1; Wed, 10 Aug 2022 09:17:06 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E5B002999B33; Wed, 10 Aug 2022 13:17:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id D3BC2492C3B; Wed, 10 Aug 2022 13:17:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9699C1946A55; Wed, 10 Aug 2022 13:17:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2E6361946A4F for ; Wed, 10 Aug 2022 12:57:10 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 232BC40D282E; Wed, 10 Aug 2022 12:57:10 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id C338F40D2827 for ; Wed, 10 Aug 2022 12:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660137428; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=SbzuUGLJdwYj0IwgBvJDYrjo+KrVMdIO5lis/vra9DU=; b=KF1NoKnm3Q1cU+jX3fk6vnNLECbZRsEBJB3ntbW370RdXGDPzA9JwCgV4RRsjEDgX5EBgv jZgGW2avGx/1wQJ+U0rhBV10vSTf49Rn0ZpJYay0F3omuwhcVz+T1O6CPmcUWMJ4ok286w 3Y1uqTVzrDpntJX7MfkUxvP2kglcljY= X-MC-Unique: bV6GSJydNX21J6LJewWMqQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Kristina Hanicova To: libvir-list@redhat.com Subject: [PATCH 1/5] qemu: beginJob: move saveStatus into private job callbacks Date: Wed, 10 Aug 2022 14:57:00 +0200 Message-Id: <4bfa6c21470e4835c1d1a728ca94432d9789b5ec.1660136124.git.khanicov@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1660137431842100001 Content-Type: text/plain; charset="utf-8"; x-default="true" It makes sense to move this to other hypervisor-based functions into the private job callback structure to make begin job general. Signed-off-by: Kristina Hanicova Reviewed-by: J=C3=A1n Tomko --- src/hypervisor/domain_job.h | 2 ++ src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domainjob.c | 4 ++-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/hypervisor/domain_job.h b/src/hypervisor/domain_job.h index 30893dabc3..838cfd16e3 100644 --- a/src/hypervisor/domain_job.h +++ b/src/hypervisor/domain_job.h @@ -196,6 +196,7 @@ typedef int (*virDomainObjPrivateJobFormat)(virBuffer *, typedef int (*virDomainObjPrivateJobParse)(xmlXPathContextPtr, virDomainJobObj *, virDomainObj *); +typedef void (*virDomainObjPrivateSaveStatus)(virDomainObj *obj); =20 struct _virDomainObjPrivateJobCallbacks { virDomainObjPrivateJobAlloc allocJobPrivate; @@ -203,6 +204,7 @@ struct _virDomainObjPrivateJobCallbacks { virDomainObjPrivateJobReset resetJobPrivate; virDomainObjPrivateJobFormat formatJobPrivate; virDomainObjPrivateJobParse parseJobPrivate; + virDomainObjPrivateSaveStatus saveStatusPrivate; }; =20 =20 diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index bc5961a09f..94b50420fe 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -366,6 +366,7 @@ static virDomainObjPrivateJobCallbacks qemuPrivateJobCa= llbacks =3D { .resetJobPrivate =3D qemuJobResetPrivate, .formatJobPrivate =3D qemuDomainFormatJobPrivate, .parseJobPrivate =3D qemuDomainParseJobPrivate, + .saveStatusPrivate =3D qemuDomainSaveStatus, }; =20 /** diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c index d682f7be38..11f30de136 100644 --- a/src/qemu/qemu_domainjob.c +++ b/src/qemu/qemu_domainjob.c @@ -844,8 +844,8 @@ qemuDomainObjBeginJobInternal(virQEMUDriver *driver, priv->job.agentStarted =3D now; } =20 - if (virDomainTrackJob(job)) - qemuDomainSaveStatus(obj); + if (virDomainTrackJob(job) && priv->job.cb) + priv->job.cb->saveStatusPrivate(obj); =20 return 0; =20 --=20 2.37.1