From nobody Fri Dec 19 00:05:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 174187357268835.770534869367225; Thu, 13 Mar 2025 06:46:12 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0BC19162; Thu, 13 Mar 2025 09:46:12 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id ABCF81F5B; Thu, 13 Mar 2025 09:44:54 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id AD6841D02; Thu, 13 Mar 2025 09:44:47 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 369501D02 for ; Thu, 13 Mar 2025 09:44:47 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-v8kPQEbKPJ-jT9zsiYSbnw-1; Thu, 13 Mar 2025 09:44:45 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 71D5D180025E for ; Thu, 13 Mar 2025 13:44:44 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C11481955BCB for ; Thu, 13 Mar 2025 13:44:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741873486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gIu9kQFrc5CCdxpYpZL9MT0PFmKzvmS+W3a84oXomgo=; b=DOyQxbv5oy/wlPmcxdTYudw4vX8UkRh5/sbUtDhFHK2nMrTVVznZZS9Hf/l5dBkJQzE9nl bLQlFFoLrxL4+UQVWWAab4bzvJ6OVviMdPCH2HoUj5u1u7tK24dPf3OyPRaMOSwuiXcJH0 yOa3wMDCLPCfGhVw5mZrc8j3WqTWHKQ= X-MC-Unique: v8kPQEbKPJ-jT9zsiYSbnw-1 X-Mimecast-MFC-AGG-ID: v8kPQEbKPJ-jT9zsiYSbnw_1741873484 From: Michal Privoznik To: devel@lists.libvirt.org Subject: [PATCH 3/6] ch: Don't leak virCHDomainObjPrivate struct members Date: Thu, 13 Mar 2025 14:44:35 +0100 Message-ID: <4b5d4650d25e5f1a6bbebacb03c8e6589aa1bded.1741873456.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rF58mhO22Jta-SLzrgXgcR5Inn01YrmcPHCNRsilSDI_1741873484 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FW3F2HWQ4AKBIWIA25VKJDZUZGSN3ILS X-Message-ID-Hash: FW3F2HWQ4AKBIWIA25VKJDZUZGSN3ILS X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741873573838019000 Content-Type: text/plain; charset="utf-8"; x-default="true" There are some members of the virCHDomainObjPrivate struct that are allocated at various stages of domain lifecycle but then are never freed: 1) cgroup - allocated in virDomainCgroupSetupCgroup() 2) autoCpuset - this one is actually never allocated (and thus is always NULL, but soon it may be used. Just free it for now, which is a NOP anyways. 3) autoNodeset - same story as 2). There are two more members, which shouldn't be freed: 1) driver - this is just a raw pointer to the CH driver (see virCHDomainObjPrivateAlloc()). 2) monitor - this member is cleared in virCHProcessStop(), way before control even gets to virCHDomainObjPrivateFree(). 452 (400 direct, 52 indirect) bytes in 1 blocks are definitely lost in loss= record 1,944 of 1,998 at 0x484CEF3: calloc (vg_replace_malloc.c:1675) by 0x4F0E7A9: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.8000.5) by 0x49479CE: virCgroupNewFromParent (vircgroup.c:893) by 0x49481BA: virCgroupNewDomainPartition (vircgroup.c:1068) by 0x494915E: virCgroupNewMachineManual (vircgroup.c:1378) by 0x49492FE: virCgroupNewMachine (vircgroup.c:1432) by 0x4B5E3DE: virDomainCgroupInitCgroup (domain_cgroup.c:377) by 0x4B5E9CD: virDomainCgroupSetupCgroup (domain_cgroup.c:524) by 0xB3AC693: virCHProcessStart (ch_process.c:951) by 0xB39B7D4: chDomainCreateXML (ch_driver.c:246) by 0x4CC9D32: virDomainCreateXML (libvirt-domain.c:188) by 0x168F91: remoteDispatchDomainCreateXML (remote_daemon_dispatch_stubs= .h:5186) Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/ch/ch_domain.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c index 4f5966adce..a08b18c5b9 100644 --- a/src/ch/ch_domain.c +++ b/src/ch/ch_domain.c @@ -65,6 +65,9 @@ virCHDomainObjPrivateFree(void *data) =20 virChrdevFree(priv->chrdevs); g_free(priv->machineName); + virBitmapFree(priv->autoCpuset); + virBitmapFree(priv->autoNodeset); + virCgroupFree(priv->cgroup); g_free(priv); } =20 --=20 2.48.1