From nobody Sun Feb 8 22:51:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747323352; cv=none; d=zohomail.com; s=zohoarc; b=TVkcZHsk7iA89V0YBNxSqp63RLuWFqLvy8vHvcENMBrNyp6dN6mBHAVd0Eknf0U0R1vYob4Gl2yrpBVeCJSrqjLfaW8KN+MbATXOoLwxmKnOUJ7jbx2ycsMrKXhH5Dmfz+tObp9lP/GHkL7/jyhJyYD4e+v4TMTyljKRpdabNyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747323352; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=MTdV1LH5ISpKkLFgvEw3VZJ4iCB6AVF4TKws8W1erUU=; b=kiNodlGV/Ml3/mkH57lqNkeM67CMzDdyjHY+6qQcp7TVZU50HxvH3BlIuu9k8Yi+yoZXWZMvvVtrPeRTv7FVtB7oZM5gSW6IuB/BszEe0r8HjAExCcmDXKj9jiCubO6F73LwMxGwarShHD8Cc7g/1GCV5hpOMDnT7BU5gdXyNwg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747323352183995.730892023812; Thu, 15 May 2025 08:35:52 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3C3B9E68; Thu, 15 May 2025 11:35:51 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 4073614AC; Thu, 15 May 2025 11:30:03 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id DD96D147B; Thu, 15 May 2025 11:29:51 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0AA591448 for ; Thu, 15 May 2025 11:29:35 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-UOZ2qsEpMe6YFJxsoyIQCQ-1; Thu, 15 May 2025 11:29:32 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ADFE4195608B for ; Thu, 15 May 2025 15:29:31 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.37]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AB7E7180045B; Thu, 15 May 2025 15:29:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747322974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AaJuxpmiOdVqYoqj0Rww3b1r/hu0RG4SU+zznHS8cic=; b=PuF0sw20pWOSfTxmFllSDhbBFfcMOV2XXSJHtepB0QMkL86yhH7kXf1agaRK3Ys5CB//uC hrKJ0sGmsxDJL+nSFh4Va7HTFqNFkwDa/WmfqjgYYfiJo9h1xeJ/4H6tUlkYG3AjMwcFGh VgfunV4kiX3veB0yhPJDrXGdjQZdrBE= X-MC-Unique: UOZ2qsEpMe6YFJxsoyIQCQ-1 X-Mimecast-MFC-AGG-ID: UOZ2qsEpMe6YFJxsoyIQCQ_1747322971 To: devel@lists.libvirt.org Subject: [PATCH 13/17] qemuProcessStop: Drop 'driver' argument Date: Thu, 15 May 2025 17:28:58 +0200 Message-ID: <4b2bf1bcb5ef5d2de14b5928e9aeeb80fca215e8.1747322588.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xGZKB0sGNmL7BosUuWCCMwQlwr3wVbF9byCv14JOwEU_1747322971 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: GEAJKXMXZSBHOLM6IILBCPLVGOAD3ISB X-Message-ID-Hash: GEAJKXMXZSBHOLM6IILBCPLVGOAD3ISB X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Peter Krempa X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747323353408116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa For now it's extracted as a temporary variable but in long term it ought to be eliminated. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 22 ++++++++-------------- src/qemu/qemu_migration.c | 8 ++++---- src/qemu/qemu_process.c | 21 +++++++++++---------- src/qemu/qemu_process.h | 3 +-- src/qemu/qemu_saveimage.c | 2 +- src/qemu/qemu_snapshot.c | 18 ++++++------------ 6 files changed, 31 insertions(+), 43 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6d43c2415c..50a5cdd594 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2057,8 +2057,7 @@ qemuDomainDestroyFlags(virDomainPtr dom, if (vm->job->asyncJob =3D=3D VIR_ASYNC_JOB_MIGRATION_IN) stopFlags |=3D VIR_QEMU_PROCESS_STOP_MIGRATED; - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_DESTROYED, - VIR_ASYNC_JOB_NONE, stopFlags); + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_DESTROYED, VIR_ASYNC_JOB_NONE, = stopFlags); if ((flags & VIR_DOMAIN_DESTROY_REMOVE_LOGS) && qemuDomainRemoveLogs(driver, vm->def->name) < 0) @@ -2681,8 +2680,7 @@ qemuDomainSaveInternal(virQEMUDriver *driver, goto endjob; /* Shut it down */ - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_SAVED, - VIR_ASYNC_JOB_SAVE, 0); + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_SAVED, VIR_ASYNC_JOB_SAVE, 0); virDomainAuditStop(vm, "saved"); event =3D virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPP= ED, VIR_DOMAIN_EVENT_STOPPED_SAV= ED); @@ -3212,8 +3210,7 @@ qemuDomainCoreDumpWithFormat(virDomainPtr dom, endjob: if ((ret =3D=3D 0) && (flags & VIR_DUMP_CRASH)) { - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_CRASHED, - VIR_ASYNC_JOB_DUMP, 0); + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_CRASHED, VIR_ASYNC_JOB_DUMP= , 0); virDomainAuditStop(vm, "crashed"); event =3D virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, @@ -3535,8 +3532,7 @@ processGuestPanicEvent(virQEMUDriver *driver, G_GNUC_FALLTHROUGH; case VIR_DOMAIN_LIFECYCLE_ACTION_DESTROY: - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_CRASHED, - VIR_ASYNC_JOB_DUMP, 0); + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_CRASHED, VIR_ASYNC_JOB_DUMP= , 0); event =3D virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_STOPPED= _CRASHED); @@ -3890,7 +3886,7 @@ processMonitorEOFEvent(virQEMUDriver *driver, event =3D virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPP= ED, eventReason); - qemuProcessStop(driver, vm, stopReason, VIR_ASYNC_JOB_NONE, stopFlags); + qemuProcessStop(vm, stopReason, VIR_ASYNC_JOB_NONE, stopFlags); virDomainAuditStop(vm, auditReason); virObjectEventStateQueue(driver->domainEventState, event); @@ -4050,15 +4046,13 @@ processNbdkitExitedEvent(virDomainObj *vm, static void -processShutdownCompletedEvent(virQEMUDriver *driver, - virDomainObj *vm) +processShutdownCompletedEvent(virDomainObj *vm) { if (qemuProcessBeginStopJob(vm, VIR_JOB_DESTROY, true) < 0) return; if (virDomainObjIsActive(vm)) { - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_UNKNOWN, - VIR_ASYNC_JOB_NONE, 0); + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_UNKNOWN, VIR_ASYNC_JOB_NONE= , 0); } qemuProcessEndStopJob(vm); @@ -4129,7 +4123,7 @@ static void qemuProcessEventHandler(void *data, void = *opaque) processNbdkitExitedEvent(vm, processEvent->data); break; case QEMU_PROCESS_EVENT_SHUTDOWN_COMPLETED: - processShutdownCompletedEvent(driver, vm); + processShutdownCompletedEvent(vm); break; case QEMU_PROCESS_EVENT_LAST: break; diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index bb4d74a65d..f38733f904 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -3438,7 +3438,7 @@ qemuMigrationDstPrepareActive(virQEMUDriver *driver, if (!relabel) stopFlags |=3D VIR_QEMU_PROCESS_STOP_NO_RELABEL; virDomainAuditStart(vm, "migrated", false); - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED, + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_FAILED, VIR_ASYNC_JOB_MIGRATION_IN, stopFlags); virPortAllocatorRelease(priv->nbdPort); priv->nbdPort =3D 0; @@ -4082,7 +4082,7 @@ qemuMigrationSrcComplete(virQEMUDriver *driver, * up domain shutdown until SPICE server transfers its data */ qemuMigrationSrcWaitForSpice(vm); - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_MIGRATED, asyncJob, + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_MIGRATED, asyncJob, VIR_QEMU_PROCESS_STOP_MIGRATED); virDomainAuditStop(vm, "migrated"); @@ -6301,7 +6301,7 @@ qemuMigrationSrcPerformJob(virQEMUDriver *driver, * confirm step. */ if (!v3proto) { - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_MIGRATED, + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_MIGRATED, VIR_ASYNC_JOB_MIGRATION_OUT, VIR_QEMU_PROCESS_STOP_MIGRATED); virDomainAuditStop(vm, "migrated"); @@ -6954,7 +6954,7 @@ qemuMigrationDstFinishActive(virQEMUDriver *driver, if (qemuDomainObjIsActive(vm)) { if (doKill) { - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED, + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_FAILED, VIR_ASYNC_JOB_MIGRATION_IN, VIR_QEMU_PROCESS_STOP_MIGRATED); virDomainAuditStop(vm, "failed"); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 5636d4fb76..1432ec28d7 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -5961,7 +5961,7 @@ qemuProcessInit(virQEMUDriver *driver, stopFlags =3D VIR_QEMU_PROCESS_STOP_NO_RELABEL; if (migration) stopFlags |=3D VIR_QEMU_PROCESS_STOP_MIGRATED; - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED, asyncJob, stopF= lags); + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_FAILED, asyncJob, stopFlags); return -1; } @@ -8568,7 +8568,7 @@ qemuProcessStart(virConnectPtr conn, stopFlags |=3D VIR_QEMU_PROCESS_STOP_MIGRATED; if (priv->mon) qemuMonitorSetDomainLog(priv->mon, NULL, NULL, NULL); - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED, asyncJob, stopF= lags); + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_FAILED, asyncJob, stopFlags); goto cleanup; } @@ -8917,15 +8917,16 @@ qemuProcessEndStopJob(virDomainObj *vm) } -void qemuProcessStop(virQEMUDriver *driver, - virDomainObj *vm, - virDomainShutoffReason reason, - virDomainAsyncJob asyncJob, - unsigned int flags) +void +qemuProcessStop(virDomainObj *vm, + virDomainShutoffReason reason, + virDomainAsyncJob asyncJob, + unsigned int flags) { int ret; int retries =3D 0; qemuDomainObjPrivate *priv =3D vm->privateData; + virQEMUDriver *driver =3D priv->driver; virErrorPtr orig_err; virDomainDef *def =3D vm->def; size_t i; @@ -9264,7 +9265,7 @@ qemuProcessAutoDestroy(virDomainObj *dom, if (qemuProcessBeginStopJob(dom, VIR_JOB_DESTROY, true) < 0) return; - qemuProcessStop(driver, dom, VIR_DOMAIN_SHUTOFF_DESTROYED, + qemuProcessStop(dom, VIR_DOMAIN_SHUTOFF_DESTROYED, VIR_ASYNC_JOB_NONE, stopFlags); virDomainAuditStop(dom, "destroyed"); @@ -9828,7 +9829,7 @@ qemuProcessReconnect(void *opaque) * thread didn't have a chance to start playing with the domain yet * (it's all we can do anyway). */ - qemuProcessStop(driver, obj, state, VIR_ASYNC_JOB_NONE, stopFlags); + qemuProcessStop(obj, state, VIR_ASYNC_JOB_NONE, stopFlags); } goto cleanup; } @@ -9868,7 +9869,7 @@ qemuProcessReconnectHelper(virDomainObj *obj, * is no thread that could be doing anything else with the same do= main * object. */ - qemuProcessStop(src->driver, obj, VIR_DOMAIN_SHUTOFF_FAILED, + qemuProcessStop(obj, VIR_DOMAIN_SHUTOFF_FAILED, VIR_ASYNC_JOB_NONE, 0); qemuDomainRemoveInactiveLocked(src->driver, obj); diff --git a/src/qemu/qemu_process.h b/src/qemu/qemu_process.h index 6d5f189aa4..b8c4af4aaf 100644 --- a/src/qemu/qemu_process.h +++ b/src/qemu/qemu_process.h @@ -176,8 +176,7 @@ int qemuProcessBeginStopJob(virDomainObj *vm, virDomainJob job, bool forceKill); void qemuProcessEndStopJob(virDomainObj *vm); -void qemuProcessStop(virQEMUDriver *driver, - virDomainObj *vm, +void qemuProcessStop(virDomainObj *vm, virDomainShutoffReason reason, virDomainAsyncJob asyncJob, unsigned int flags); diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c index a6a5fb486e..702df641a0 100644 --- a/src/qemu/qemu_saveimage.c +++ b/src/qemu/qemu_saveimage.c @@ -773,7 +773,7 @@ qemuSaveImageStartVM(virConnectPtr conn, cleanup: if (ret < 0 && started) { - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED, + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_FAILED, asyncJob, VIR_QEMU_PROCESS_STOP_MIGRATED); } return ret; diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index db5ba1eece..a17b976381 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -595,7 +595,7 @@ qemuSnapshotCreateActiveInternal(virQEMUDriver *driver, if (flags & VIR_DOMAIN_SNAPSHOT_CREATE_HALT) { event =3D virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_S= TOPPED, VIR_DOMAIN_EVENT_STOPPED_FROM_SNA= PSHOT); - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT, + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT, VIR_ASYNC_JOB_SNAPSHOT, 0); virDomainAuditStop(vm, "from-snapshot"); resume =3D false; @@ -1694,8 +1694,7 @@ qemuSnapshotCreateActiveExternal(virQEMUDriver *drive= r, if (flags & VIR_DOMAIN_SNAPSHOT_CREATE_HALT) { event =3D virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_S= TOPPED, VIR_DOMAIN_EVENT_STOPPED_FROM_SNA= PSHOT); - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT, - VIR_ASYNC_JOB_SNAPSHOT, 0); + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT, VIR_ASYNC_JO= B_SNAPSHOT, 0); virDomainAuditStop(vm, "from-snapshot"); resume =3D false; thaw =3D false; @@ -2615,9 +2614,7 @@ qemuSnapshotRevertActive(virDomainObj *vm, /* Transitions 2, 3, 5, 6, 8, 9 */ if (virDomainObjIsActive(vm)) { /* Transitions 5, 6, 8, 9 */ - qemuProcessStop(driver, vm, - VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT, - VIR_ASYNC_JOB_SNAPSHOT, 0); + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT, VIR_ASYNC_JO= B_SNAPSHOT, 0); virDomainAuditStop(vm, "from-snapshot"); detail =3D VIR_DOMAIN_EVENT_STOPPED_FROM_SNAPSHOT; event =3D virDomainEventLifecycleNewFromObj(vm, @@ -2651,7 +2648,7 @@ qemuSnapshotRevertActive(virDomainObj *vm, start_flags, "from-snapshot", &started) < 0) { if (started) { - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED, + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_FAILED, VIR_ASYNC_JOB_SNAPSHOT, VIR_QEMU_PROCESS_STOP_MIGRATED); } @@ -2761,8 +2758,7 @@ qemuSnapshotRevertInactive(virDomainObj *vm, if (virDomainObjIsActive(vm)) { /* Transitions 4, 7 */ - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT, - VIR_ASYNC_JOB_SNAPSHOT, 0); + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT, VIR_ASYNC_JO= B_SNAPSHOT, 0); virDomainAuditStop(vm, "from-snapshot"); detail =3D VIR_DOMAIN_EVENT_STOPPED_FROM_SNAPSHOT; event =3D virDomainEventLifecycleNewFromObj(vm, @@ -4356,8 +4352,6 @@ qemuSnapshotDelete(virDomainObj *vm, virDomainMomentObj *snap =3D NULL; bool metadata_only =3D !!(flags & VIR_DOMAIN_SNAPSHOT_DELETE_METADATA_= ONLY); bool stop_qemu =3D false; - qemuDomainObjPrivate *priv =3D vm->privateData; - virQEMUDriver *driver =3D priv->driver; g_autoslist(qemuSnapshotDeleteExternalData) externalData =3D NULL; virCheckFlags(VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN | @@ -4393,7 +4387,7 @@ qemuSnapshotDelete(virDomainObj *vm, endjob: if (stop_qemu) { - qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_SHUTDOWN, + qemuProcessStop(vm, VIR_DOMAIN_SHUTOFF_SHUTDOWN, VIR_ASYNC_JOB_SNAPSHOT, 0); } --=20 2.49.0