From nobody Sun Feb 8 17:04:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626864243; cv=none; d=zohomail.com; s=zohoarc; b=dPzIGestNvyDMRqU7TZPmIcXtRl0K2K6OKs7mGi5oH4pmGeWUqfXxhG2Q6F3Db1rVz2QMZkxFEf5wPFim4uC5rwtEG1+hABVt45oRGrngx+907L8bXOr42RPBv8isSQs3Urr37gJOa7EpfY4Y7Z7dGbC6a1nBcPVMFsPW8vuuXI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626864243; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=r2hg0d5hTHBYWeEQrHMEHWb/W6o481hBR5ntwZXqHcw=; b=NcquH0iFb5Kkozitfg4gGhGJgeIQ9KyhdGsuC9lHF6hEkc0t47e/Vcfi3epMz1jHaq+szZ7Kq1x1OcGbVul7i2Qo77RbUVdjhNUvXnPF1l6859yxg+L5g3zDSxkPc6vBly8ItiWMe53VZW1qtkRJcItAqqJ1hFI/oZP35GYmWno= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626864243764837.5865313550687; Wed, 21 Jul 2021 03:44:03 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-4BDSzN8nMaS5Mun2KPI3AQ-1; Wed, 21 Jul 2021 06:43:26 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 552F28026AD; Wed, 21 Jul 2021 10:43:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 306A484A0B; Wed, 21 Jul 2021 10:43:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EF93E181A1FE; Wed, 21 Jul 2021 10:43:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16LAgs2L000843 for ; Wed, 21 Jul 2021 06:42:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id 01FC319D9B; Wed, 21 Jul 2021 10:42:54 +0000 (UTC) Received: from andariel.local (unknown [10.40.193.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6330619C79 for ; Wed, 21 Jul 2021 10:42:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626864242; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=r2hg0d5hTHBYWeEQrHMEHWb/W6o481hBR5ntwZXqHcw=; b=Rerecq0NPiN3vPXaIzJkW+MW5RRSehQWyhnEk+4b6YD0ZJPlH+0oFG7IjdeW2p3GRkEV5G JN2I5eUIKiCJe/5ABTzUrQylO9DtGIaHjPEbqBnn6M1QAMSaikpmu1CKKvJ6YaZi8S+n8S IIjo64501r3206EUeCqGQ4vICksgPtI= X-MC-Unique: 4BDSzN8nMaS5Mun2KPI3AQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 03/33] qemu: Remove return value from qemuMonitorDomainEventCallback Date: Wed, 21 Jul 2021 12:42:15 +0200 Message-Id: <495e9b645f6a8888d56e4e4ce253ce8453e6ef48.1626864131.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626864245566100001 Content-Type: text/plain; charset="utf-8" Change the callback prototype and fix the callback registered in the process code. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.h | 14 +++++++------- src/qemu/qemu_process.c | 4 +--- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 2fa5151652..d20b2e89d1 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -155,13 +155,13 @@ typedef void (*qemuMonitorEofNotifyCallback)(qemuMoni= tor *mon, typedef void (*qemuMonitorErrorNotifyCallback)(qemuMonitor *mon, virDomainObj *vm, void *opaque); -typedef int (*qemuMonitorDomainEventCallback)(qemuMonitor *mon, - virDomainObj *vm, - const char *event, - long long seconds, - unsigned int micros, - const char *details, - void *opaque); +typedef void (*qemuMonitorDomainEventCallback)(qemuMonitor *mon, + virDomainObj *vm, + const char *event, + long long seconds, + unsigned int micros, + const char *details, + void *opaque); typedef int (*qemuMonitorDomainShutdownCallback)(qemuMonitor *mon, virDomainObj *vm, virTristateBool guest, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 914f936e45..6b9658f5ac 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -546,7 +546,7 @@ qemuProcessShutdownOrReboot(virQEMUDriver *driver, } -static int +static void qemuProcessHandleEvent(qemuMonitor *mon G_GNUC_UNUSED, virDomainObj *vm, const char *eventName, @@ -567,8 +567,6 @@ qemuProcessHandleEvent(qemuMonitor *mon G_GNUC_UNUSED, virObjectUnlock(vm); virObjectEventStateQueue(driver->domainEventState, event); - - return 0; } --=20 2.31.1